You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2023/02/18 18:30:14 UTC
[GitHub] [arrow] mapleFU opened a new pull request, #34254: GH-34147: [C++][Parquet] Support crc count and checking on DICTIONARY_PAGE
mapleFU opened a new pull request, #34254:
URL: https://github.com/apache/arrow/pull/34254
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Support counting CRC for dictionary page
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
* [x] Support counting crc for dictionary page when crc enabled
* [x] Support verify crc for dictionary page when checking crc enabled
* [ ] Generate CRC dictionary file using parquet-mr, and do cross-verification
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
4. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
Yes
### Are there any user-facing changes?
Yes, dictionary page could use crc after that
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34254: GH-34147: [C++][Parquet] Support crc count and checking on DICTIONARY_PAGE
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34254:
URL: https://github.com/apache/arrow/pull/34254#issuecomment-1435734799
* Closes: #34147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #34254: GH-34147: [C++][Parquet] Support crc count and checking on DICTIONARY_PAGE
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #34254:
URL: https://github.com/apache/arrow/pull/34254#issuecomment-1460348773
I simpify some logic for unittest in [db20e8b](https://github.com/apache/arrow/pull/34254/commits/db20e8be186cb2ae3361117d8869221e174adc2a), and logic is not changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 merged pull request #34254: GH-34147: [C++][Parquet] Support crc count and checking on DICTIONARY_PAGE
Posted by "wjones127 (via GitHub)" <gi...@apache.org>.
wjones127 merged PR #34254:
URL: https://github.com/apache/arrow/pull/34254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mapleFU commented on pull request #34254: GH-34147: [C++][Parquet] Support crc count and checking on DICTIONARY_PAGE
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #34254:
URL: https://github.com/apache/arrow/pull/34254#issuecomment-1440450166
Test file is here: https://github.com/apache/parquet-testing/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34254: GH-34147: [C++][Parquet] Support crc count and checking on DICTIONARY_PAGE
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34254:
URL: https://github.com/apache/arrow/pull/34254#issuecomment-1435734802
:warning: GitHub issue #34147 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34254: GH-34147: [C++][Parquet] Support crc count and checking on DICTIONARY_PAGE
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34254:
URL: https://github.com/apache/arrow/pull/34254#issuecomment-1463292655
Benchmark runs are scheduled for baseline = bb74cd78cd2d56a5286a2fd2494c79d8ed85d230 and contender = 0ac0f733ff61f2db45cbff54def8768b3ceb8a9d. 0ac0f733ff61f2db45cbff54def8768b3ceb8a9d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/88efb4a410724eb48aeb0a227a4c3e2c...ac220646615248659d28ac02718780fc/)
[Finished :arrow_down:0.21% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/1f3e7a6f78754b3b8cb00b58da0bde47...a35c1f49b8bb441ab4acb53f6d4bc710/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/07a56d37c0ff46cfb59cd6385ffac241...969b6be154b14e0ea0037079d89d825c/)
[Finished :arrow_down:0.5% :arrow_up:0.16%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c03b363275c444ef80aeccf1f5d2b043...ba4b38e3028b45aeae557d20e106bcb7/)
Buildkite builds:
[Finished] [`0ac0f733` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2505)
[Finished] [`0ac0f733` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2535)
[Finished] [`0ac0f733` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2503)
[Finished] [`0ac0f733` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2526)
[Finished] [`bb74cd78` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2504)
[Finished] [`bb74cd78` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2534)
[Finished] [`bb74cd78` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2502)
[Finished] [`bb74cd78` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2525)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org