You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/27 06:30:24 UTC

[GitHub] [hadoop-ozone] mukul1987 opened a new pull request #872: HDDS-3488. Remove unnecessary jackson dependencies from Ozone.

mukul1987 opened a new pull request #872:
URL: https://github.com/apache/hadoop-ozone/pull/872


   ## What changes were proposed in this pull request?
   Remove unnecessary jackson dependencies from Ozone.
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-3488
   
   ## How was this patch tested?
   Build succeeds after removing dependencies.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] elek commented on pull request #872: HDDS-3488. Remove unnecessary jackson version definition from Ozone.

Posted by GitBox <gi...@apache.org>.
elek commented on pull request #872:
URL: https://github.com/apache/hadoop-ozone/pull/872#issuecomment-620009423


   Merged. Thanks the quick fix @mukul1987 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] elek commented on pull request #872: HDDS-3488. Remove unnecessary jackson version definition from Ozone.

Posted by GitBox <gi...@apache.org>.
elek commented on pull request #872:
URL: https://github.com/apache/hadoop-ozone/pull/872#issuecomment-619812109


   > But this is just pedantry as we should remove this section anyway as these dependencies are not defined/used anywhere else...
   
   I was wrong. We got the jackson jar files as transitive dependencies from hadoop-common. In this case this section works as a version enforcement. If we need to remove the jar files from the classpath an exclude rule should be added to `hdds/hadoop-hdds/hadoop-dependency-server/`
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] elek commented on pull request #872: HDDS-3488. Remove unnecessary jackson version definition from Ozone.

Posted by GitBox <gi...@apache.org>.
elek commented on pull request #872:
URL: https://github.com/apache/hadoop-ozone/pull/872#issuecomment-620008708


   Thanks the updated. Now al the classes are fully excluded. I tested it with build + `find -name "*jackson*" and these jackson jars are excluded.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] elek edited a comment on pull request #872: HDDS-3488. Remove unnecessary jackson version definition from Ozone.

Posted by GitBox <gi...@apache.org>.
elek edited a comment on pull request #872:
URL: https://github.com/apache/hadoop-ozone/pull/872#issuecomment-620008708


   Thanks the updated. Now al the classes are fully excluded. I tested it with build + `find -name "*jackson*"` and these jackson jars are excluded.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org