You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/06/07 05:15:48 UTC
[GitHub] [incubator-seatunnel] zhuangchong opened a new pull request, #1991: [api-draft#1990][Common] The DeployMode code cleanup
zhuangchong opened a new pull request, #1991:
URL: https://github.com/apache/incubator-seatunnel/pull/1991
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
this pr closes #1990
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhuangchong commented on pull request #1991: [api-draft#1990][Common] The DeployMode code cleanup
Posted by GitBox <gi...@apache.org>.
zhuangchong commented on PR #1991:
URL: https://github.com/apache/incubator-seatunnel/pull/1991#issuecomment-1148351452
> LGTM
@BenJFan thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhuangchong commented on a diff in pull request #1991: [api-draft#1990][Common] The DeployMode code cleanup
Posted by GitBox <gi...@apache.org>.
zhuangchong commented on code in PR #1991:
URL: https://github.com/apache/incubator-seatunnel/pull/1991#discussion_r890875722
##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/config/Common.java:
##########
@@ -70,19 +54,17 @@ public static Optional<String> getDeployMode() {
* When running seatunnel in --master yarn or --master mesos, you can put plugins related files in plugins dir.
*/
public static Path appRootDir() {
- if (MODE.equals(Optional.of(DeployMode.CLIENT.getName()))) {
+ if (DeployMode.CLIENT == MODE) {
try {
String path = Common.class.getProtectionDomain().getCodeSource().getLocation().toURI().getPath();
path = new File(path).getPath();
return Paths.get(path).getParent().getParent();
} catch (URISyntaxException e) {
throw new RuntimeException(e);
}
- } else if (MODE.equals(Optional.of(DeployMode.CLUSTER.getName()))) {
- return Paths.get("");
- } else {
- throw new IllegalStateException("MODE not support : " + MODE.orElse("null"));
}
+ // deploy mode: cluster
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on a diff in pull request #1991: [api-draft#1990][Common] The DeployMode code cleanup
Posted by GitBox <gi...@apache.org>.
BenJFan commented on code in PR #1991:
URL: https://github.com/apache/incubator-seatunnel/pull/1991#discussion_r890855960
##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/config/Common.java:
##########
@@ -70,19 +54,17 @@ public static Optional<String> getDeployMode() {
* When running seatunnel in --master yarn or --master mesos, you can put plugins related files in plugins dir.
*/
public static Path appRootDir() {
- if (MODE.equals(Optional.of(DeployMode.CLIENT.getName()))) {
+ if (DeployMode.CLIENT == MODE) {
try {
String path = Common.class.getProtectionDomain().getCodeSource().getLocation().toURI().getPath();
path = new File(path).getPath();
return Paths.get(path).getParent().getParent();
} catch (URISyntaxException e) {
throw new RuntimeException(e);
}
- } else if (MODE.equals(Optional.of(DeployMode.CLUSTER.getName()))) {
- return Paths.get("");
- } else {
- throw new IllegalStateException("MODE not support : " + MODE.orElse("null"));
}
+ // deploy mode: cluster
Review Comment:
Please cover this logic in if statement, if we have new another DeployMode then throw not support exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1991: [api-draft#1990][Common] The DeployMode code cleanup
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #1991:
URL: https://github.com/apache/incubator-seatunnel/pull/1991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org