You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/26 16:25:00 UTC

[GitHub] john-bodley commented on a change in pull request #4886: remove hard code http scheme of short url #4656

john-bodley commented on a change in pull request #4886: remove hard code http scheme of short url #4656
URL: https://github.com/apache/incubator-superset/pull/4886#discussion_r184451027
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -748,9 +748,10 @@ def shortner(self):
         obj = models.Url(url=url)
         db.session.add(obj)
         db.session.commit()
+        scheme = request.scheme
 
 Review comment:
   Why do we need this temporary variable? I sense it adds for more obfuscation and thus would include this on line 754.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services