You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/20 16:03:36 UTC
[GitHub] [airflow] MikaYuoadas opened a new pull request #7474:
[AIRFLOW-6854] Fix missing typing_extensions on python 3.8
MikaYuoadas opened a new pull request #7474: [AIRFLOW-6854] Fix missing typing_extensions on python 3.8
URL: https://github.com/apache/airflow/pull/7474
All import from `typing_extensions` should be done through
`airflow.typing_compat` to avoid breakage under python >= 3.8
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] MikaYuoadas commented on issue #7474: [AIRFLOW-6854] Fix
missing typing_extensions on python 3.8
Posted by GitBox <gi...@apache.org>.
MikaYuoadas commented on issue #7474: [AIRFLOW-6854] Fix missing typing_extensions on python 3.8
URL: https://github.com/apache/airflow/pull/7474#issuecomment-589613014
My bad, I removed a `# pylint: disable=unused-import` I thought was related to the line I edited.
Turn out it wasn't. :)
I've put it back in, the test should pass now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7474: [AIRFLOW-6854] Fix
missing typing_extensions on python 3.8
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7474: [AIRFLOW-6854] Fix missing typing_extensions on python 3.8
URL: https://github.com/apache/airflow/pull/7474#issuecomment-589221949
Some static checks to check. Also I think it's a good time to think about pythn 3.8 compatibility
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7474: [AIRFLOW-6854] Fix
missing typing_extensions on python 3.8
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7474: [AIRFLOW-6854] Fix missing typing_extensions on python 3.8
URL: https://github.com/apache/airflow/pull/7474#issuecomment-589639674
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7474?src=pr&el=h1) Report
> Merging [#7474](https://codecov.io/gh/apache/airflow/pull/7474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/aff3a361b4092212c0757f9ce88fa2e40d25d1f4?src=pr&el=desc) will **decrease** coverage by `0.16%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7474 +/- ##
==========================================
- Coverage 86.57% 86.41% -0.17%
==========================================
Files 882 883 +1
Lines 41597 41644 +47
==========================================
- Hits 36013 35985 -28
- Misses 5584 5659 +75
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7474?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/typing\_compat.py](https://codecov.io/gh/apache/airflow/pull/7474/diff?src=pr&el=tree#diff-YWlyZmxvdy90eXBpbmdfY29tcGF0LnB5) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/providers/amazon/aws/operators/ecs.py](https://codecov.io/gh/apache/airflow/pull/7474/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvZWNzLnB5) | `85.43% <100%> (-0.15%)` | :arrow_down: |
| [airflow/providers/amazon/aws/hooks/batch\_client.py](https://codecov.io/gh/apache/airflow/pull/7474/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9iYXRjaF9jbGllbnQucHk=) | `96.89% <100%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/ecs\_operator.py](https://codecov.io/gh/apache/airflow/pull/7474/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9lY3Nfb3BlcmF0b3IucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/awsbatch\_operator.py](https://codecov.io/gh/apache/airflow/pull/7474/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9hd3NiYXRjaF9vcGVyYXRvci5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/serialization/json\_schema.py](https://codecov.io/gh/apache/airflow/pull/7474/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL2pzb25fc2NoZW1hLnB5) | `84% <100%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7474/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7474/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7474/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7474/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.38% <0%> (-25.52%)` | :arrow_down: |
| ... and [13 more](https://codecov.io/gh/apache/airflow/pull/7474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7474?src=pr&el=footer). Last update [aff3a36...f59d6b8](https://codecov.io/gh/apache/airflow/pull/7474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7474:
[AIRFLOW-6854] Fix missing typing_extensions on python 3.8
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7474: [AIRFLOW-6854] Fix missing typing_extensions on python 3.8
URL: https://github.com/apache/airflow/pull/7474#issuecomment-589155404
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7474: [AIRFLOW-6854] Fix
missing typing_extensions on python 3.8
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7474: [AIRFLOW-6854] Fix missing typing_extensions on python 3.8
URL: https://github.com/apache/airflow/pull/7474#issuecomment-589639943
Thanks @MikaYuoadas !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7474:
[AIRFLOW-6854] Fix missing typing_extensions on python 3.8
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7474: [AIRFLOW-6854] Fix missing typing_extensions on python 3.8
URL: https://github.com/apache/airflow/pull/7474#issuecomment-589639860
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7474: [AIRFLOW-6854] Fix
missing typing_extensions on python 3.8
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7474: [AIRFLOW-6854] Fix missing typing_extensions on python 3.8
URL: https://github.com/apache/airflow/pull/7474
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services