You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Konstantin Boudnik (JIRA)" <ji...@apache.org> on 2009/08/18 23:03:14 UTC
[jira] Created: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Implementing aspects development and fault injeciton framework for Hadoop
-------------------------------------------------------------------------
Key: HADOOP-6204
URL: https://issues.apache.org/jira/browse/HADOOP-6204
Project: Hadoop Common
Issue Type: Improvement
Components: build, test
Reporter: Konstantin Boudnik
Assignee: Konstantin Boudnik
Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204.patch
Merged w/ trunk
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Status: Patch Available (was: Open)
This patch provides a common part of fault injection framework (src/test/aop/build, src/test/aop/org/apache/hadoop/fi/) and project specific modifications as a part of build.xml file.
The generic part is suppose to be svn:exported to other subprojects (Hdfs, Mapreduce) and customized as needed.
The patch includes some renameing in build.xml file i.e. {{core}} to {{java}} It has been done to make generic part of the FI build less project dependent. Similar modifications will be needed for Hdfs/MapReduce later on.
A separate JIRA will be created to refactor currently existed FI framework in Hdfs to use the one from Common.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-6204:
--------------------------------
Hadoop Flags: [Reviewed]
That's a reasonable explanation. +1 on latest version of patch.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204.patch
The cause of the release audit has been found. {{fi-site.xml}} was missing the standard Apache's boilerplate. My local test-patch log is attached:
{noformat}
+1 overall.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 20 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
{noformat}
Also, there's no failing tests in the Hudson's run: all failures counters are zeroed. Looks like Hudson's going nuts.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Fix Version/s: (was: 0.21.0)
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204-ydist.patch
AspectJ version is set to 1.6.5. Possible OOM problem is fixed. Some blank lines modifications are removed.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6204) Implementing aspects development
and fault injeciton framework for Hadoop
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764292#action_12764292 ]
Hadoop QA commented on HADOOP-6204:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12421795/HADOOP-6204.patch
against trunk revision 823756.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 19 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/79/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/79/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/79/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/79/console
This message is automatically generated.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: wrongTestsPackaging.patch
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, wrongTestsPackaging.patch, wrongTestsPackaging.patch
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I've just committed this.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204_0.20.patch
Yet another glitch is found in the initial backport patch. This version fixes incorrect name of FI-test jar file (for 0.20 branch).
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Sreekanth Ramakrishnan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sreekanth Ramakrishnan updated HADOOP-6204:
-------------------------------------------
Attachment: hadoop-6204-ydist.patch
Attaching Yahoo! Distribution patch.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204.patch
Jacob's comments are addressed except this one:
bq. * The new target injectfaults doesn't follow the convention of separating words with a hyphen.
This target won't be called by anyone directly except a very few developers working on faults and aspects. Thus, the name reflects it by no following the convention for the rest of the target.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6204) Implementing aspects development
and fault injeciton framework for Hadoop
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763855#action_12763855 ]
Hadoop QA commented on HADOOP-6204:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12421703/HADOOP-6204.patch
against trunk revision 823355.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 20 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
-1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings).
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/76/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/76/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/76/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/76/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/76/console
This message is automatically generated.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6204) Implementing aspects development
and fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764378#action_12764378 ]
Konstantin Boudnik commented on HADOOP-6204:
--------------------------------------------
I can see same issue with {{TestDNS}} as has been previously mentioned by Jacob, however, the Hudson's test report doesn't show any failures in it.
So, looks like the patch is cool cause that supposed test failure isn't related to it.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204-ydist.patch
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204.patch
Updated version of the patch for 0.20: adds fault-injected tests to the main {{test}} target; fixes an additional empty line mod.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: (was: HADOOP-6204-ydist.patch)
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: (was: wrongTestsPackaging.patch)
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6204) Implementing aspects development
and fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752833#action_12752833 ]
Konstantin Boudnik commented on HADOOP-6204:
--------------------------------------------
Nicholas has raised the point if we need this modification in place by 0.21 release time.
There are two main reason why I was pushing this into Common right now:
- security tests: aspects framework will allow to test some AccessToken related functionality without permanent modifications of the production code. I'm not sure if this functionality will be included into 0.21 so I'd like to see any input on this
- MR needs aspect framework in place for handling load simulations (MAPREDUCE-728). If this work doesn't require a permanent aspects framework in place and can live with a temp. fix then we can postpone this JIRA's commit past 0.21 release.
Please comment.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204_0.20.patch
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, wrongTestsPackaging.patch
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: (was: HADOOP-6402-ydist.patch)
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-6204:
-------------------------------------------
Fix Version/s: 0.21.0
This was also committed to 0.21.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6204) Implementing aspects development
and fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828862#action_12828862 ]
Konstantin Boudnik commented on HADOOP-6204:
--------------------------------------------
Local run of test-patch for the latest version of 0.20 branch's patch
{noformat}
+1 overall.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
{noformat}
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6204) Implementing aspects development
and fault injeciton framework for Hadoop
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764849#action_12764849 ]
Jakob Homan commented on HADOOP-6204:
-------------------------------------
Patch review based on 10/12 patch:
Looks good overall with just a couple of things.
* Line 247: The TODO comment needs to be removed. The method seems appropriately sophisticated, but if it's to be improved that should be done either now or in a separate JIRA, but leaving the comment in the code won't work.
* Line 273: If may be useful to log if an invalid property has been specified in the config file.
* The new target injectfaults doesn't follow the convention of separating words with a hyphen.
Nits:
* Lines 132 and 151, what's the point of the empty space within the comments?
* Line 321-326, is it necessary to have init be a separate method rather than inlining into the static block from which it is called I'm not seeing the purpose of the separate method.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204_0.20.patch
Excluding AOP directories from test lookup process. Previous attempt to limit the lookup to {{${test.src.dir}}/org}} failed
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, wrongTestsPackaging.patch
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204.patch
Special {{run-fault-inject-with-testcaseonly}} target is added which allows to run normal test cases with instrumented code to reproduce possible regressions and such.
This version of the patch also is better formatted compare to the last one and easy for review.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204.patch
Now, {{src/test/aop}} is included into {{.eclipse.templates/.classpath}}
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: wrongTestsPackaging.patch
This patch in combination with latest [ydist_20|https://issues.apache.org/jira/secure/attachment/12431062/HADOOP-6204-ydist.patch] reflects [the patch for 0.20 branch|https://issues.apache.org/jira/secure/attachment/12431825/HADOOP-6204_0.20.patch]
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros, HADOOP-6204_0.20.patch, wrongTestsPackaging.patch
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204_0.20.patch
Latest patch for 0.20 branch.
The way {{junit}} task is configured is to look for _all_ tests under {{src/test}} directory. It will include and try to run tests in {{src/test/aop}} folder during execution of normal {{test-core}} target. Such attempt will clearly fail. This patch fixes this issue.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros, HADOOP-6204_0.20.patch
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204_0.20.patch
This patch includes the update for missing jar files in eclipse .classpath file.
The results of local test-patch verification are below:
{noformat}
+1 overall.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
{noformat}
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204-ydist.patch
Seems to be a final version for ydist fixing the invocation of call of non-existing target 'run-test-core'
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6204) Implementing aspects development
and fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764161#action_12764161 ]
Konstantin Boudnik commented on HADOOP-6204:
--------------------------------------------
- bq. Checked the raw log. Look like that TestDNS did not success.
Right, which doesn't look related to the patch. I'll re-run everything manually just to make sure.
- from Hudson's test results page:
{noformat}
Test Result 0 failures (±0)
585 tests (±0) Took 4 min 1 sec.
{noformat}
Which confirms that Hudson went nuts ;-)
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204_0.20.patch
And yet another issue is found :-(
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: (was: HADOOP-6204.patch)
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204.patch.withmacros
This is the solution with macros in place and without additional indirection level for target names
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204.patch
I've run all fault injection related targets, also have done an injection into the code and ran tests successfully.
{noformat}
There appear to be 0 release audit warnings before the patch and 0 release audit warnings after applying the patch.
+1 overall.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 19 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
======================================================================
======================================================================
Finished build.
{noformat}
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6204) Implementing aspects development
and fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763852#action_12763852 ]
Konstantin Boudnik commented on HADOOP-6204:
--------------------------------------------
I'm running test-patch and getting this
{noformat}
There appear to be 0 release audit warnings before the patch and 1 release audit warnings after applying the patch.
-1 overall.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 20 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
-1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings).
{noformat}
However, that warning looks totally weird for me:
{noformat}
[exec] Copying the various non-generated resources to site.
[exec] Warnings will be issued if the optional project resources are not found.
[exec] This is often the case, because they are optional and so may not be available.
[exec] Copying project resources and images to site ...
[exec] Warning: /Users/xxx/work/Common.test/src/docs/build/webapp/resources not found.
[exec] Copying main skin images to site ...
[exec] Copying 18 files to /Users/xxx/work/Common.test/src/docs/build/site/skin/images
[exec] Copying 14 files to /Users/xxx/work/Common.test/src/docs/build/site/skin/images
[exec] Copying project skin images to site ...
[exec] Warning: /Users/xxx/work/Common.test/src/docs/src/documentation/skins/common/images not found.
[exec] Warning: /Users/xxx/work/Common.test/src/docs/src/documentation/skins/pelt/images not found.
[exec] Copying main skin css and js files to site ...
[exec] Copying 11 files to /Users/xxx/work/Common.test/src/docs/build/site/skin
[exec] Copying 4 files to /Users/xxx/work/Common.test/src/docs/build/site/skin
[exec] Copying project skin css and js files to site ...
[exec] Warning: /Users/xxx/work/Common.test/src/docs/src/documentation/skins/common not found.
[exec] Warning: /Users/xxx/work/Common.test/src/docs/src/documentation/skins/pelt not found.
{noformat}
Apparently this patch has nothing to do with docs.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204.patch
This version represent pretty much final cut of the patch, which has only two minor issues. Namely, it fails to include fi-site.xml file into the -fi.jar file; and I need to find out why the {{package-info}} file is being put under normal {{build}} folder instead of {{build-fi}} one.
The rest seems to be working properly, although more testing is needed.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204_0.20.patch
This latest version of the patch includes a feature which has been missed from the original patch and has been later addressed by a separate JIRA (HDFS-584).
Simply put, a build has to be fail if some aspects are mis-bound.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6402-ydist.patch
Instead of tracking small fixes in the separate sub-tasks I've prepared this patch which correlates with branch-0.20 patch and will be committed to ydist.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6402-ydist.patch
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6204) Implementing aspects development
and fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744720#action_12744720 ]
Konstantin Boudnik commented on HADOOP-6204:
--------------------------------------------
To implement it the fault injection framework will have to be pulled from HDFS and include it into Common project. This can be eventually represented in a form of an auxiliary build file and ivy configuration, which could be used by other subprojects as SNV externals. A couple of framework classes would have to be migrated from HDFS to Common permanently.
As the result, Common will need to provide one more jar file with instrumented classes, i.e. {{hadoop-core-0.21.0-dev-fi.jar}}
Besides, it might be a good time to think of different name for this framework, because it is covering not only fault injection, but rather generic code instrumentation needs.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204-ydist.patch
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204.patch
Everything seems to be in order now. The patch also provides needed classes for probability model and config manipulations.
{{src/saveVersion.sh}} is fixed to generate {{package-info}} file under current build directory.
Review is needed so the MapReduce and Hdfs will be able to reuse this very framework.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Fix Version/s: 0.22.0
0.21.0
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204.patch.indirect
This is the solution with name resolutions (i.e. indirection layer)
Both are created on top of existing HDFS' FI framework and will be adopted for Common in the final version of the patch.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204.patch
All attributes of a macro have to be initialized at invocation. Fixed
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6204) Implementing aspects development
and fault injeciton framework for Hadoop
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765277#action_12765277 ]
Hudson commented on HADOOP-6204:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #61 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/61/])
. Implementing aspects development and fault injeciton framework for Hadoop. Contributed by Konstantin Boudnik
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204-ydist.patch
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6204) Implementing aspects development
and fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796980#action_12796980 ]
Konstantin Boudnik commented on HADOOP-6204:
--------------------------------------------
Clearly, the latest patch is for 0.20 source tree.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Status: Open (was: Patch Available)
As per Jacob's suggestions I'll split this patch in two: this one and HADOOP-6305. New patch to be posted shortly
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: HADOOP-6204-ydist.patch
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch, HADOOP-6204_0.20.patch
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Status: Patch Available (was: Open)
Resubmitting patch after it has been split between this and HADOOP-6305
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6204) Implementing aspects development
and fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748553#action_12748553 ]
Konstantin Boudnik commented on HADOOP-6204:
--------------------------------------------
In order to avoid some massive ANT code duplication, I have sketched a solution for this as follows:
- all FI logic is represented by a separate aop.xml file placed in build.aux folder
- that aop.xml file is imported into build.xml
- to make FI framework project independent I've renamed FI related targets to {{run-test-primary-fault-inject}}. {{run-test-secondary-fault-inject}}, {{jar-fault-inject}}, and {{jar-test-fault-inject}}
- project specific build.properties should contains actual target to be executed by aforementioned generic names.
Now, build.aux can be pulled from Common through svn:externals and then everything will be working in a very similar way. The above solution has 2 issues in my opinion:
- an indirection level is being added. One way to avoid the abstraction is to define a number of macros in the aop.xml file and parametrize them from build.xml. It might be better approach.
- svn:externals aren't universally acceptable. E.g. if one wants to pull SVN repository into a git one, then externals are have to be processed as a special case.
I'd appreciate if anyone has any comment or preferences on this.
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6204) Implementing aspects development and
fault injeciton framework for Hadoop
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HADOOP-6204:
---------------------------------------
Attachment: (was: HADOOP-6204-ydist.patch)
> Implementing aspects development and fault injeciton framework for Hadoop
> -------------------------------------------------------------------------
>
> Key: HADOOP-6204
> URL: https://issues.apache.org/jira/browse/HADOOP-6204
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.21.0, 0.22.0
>
> Attachments: HADOOP-6204-ydist.patch, HADOOP-6204-ydist.patch, hadoop-6204-ydist.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch, HADOOP-6204.patch.indirect, HADOOP-6204.patch.withmacros
>
>
> Fault injection framework implementation in HDFS (HDFS-435) turns out to be a very useful feature both for error handling testing and for various simulations.
> There's certain demand for this framework, thus it need to be pulled up from HDFS and brought into Common, so other sub-projects will be able to share it if needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.