[GitHub] [hbase] anoopsjohn commented on a change in pull request #2568: HBASE-25205 Corrupted hfiles append timestamp every time the region i…

[GitBox <gi...@apache.org>]

anoopsjohn commented on a change in pull request #2568:
URL: https://github.com/apache/hbase/pull/2568#discussion_r510029108



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -5324,22 +5328,25 @@ private long replayRecoveredEditsForPaths(long minSeqIdForTheRegion, FileSystem
   }
 
   private void handleException(FileSystem fs, Path edits, IOException e) throws IOException {
-    boolean skipErrors = conf.getBoolean(HConstants.HREGION_EDITS_REPLAY_SKIP_ERRORS,
-      conf.getBoolean("hbase.skip.errors", HConstants.DEFAULT_HREGION_EDITS_REPLAY_SKIP_ERRORS));
-    if (conf.get("hbase.skip.errors") != null) {
-      LOG.warn("The property 'hbase.skip.errors' has been deprecated. Please use "
-          + HConstants.HREGION_EDITS_REPLAY_SKIP_ERRORS + " instead.");
-    }
-    if (skipErrors) {
+    if (isSkipErrorEnabled()) {

Review comment:
       By default this skip error config is false.  So similar case of WAL split to hfiles, we will have partial Hfiles from initial split and loading of that will fail always right?  (loadRecoveredHFilesIfAny ())
   cc @infraio 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org