You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2024/06/05 01:23:19 UTC
[PR] [SPARK-48532][BUILD] Upgrade maven plugin to latest version [spark]
panbingkun opened a new pull request, #46870:
URL: https://github.com/apache/spark/pull/46870
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48532][BUILD] Upgrade maven plugin to latest version [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #46870:
URL: https://github.com/apache/spark/pull/46870#issuecomment-2159935600
> > maven-javadoc-plugin
>
> Can we check if the Scaladoc/Javadoc generation work fine? IIRC, genjavadoc is pretty old, and we should see if that's compatible with javadoc plugin upgrade
@HyukjinKwon
The compatibility between plugin `genJavadoc ` and `the latest version(3.7.0) of javadoc` has been verified above, and no issues have been found, I have added the `verification steps` to the `description` of PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48532][BUILD] Upgrade maven plugin to latest version [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46870:
URL: https://github.com/apache/spark/pull/46870#issuecomment-2564114599
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48532][BUILD] Upgrade maven plugin to latest version [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #46870:
URL: https://github.com/apache/spark/pull/46870#issuecomment-2153634670
> maven-javadoc-plugin
Can we check if the Scaladoc/Javadoc generation work fine? IIRC, genjavadoc is pretty old, and we should see if that's compatible with javadoc plugin upgrade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48532][BUILD] Upgrade maven plugin to latest version [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #46870:
URL: https://github.com/apache/spark/pull/46870#issuecomment-2149581508
cc @LuciferYang @dongjoon-hyun @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48532][BUILD] Upgrade maven plugin to latest version [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #46870:
URL: https://github.com/apache/spark/pull/46870#issuecomment-2160087269
> hmm... IIRC, https://github.com/panbingkun/spark/actions/runs/9458329785/artifacts/1587905559 is generated by `sbt unidoc`, it should not have used `maven-javadoc-plugin`
Yes, that's right. I tested a PR that completely removed `javadoc`, and `GA` seems to be okay. I `guess` one possible implicit use of this plugin is:
https://repo1.maven.org/maven2/org/apache/spark/spark-core_2.13/4.0.0-preview1/
<img width="608" alt="image" src="https://github.com/apache/spark/assets/15246973/4670c0cc-6ba6-46d8-a7fc-3734b9919f8a">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48532][BUILD] Upgrade maven plugin to latest version [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #46870:
URL: https://github.com/apache/spark/pull/46870#issuecomment-2347439286
Gentle ping. What is the current status of this PR, @panbingkun ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48532][BUILD] Upgrade maven plugin to latest version [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #46870:
URL: https://github.com/apache/spark/pull/46870#issuecomment-2348477145
> Gentle ping. What is the current status of this PR, @panbingkun ?
I will update in the next few days. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48532][BUILD] Upgrade maven plugin to latest version [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #46870:
URL: https://github.com/apache/spark/pull/46870#issuecomment-2159623149
Javadoc - 3.6.3:
Javadoc - 3.7.0:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48532][BUILD] Upgrade maven plugin to latest version [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #46870:
URL: https://github.com/apache/spark/pull/46870#issuecomment-2159940708
> Without this PR, I tried to run `mvn javadoc:javadoc` and `mvn javadoc:jar` on `master/branch-3.5/branch-3.4`, and they both failed. I think we can initiate the upgrade of `maven-javadoc-plugin` after fixing them @panbingkun
@LuciferYang
Because we have a mixed code structure of `Java` and `Scala`, we generate Java and Scala documents through the plugin `genJavadoc `. For this reason, our execution of `mvn ... javadoc:javadoc` or `javadoc:jar` in the current configuration should not be successful unless we adjust the configuration, as follows: https://github.com/lightbend/genjavadoc
<img width="696" alt="image" src="https://github.com/apache/spark/assets/15246973/3dde3a07-ebd3-4599-8b55-7d46efec5e63">
<img width="592" alt="image" src="https://github.com/apache/spark/assets/15246973/74b0148f-791e-4c44-8a15-dc8c9f9a9019">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48532][BUILD] Upgrade maven plugin to latest version [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #46870: [SPARK-48532][BUILD] Upgrade maven plugin to latest version
URL: https://github.com/apache/spark/pull/46870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48532][BUILD] Upgrade maven plugin to latest version [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #46870:
URL: https://github.com/apache/spark/pull/46870#issuecomment-2349186887
No hurry, @panbingkun . I just want to know the status. We can do this later after Apache Spark 4.0.0-preview2 also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48532][BUILD] Upgrade maven plugin to latest version [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #46870:
URL: https://github.com/apache/spark/pull/46870#issuecomment-2160062330
hmm... IIRC, https://github.com/panbingkun/spark/actions/runs/9458329785/artifacts/1587905559 is generated by `sbt unidoc`, it should not have used `maven-javadoc-plugin`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48532][BUILD] Upgrade maven plugin to latest version [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #46870:
URL: https://github.com/apache/spark/pull/46870#issuecomment-2160133226
> > hmm... IIRC, https://github.com/panbingkun/spark/actions/runs/9458329785/artifacts/1587905559 is generated by `sbt unidoc`, it should not have used `maven-javadoc-plugin`
>
> Yes, that's right. I tested a PR (#46922) that completely removed `javadoc`, and `GA` seems to be okay. I `guess` one possible implicit use of this plugin is: https://repo1.maven.org/maven2/org/apache/spark/spark-core_2.13/4.0.0-preview1/ <img alt="image" width="608" src="https://private-user-images.githubusercontent.com/15246973/338496865-4670c0cc-6ba6-46d8-a7fc-3734b9919f8a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgwOTQ5OTQsIm5iZiI6MTcxODA5NDY5NCwicGF0aCI6Ii8xNTI0Njk3My8zMzg0OTY4NjUtNDY3MGMwY2MtNmJhNi00NmQ4LWE3ZmMtMzczNGI5OTE5ZjhhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjExVDA4MzEzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg3NGJhZmM2YzQzMDgxNDEwNjJkZmZmZmYzNzRmNzY1ZmVmNDk2ODdlNjExNzg5NzUwODFhODVmYzJjOGM3NDgmWC1BbXotU2lnbmVkSGVhZ
GVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.UKLqmxDhWE4HC4RG0GjVqtjLzUEW-gQSz5SYMV1PYIw">
```
[INFO] --- scala:4.9.1:doc-jar (attach-scaladocs) @ spark-common-utils_2.13 ---
/Users/yangjie01/SourceCode/git/spark-mine-13/common/utils/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryException.scala:25: warning: Could not find any member to link for "StreamingQuery".
Applicable -Wconf / @nowarn filters for this warning: msg=<part of the message>, cat=scaladoc, site=org.apache.spark.sql.streaming.StreamingQueryException
/**
^
/Users/yangjie01/SourceCode/git/spark-mine-13/common/utils/src/main/java/org/apache/spark/SparkThrowable.java:25: warning: Could not find any member to link for "SparkArithmeticException".
Applicable -Wconf / @nowarn filters for this warning: msg=<part of the message>, cat=scaladoc, site=org.apache.spark.SparkThrowable
/**
^
2 warnings
[INFO] Building jar: /Users/yangjie01/SourceCode/git/spark-mine-13/common/utils/target/spark-common-utils_2.13-4.0.0-SNAPSHOT-javadoc.jar
[INFO]
```
In fact, it should be generated by `scala-maven-plugin` ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48532][BUILD] Upgrade maven plugin to latest version [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #46870:
URL: https://github.com/apache/spark/pull/46870#issuecomment-2153896911
Without this PR, I tried to run `mvn javadoc:javadoc` and `mvn javadoc:jar` on `master/branch-3.5/branch-3.4`, and they both failed. I think we can initiate the upgrade of `maven-javadoc-plugin` after fixing them @panbingkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org