You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/10 12:38:56 UTC

[GitHub] [shardingsphere] DemonLms opened a new pull request #5985: fix(encrypt): Fixed issues#5979

DemonLms opened a new pull request #5985:
URL: https://github.com/apache/shardingsphere/pull/5985


   Fixed data encryption can not properly processing SQL mixed with `?` and literal.
   
   Closes #5979
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] DemonLms commented on pull request #5985: fix(encrypt): Fixed issues#5979

Posted by GitBox <gi...@apache.org>.

DemonLms commented on pull request #5985:
URL: https://github.com/apache/shardingsphere/pull/5985#issuecomment-643884693


   @tristaZero I have update the method implementation of `getParameterIndex`  using an existing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #5985: fix(encrypt): Fixed issues#5979

Posted by GitBox <gi...@apache.org>.

tristaZero commented on pull request #5985:
URL: https://github.com/apache/shardingsphere/pull/5985#issuecomment-645115307


   @DemonLms Hi, Congratulations on your first one to Apache ShardingSphere community!
   It is great PR, which helps users have better usage of Encryption feature.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #5985: fix(encrypt): Fixed issues#5979

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #5985:
URL: https://github.com/apache/shardingsphere/pull/5985#issuecomment-643272050


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=h1) Report
   > Merging [#5985](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b6a858ce5dfc1b41757f6ee3f4a4b7995bc0f689&el=desc) will **increase** coverage by `0.15%`.
   > The diff coverage is `73.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5985/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5985      +/-   ##
   ============================================
   + Coverage     52.95%   53.10%   +0.15%     
   + Complexity      439      438       -1     
   ============================================
     Files          1195     1189       -6     
     Lines         20987    20977      -10     
     Branches       3778     3777       -1     
   ============================================
   + Hits          11113    11140      +27     
   + Misses         9177     9137      -40     
   - Partials        697      700       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...nder/segment/insert/values/InsertValueContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvc2VnbWVudC9pbnNlcnQvdmFsdWVzL0luc2VydFZhbHVlQ29udGV4dC5qYXZh) | `83.87% <0.00%> (-5.79%)` | `0.00 <0.00> (ø)` | |
   | [...erator/impl/EncryptInsertValuesTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0SW5zZXJ0VmFsdWVzVG9rZW5HZW5lcmF0b3IuamF2YQ==) | `80.00% <75.00%> (+3.28%)` | `1.00 <0.00> (ø)` | |
   | [...eter/impl/EncryptInsertValueParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS9wYXJhbWV0ZXIvaW1wbC9FbmNyeXB0SW5zZXJ0VmFsdWVQYXJhbWV0ZXJSZXdyaXRlci5qYXZh) | `90.24% <88.88%> (+0.77%)` | `0.00 <0.00> (ø)` | |
   | [...e/cluster/heartbeat/task/HeartbeatTaskManager.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC90YXNrL0hlYXJ0YmVhdFRhc2tNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-30.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...ransaction/ShardingTransactionTypeInterceptor.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLXRyYW5zYWN0aW9uLXNwcmluZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3ByaW5nL3RyYW5zYWN0aW9uL1NoYXJkaW5nVHJhbnNhY3Rpb25UeXBlSW50ZXJjZXB0b3IuamF2YQ==) | `88.23% <0.00%> (-11.77%)` | `1.00% <0.00%> (ø%)` | |
   | [...re/cluster/heartbeat/ClusterHeartbeatInstance.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9DbHVzdGVySGVhcnRiZWF0SW5zdGFuY2UuamF2YQ==) | `33.33% <0.00%> (-8.34%)` | `0.00% <0.00%> (ø%)` | |
   | [.../orchestration/core/configcenter/ConfigCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtY29uZmlnY2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvY29uZmlnY2VudGVyL0NvbmZpZ0NlbnRlci5qYXZh) | `81.17% <0.00%> (-5.50%)` | `0.00% <0.00%> (ø%)` | |
   | [...ere/cluster/heartbeat/detect/HeartbeatHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9kZXRlY3QvSGVhcnRiZWF0SGFuZGxlci5qYXZh) | `71.87% <0.00%> (-4.80%)` | `0.00% <0.00%> (ø%)` | |
   | [...ommand/query/text/MySQLTextResultSetRowPacket.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9jb21tYW5kL3F1ZXJ5L3RleHQvTXlTUUxUZXh0UmVzdWx0U2V0Um93UGFja2V0LmphdmE=) | `80.95% <0.00%> (-4.77%)` | `0.00% <0.00%> (ø%)` | |
   | [...ation/core/facade/ShardingOrchestrationFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtZmFjYWRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvZmFjYWRlL1NoYXJkaW5nT3JjaGVzdHJhdGlvbkZhY2FkZS5qYXZh) | `91.37% <0.00%> (-3.07%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [104 more](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=footer). Last update [b6a858c...788a3a8](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #5985: fix(encrypt): Fixed issues#5979

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #5985:
URL: https://github.com/apache/shardingsphere/pull/5985#issuecomment-643272050


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=h1) Report
   > Merging [#5985](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b6a858ce5dfc1b41757f6ee3f4a4b7995bc0f689&el=desc) will **increase** coverage by `0.06%`.
   > The diff coverage is `91.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5985/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5985      +/-   ##
   ============================================
   + Coverage     52.95%   53.01%   +0.06%     
     Complexity      439      439              
   ============================================
     Files          1195     1195              
     Lines         20987    21017      +30     
     Branches       3778     3787       +9     
   ============================================
   + Hits          11113    11143      +30     
   - Misses         9177     9178       +1     
   + Partials        697      696       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...eter/impl/EncryptInsertValueParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS9wYXJhbWV0ZXIvaW1wbC9FbmNyeXB0SW5zZXJ0VmFsdWVQYXJhbWV0ZXJSZXdyaXRlci5qYXZh) | `91.17% <91.66%> (+1.70%)` | `0.00 <0.00> (ø)` | |
   | [...erator/impl/EncryptInsertValuesTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0SW5zZXJ0VmFsdWVzVG9rZW5HZW5lcmF0b3IuamF2YQ==) | `78.08% <0.00%> (+1.36%)` | `1.00% <0.00%> (ø%)` | |
   | [...meter/impl/EncryptAssignmentParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS9wYXJhbWV0ZXIvaW1wbC9FbmNyeXB0QXNzaWdubWVudFBhcmFtZXRlclJld3JpdGVyLmphdmE=) | `100.00% <0.00%> (+3.03%)` | `1.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=footer). Last update [b6a858c...2d964b5](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] DemonLms commented on pull request #5985: fix(encrypt): Fixed issues#5979

Posted by GitBox <gi...@apache.org>.

DemonLms commented on pull request #5985:
URL: https://github.com/apache/shardingsphere/pull/5985#issuecomment-642853019






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #5985: fix(encrypt): Fixed issues#5979

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #5985:
URL: https://github.com/apache/shardingsphere/pull/5985#issuecomment-643272050


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=h1) Report
   > Merging [#5985](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b6a858ce5dfc1b41757f6ee3f4a4b7995bc0f689&el=desc) will **increase** coverage by `0.15%`.
   > The diff coverage is `73.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5985/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5985      +/-   ##
   ============================================
   + Coverage     52.95%   53.10%   +0.15%     
   + Complexity      439      438       -1     
   ============================================
     Files          1195     1189       -6     
     Lines         20987    20977      -10     
     Branches       3778     3777       -1     
   ============================================
   + Hits          11113    11140      +27     
   + Misses         9177     9138      -39     
   - Partials        697      699       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...nder/segment/insert/values/InsertValueContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvc2VnbWVudC9pbnNlcnQvdmFsdWVzL0luc2VydFZhbHVlQ29udGV4dC5qYXZh) | `83.87% <0.00%> (-5.79%)` | `0.00 <0.00> (ø)` | |
   | [...erator/impl/EncryptInsertValuesTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0SW5zZXJ0VmFsdWVzVG9rZW5HZW5lcmF0b3IuamF2YQ==) | `78.66% <75.00%> (+1.95%)` | `1.00 <0.00> (ø)` | |
   | [...eter/impl/EncryptInsertValueParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS9wYXJhbWV0ZXIvaW1wbC9FbmNyeXB0SW5zZXJ0VmFsdWVQYXJhbWV0ZXJSZXdyaXRlci5qYXZh) | `90.24% <88.88%> (+0.77%)` | `0.00 <0.00> (ø)` | |
   | [...e/cluster/heartbeat/task/HeartbeatTaskManager.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC90YXNrL0hlYXJ0YmVhdFRhc2tNYW5hZ2VyLmphdmE=) | `70.00% <0.00%> (-30.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...ransaction/ShardingTransactionTypeInterceptor.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLXRyYW5zYWN0aW9uLXNwcmluZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3ByaW5nL3RyYW5zYWN0aW9uL1NoYXJkaW5nVHJhbnNhY3Rpb25UeXBlSW50ZXJjZXB0b3IuamF2YQ==) | `88.23% <0.00%> (-11.77%)` | `1.00% <0.00%> (ø%)` | |
   | [...re/cluster/heartbeat/ClusterHeartbeatInstance.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9DbHVzdGVySGVhcnRiZWF0SW5zdGFuY2UuamF2YQ==) | `33.33% <0.00%> (-8.34%)` | `0.00% <0.00%> (ø%)` | |
   | [.../orchestration/core/configcenter/ConfigCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtY29uZmlnY2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvY29uZmlnY2VudGVyL0NvbmZpZ0NlbnRlci5qYXZh) | `81.17% <0.00%> (-5.50%)` | `0.00% <0.00%> (ø%)` | |
   | [...ere/cluster/heartbeat/detect/HeartbeatHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1jbHVzdGVyL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItaGVhcnRiZWF0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9jbHVzdGVyL2hlYXJ0YmVhdC9kZXRlY3QvSGVhcnRiZWF0SGFuZGxlci5qYXZh) | `71.87% <0.00%> (-4.80%)` | `0.00% <0.00%> (ø%)` | |
   | [...ation/core/facade/ShardingOrchestrationFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtZmFjYWRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvZmFjYWRlL1NoYXJkaW5nT3JjaGVzdHJhdGlvbkZhY2FkZS5qYXZh) | `91.37% <0.00%> (-3.07%)` | `0.00% <0.00%> (ø%)` | |
   | [...ere/proxy/frontend/executor/UserExecutorGroup.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvZXhlY3V0b3IvVXNlckV4ZWN1dG9yR3JvdXAuamF2YQ==) | `77.77% <0.00%> (-2.23%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [103 more](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=footer). Last update [b6a858c...3081b50](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #5985: fix(encrypt): Fixed issues#5979

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #5985:
URL: https://github.com/apache/shardingsphere/pull/5985#issuecomment-643272050


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=h1) Report
   > Merging [#5985](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b6a858ce5dfc1b41757f6ee3f4a4b7995bc0f689&el=desc) will **increase** coverage by `0.22%`.
   > The diff coverage is `92.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5985/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5985      +/-   ##
   ============================================
   + Coverage     52.95%   53.17%   +0.22%     
   + Complexity      439      438       -1     
   ============================================
     Files          1195     1188       -7     
     Lines         20987    20947      -40     
     Branches       3778     3774       -4     
   ============================================
   + Hits          11113    11138      +25     
   + Misses         9177     9113      -64     
   + Partials        697      696       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...nder/segment/insert/values/InsertValueContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvc2VnbWVudC9pbnNlcnQvdmFsdWVzL0luc2VydFZhbHVlQ29udGV4dC5qYXZh) | `83.87% <0.00%> (-5.79%)` | `0.00 <0.00> (ø)` | |
   | [...eter/impl/EncryptInsertValueParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS9wYXJhbWV0ZXIvaW1wbC9FbmNyeXB0SW5zZXJ0VmFsdWVQYXJhbWV0ZXJSZXdyaXRlci5qYXZh) | `94.54% <100.00%> (+5.07%)` | `0.00 <0.00> (ø)` | |
   | [.../orchestration/core/configcenter/ConfigCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY29yZS9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uLWNvcmUtY29uZmlnY2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvY29uZmlnY2VudGVyL0NvbmZpZ0NlbnRlci5qYXZh) | `82.50% <0.00%> (-4.17%)` | `0.00% <0.00%> (ø%)` | |
   | [...ere/proxy/frontend/executor/UserExecutorGroup.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvZXhlY3V0b3IvVXNlckV4ZWN1dG9yR3JvdXAuamF2YQ==) | `77.77% <0.00%> (-2.23%)` | `0.00% <0.00%> (ø%)` | |
   | [...ithm/sharding/CustomDateTimeShardingAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9zdHJhdGVneS9hbGdvcml0aG0vc2hhcmRpbmcvQ3VzdG9tRGF0ZVRpbWVTaGFyZGluZ0FsZ29yaXRobS5qYXZh) | `74.46% <0.00%> (-1.54%)` | `0.00% <0.00%> (ø%)` | |
   | [...ava/org/apache/shardingsphere/proxy/Bootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9Cb290c3RyYXAuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...sql/parser/binder/metadata/MetaDataConnection.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvbWV0YWRhdGEvTWV0YURhdGFDb25uZWN0aW9uLmphdmE=) | `13.33% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...gsphere/encrypt/algorithm/AESEncryptAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9hbGdvcml0aG0vQUVTRW5jcnlwdEFsZ29yaXRobS5qYXZh) | `80.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...gsphere/encrypt/algorithm/MD5EncryptAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9hbGdvcml0aG0vTUQ1RW5jcnlwdEFsZ29yaXRobS5qYXZh) | `62.50% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...gsphere/encrypt/algorithm/RC4EncryptAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9hbGdvcml0aG0vUkM0RW5jcnlwdEFsZ29yaXRobS5qYXZh) | `94.23% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | ... and [86 more](https://codecov.io/gh/apache/shardingsphere/pull/5985/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=footer). Last update [b6a858c...72bb4cf](https://codecov.io/gh/apache/shardingsphere/pull/5985?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] DemonLms commented on a change in pull request #5985: fix(encrypt): Fixed issues#5979

Posted by GitBox <gi...@apache.org>.

DemonLms commented on a change in pull request #5985:
URL: https://github.com/apache/shardingsphere/pull/5985#discussion_r440787041



##########
File path: shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/impl/EncryptInsertValuesTokenGenerator.java
##########
@@ -133,7 +133,8 @@ private void encryptToken(final InsertValue insertValueToken, final String table
     private void addPlainColumn(final InsertValue insertValueToken, final int columnIndex,
                                 final String tableName, final String columnName, final InsertValueContext insertValueContext, final Object originalValue) {
         if (getEncryptRule().findPlainColumn(tableName, columnName).isPresent()) {
-            DerivedSimpleExpressionSegment derivedExpressionSegment = insertValueContext.getParameters().isEmpty()
+            DerivedSimpleExpressionSegment derivedExpressionSegment = (insertValueContext.getParameters().isEmpty()
+                    || insertValueContext.getValueExpressions().get(columnIndex) instanceof LiteralExpressionSegment)

Review comment:
       Done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] DemonLms commented on pull request #5985: fix(encrypt): Fixed issues#5979

Posted by GitBox <gi...@apache.org>.

DemonLms commented on pull request #5985:
URL: https://github.com/apache/shardingsphere/pull/5985#issuecomment-642853019


   I apologize for my low-level BUG and irresponsible attitude, and I am reworking with this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #5985: fix(encrypt): Fixed issues#5979

Posted by GitBox <gi...@apache.org>.

tristaZero commented on a change in pull request #5985:
URL: https://github.com/apache/shardingsphere/pull/5985#discussion_r440770837



##########
File path: shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/impl/EncryptInsertValuesTokenGenerator.java
##########
@@ -133,7 +133,8 @@ private void encryptToken(final InsertValue insertValueToken, final String table
     private void addPlainColumn(final InsertValue insertValueToken, final int columnIndex,
                                 final String tableName, final String columnName, final InsertValueContext insertValueContext, final Object originalValue) {
         if (getEncryptRule().findPlainColumn(tableName, columnName).isPresent()) {
-            DerivedSimpleExpressionSegment derivedExpressionSegment = insertValueContext.getParameters().isEmpty()
+            DerivedSimpleExpressionSegment derivedExpressionSegment = (insertValueContext.getParameters().isEmpty()
+                    || insertValueContext.getValueExpressions().get(columnIndex) instanceof LiteralExpressionSegment)

Review comment:
       Hi, These codes appear twice, do you think it is better to exact a function for them?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] DemonLms commented on pull request #5985: fix(encrypt): Fixed issues#5979

Posted by GitBox <gi...@apache.org>.

DemonLms commented on pull request #5985:
URL: https://github.com/apache/shardingsphere/pull/5985#issuecomment-643257957


   @tristaZero I seriously rewrite this PR and supplement some test cases. Please review again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #5985: fix(encrypt): Fixed issues#5979

Posted by GitBox <gi...@apache.org>.

tristaZero merged pull request #5985:
URL: https://github.com/apache/shardingsphere/pull/5985


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #5985: fix(encrypt): Fixed issues#5979

Posted by GitBox <gi...@apache.org>.

tristaZero commented on pull request #5985:
URL: https://github.com/apache/shardingsphere/pull/5985#issuecomment-642515513


   @DemonLms I am glad to see you start to involve in this community. Welcome!
   It seems more efficient to have a talk about your PR to solve the related issue. So if it does not bother you, can we exchange WeChat number? Since I can not get your email, is it convenient for you to send your WeChat number to `panjuan@apache.org`? 
   Looking forward to your response. :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org