You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Eric Bresie <eb...@gmail.com> on 2022/08/07 12:27:42 UTC
Netbeans Gradle buildSrc Removal for openjfx
Hey guys, I was reading mailing list/pr discussion for an openjfx change relating to some cleanup of eclipse build configuration recently and noted the following comment about possible dropping some Netbeans configuration at the same time. Anyone on the list know if this could cause a problem for Netbeans?
https://github.com/openjdk/jfx/pull/858#discussion_r934850607
Eric Bresie
Ebresie@gmail.com (mailto:Ebresie@gmail.com)
>
> Begin forwarded message:
>
>
> From: Nir Lisker <nlisker@openjdk.org (mailto:nlisker@openjdk.org)>
>
>
> Date: August 5, 2022 at 9:37:18 PM CDT
>
>
> To: openjfx-dev@openjdk.org (mailto:openjfx-dev@openjdk.org)
>
>
> Subject: Re: RFR: 8290473 (tel:8290473): update Eclipse .classpath in apps, buildSrc [v2]
>
>
> On Mon, 1 Aug 2022 19:34:11 GMT, Andy Goryachev <angorya@openjdk.org (mailto:angorya@openjdk.org)> wrote:
>
> > > buildSrc/.classpath line 10:
> > >
> > > > 8: <classpathentry kind="lib" exported="true" path="../build/libs/antlr-runtime-3.1.3.jar"/>
> > > > 9: <classpathentry kind="lib" exported="true" path="../build/libs/stringtemplate-3.2.jar"/>
> > > > 10: <classpathentry kind="lib" exported="true" path="../build/libs/swt-debug.jar"/>
> > >
> > > Why does buildSrc need to be a project? It contains no relevant sources.
> >
> > It probably does not, the file was added in 2013 as a part of
> > RT-31216: Ensure NetBeans development in Gradle build works [Eclipse files]
> >
> > Turns out, eclipse can work with nested projects. Shows multiple hits when looking for resources, but it does.
> >
> > I've added a separate project for ColorCube app as an example, but since this PR is about making all directories to build on Eclipse, I'd rather not fix all the apps in this PR. (I would keep ColorCube as a reference though).
>
> Then best to remove the `buildSrc` project files.
>
> I will look at the apps later. I think it's best to create a project per app while we are touching this point. I don't see a reason not to.
>
> -------------
>
> PR: https://git.openjdk.org/jfx/pull/858
Re: Netbeans Gradle buildSrc Removal for openjfx
Posted by Eric Bresie <eb...@gmail.com>.
I believe they had Eclipse project preferences to enable/disable warnings
in the IDE to help build openjfx project.
I could be wrong and hopefully didn’t misread the thread but it sounded
like they were potentially going to remove Netbeans build files within the
openjfx codebase, Assume that nb-project folders might go away as part of
these proposed changes.
But as you say, assume Gradle will handle most of the build part of it
and/or can always import into NetBeans as a new project with existing code,
so maybe not having that isn’t the end of the world and I’m worry over
nothing.
Eric Bresie
On Sun, Aug 7, 2022 at 12:19 PM Laszlo Kishalmi <la...@gmail.com>
wrote:
> Hi Eric!
>
> Do not worry, NetBeans Gradle projects do not need anything else than
> already required for Gradle.
>
> Just checked. Open JFX builds and loads reasonably well in NetBeans (We
> have a few occasional NPE-s when nb-javac parses the generated code). I
> think it can be used for development.
>
> Also checked a few demo and test projects still have their nb-project
> directory. That's used by the JavaFX Ant based NetBeans projects.
>
> On 8/7/22 05:27, Eric Bresie wrote:
> > Hey guys, I was reading mailing list/pr discussion for an openjfx change
> relating to some cleanup of eclipse build configuration recently and noted
> the following comment about possible dropping some Netbeans configuration
> at the same time. Anyone on the list know if this could cause a problem for
> Netbeans?
> >
> > https://github.com/openjdk/jfx/pull/858#discussion_r934850607
> >
> > Eric Bresie
> > Ebresie@gmail.com (mailto:Ebresie@gmail.com)
> >
> >> Begin forwarded message:
> >>
> >>
> >> From: Nir Lisker <nlisker@openjdk.org (mailto:nlisker@openjdk.org)>
> >>
> >>
> >> Date: August 5, 2022 at 9:37:18 PM CDT
> >>
> >>
> >> To: openjfx-dev@openjdk.org (mailto:openjfx-dev@openjdk.org)
> >>
> >>
> >> Subject: Re: RFR: 8290473 (tel:8290473): update Eclipse .classpath in
> apps, buildSrc [v2]
> >>
> >>
> >> On Mon, 1 Aug 2022 19:34:11 GMT, Andy Goryachev <angorya@openjdk.org
> (mailto:angorya@openjdk.org)> wrote:
> >>
> >>>> buildSrc/.classpath line 10:
> >>>>
> >>>>> 8: <classpathentry kind="lib" exported="true"
> path="../build/libs/antlr-runtime-3.1.3.jar"/>
> >>>>> 9: <classpathentry kind="lib" exported="true"
> path="../build/libs/stringtemplate-3.2.jar"/>
> >>>>> 10: <classpathentry kind="lib" exported="true"
> path="../build/libs/swt-debug.jar"/>
> >>>> Why does buildSrc need to be a project? It contains no relevant
> sources.
> >>> It probably does not, the file was added in 2013 as a part of
> >>> RT-31216: Ensure NetBeans development in Gradle build works [Eclipse
> files]
> >>>
> >>> Turns out, eclipse can work with nested projects. Shows multiple hits
> when looking for resources, but it does.
> >>>
> >>> I've added a separate project for ColorCube app as an example, but
> since this PR is about making all directories to build on Eclipse, I'd
> rather not fix all the apps in this PR. (I would keep ColorCube as a
> reference though).
> >> Then best to remove the `buildSrc` project files.
> >>
> >> I will look at the apps later. I think it's best to create a project
> per app while we are touching this point. I don't see a reason not to.
> >>
> >> -------------
> >>
> >> PR: https://git.openjdk.org/jfx/pull/858
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
> --
Eric Bresie
ebresie@gmail.com
Re: Netbeans Gradle buildSrc Removal for openjfx
Posted by Laszlo Kishalmi <la...@gmail.com>.
Hi Eric!
Do not worry, NetBeans Gradle projects do not need anything else than
already required for Gradle.
Just checked. Open JFX builds and loads reasonably well in NetBeans (We
have a few occasional NPE-s when nb-javac parses the generated code). I
think it can be used for development.
Also checked a few demo and test projects still have their nb-project
directory. That's used by the JavaFX Ant based NetBeans projects.
On 8/7/22 05:27, Eric Bresie wrote:
> Hey guys, I was reading mailing list/pr discussion for an openjfx change relating to some cleanup of eclipse build configuration recently and noted the following comment about possible dropping some Netbeans configuration at the same time. Anyone on the list know if this could cause a problem for Netbeans?
>
> https://github.com/openjdk/jfx/pull/858#discussion_r934850607
>
> Eric Bresie
> Ebresie@gmail.com (mailto:Ebresie@gmail.com)
>
>> Begin forwarded message:
>>
>>
>> From: Nir Lisker <nlisker@openjdk.org (mailto:nlisker@openjdk.org)>
>>
>>
>> Date: August 5, 2022 at 9:37:18 PM CDT
>>
>>
>> To: openjfx-dev@openjdk.org (mailto:openjfx-dev@openjdk.org)
>>
>>
>> Subject: Re: RFR: 8290473 (tel:8290473): update Eclipse .classpath in apps, buildSrc [v2]
>>
>>
>> On Mon, 1 Aug 2022 19:34:11 GMT, Andy Goryachev <angorya@openjdk.org (mailto:angorya@openjdk.org)> wrote:
>>
>>>> buildSrc/.classpath line 10:
>>>>
>>>>> 8: <classpathentry kind="lib" exported="true" path="../build/libs/antlr-runtime-3.1.3.jar"/>
>>>>> 9: <classpathentry kind="lib" exported="true" path="../build/libs/stringtemplate-3.2.jar"/>
>>>>> 10: <classpathentry kind="lib" exported="true" path="../build/libs/swt-debug.jar"/>
>>>> Why does buildSrc need to be a project? It contains no relevant sources.
>>> It probably does not, the file was added in 2013 as a part of
>>> RT-31216: Ensure NetBeans development in Gradle build works [Eclipse files]
>>>
>>> Turns out, eclipse can work with nested projects. Shows multiple hits when looking for resources, but it does.
>>>
>>> I've added a separate project for ColorCube app as an example, but since this PR is about making all directories to build on Eclipse, I'd rather not fix all the apps in this PR. (I would keep ColorCube as a reference though).
>> Then best to remove the `buildSrc` project files.
>>
>> I will look at the apps later. I think it's best to create a project per app while we are touching this point. I don't see a reason not to.
>>
>> -------------
>>
>> PR: https://git.openjdk.org/jfx/pull/858
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists