You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/01/15 18:18:05 UTC
[GitHub] [incubator-eventmesh] fmvilas opened a new issue #716: [Doc] Documentation Related
fmvilas opened a new issue #716:
URL: https://github.com/apache/incubator-eventmesh/issues/716
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Documentation Related
There seem to be a few typos in [this document](https://github.com/apache/incubator-eventmesh/blob/master/docs/en/features/eventmesh-workflow-design.md) regarding AsyncAPI.
If I'm understanding it correctly, you want to define the microservices using AsyncAPI. If that's the case, then `subscribe` and `publish` verbs must be exchanged in the following 4 places:
- https://github.com/apache/incubator-eventmesh/blob/master/docs/en/features/eventmesh-workflow-design.md?plain=1#L62
- https://github.com/apache/incubator-eventmesh/blob/master/docs/en/features/eventmesh-workflow-design.md?plain=1#L77
- https://github.com/apache/incubator-eventmesh/blob/master/docs/en/features/eventmesh-workflow-design.md?plain=1#L97
- https://github.com/apache/incubator-eventmesh/blob/master/docs/en/features/eventmesh-workflow-design.md?plain=1#L117
I know it can be confusing at first (and still is for me! 😅) but AsyncAPI operation verbs (publish and subscribe) represent operations the described application **accepts** instead of the operations it performs. So, for instance, when you say "publish" it means others can publish to this microservice (therefore the microservice should subscribe).
Here's a good article explaining the meaning: https://www.asyncapi.com/blog/publish-subscribe-semantics
Needless to say, we're working on changing this for version 3 of the spec which we want to release this year. Here you can track progress regarding this publish/subscribe meaning: https://github.com/asyncapi/spec/issues/520.
Happy to submit a PR :)
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] fmvilas closed issue #716: [Doc] AsyncAPI: publish and subcribe confusion?
Posted by GitBox <gi...@apache.org>.
fmvilas closed issue #716:
URL: https://github.com/apache/incubator-eventmesh/issues/716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] fmvilas commented on issue #716: [Doc] AsyncAPI: publish and subcribe confusion?
Posted by GitBox <gi...@apache.org>.
fmvilas commented on issue #716:
URL: https://github.com/apache/incubator-eventmesh/issues/716#issuecomment-1013731890
So having an offline chat with @tsurdilo, he rightly corrected my own confusion here 😅 It seems to be fine as it is because, for instance, the Online App Store is the one putting messages into `store/order` channel. Therefore the AsyncAPI verb should be "subscribe".
I'm closing the issue but feel free to reopen it again. Sorry for the noise 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] github-actions[bot] commented on issue #716: [Doc] Documentation Related
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #716:
URL: https://github.com/apache/incubator-eventmesh/issues/716#issuecomment-1013729604
Welcome to the Apache EventMesh (incubating) community!!
We are glad that you are contributing by opening this issue. :D
Please make sure to include all the relevant context.
We will be here shortly.
If you are interested in contributing to our project, please let us know!
You can check out our contributing guide on [contributing to EventMesh](https://github.com/apache/incubator-eventmesh/blob/develop/CONTRIBUTING.md).
Want to get closer to the community?
WeChat Group：
Mailing Lists:
| Name | Description |Subscribe |Unsubscribe|Archive
| ---- | ---- |---- | ---- | ---- |
|Users |User support and questions mailing list| [Subscribe](mailto:users-subscribe@eventmesh.incubator.apache.org) |[Unsubscribe](mailto:users-unsubscribe@eventmesh.incubator.apache.org) |[Mail Archives](https://lists.apache.org/list.html?users@eventmesh.apache.org)|
|Development |Development related discussions| [Subscribe](mailto:dev-subscribe@eventmesh.incubator.apache.org) |[Unsubscribe](mailto:dev-unsubscribe@eventmesh.incubator.apache.org) |[Mail Archives](https://lists.apache.org/list.html?dev@eventmesh.apache.org)|
|Commits |All commits to repositories| [Subscribe](mailto:commits-subscribe@eventmesh.incubator.apache.org) |[Unsubscribe](mailto:commits-unsubscribe@eventmesh.incubator.apache.org) |[Mail Archives](https://lists.apache.org/list.html?commits@eventmesh.apache.org)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org