[GitHub] [incubator-celeborn] zhongqiangczq commented on a diff in pull request #1166: [WIP][CELEBORN-148] Flink shuffle read.

[GitBox <gi...@apache.org>]

zhongqiangczq commented on code in PR #1166:
URL: https://github.com/apache/incubator-celeborn/pull/1166#discussion_r1070844197


##########
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/buffer/BufferPacker.java:
##########
@@ -114,7 +115,7 @@ public void close() {
   public static Queue<Buffer> unpack(ByteBuf byteBuf) {
     Queue<Buffer> buffers = new ArrayDeque<>();
     try {
-      Utils.checkState(byteBuf instanceof Buffer, "Illegal buffer type.");
+      checkState(byteBuf instanceof Buffer, "Illegal buffer type.");

Review Comment:
   bytebuf requires the instance of  Buffer which is org.apache.flink.runtime.io.network.buffer.
    Unpack trace called is  getDataListener -> dataListener.accept(readData.getBuf()) -> new ReadData(streamId, backlog, offset, Unpooled.wrappedBuffer(tmpBuf). 
   from the trace, it seems that it not the instance of  org.apache.flink.runtime.io.network.buffer
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org