[GitHub] [spark] advancedxy commented on a diff in pull request #41257: [SPARK-43657][K8S]: reuse config map for executor when running on k8s-cluster mode

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on code in PR #41257:
URL: https://github.com/apache/spark/pull/41257#discussion_r1200418849


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:
##########
@@ -378,7 +388,9 @@ private[spark] object Config extends Logging {
 
   val KUBERNETES_EXECUTOR_DISABLE_CONFIGMAP =
     ConfigBuilder("spark.kubernetes.executor.disableConfigMap")

Review Comment:
   Hi, @dongjoon-hyun If I understand your original intention correctly, this option is for spark on k8s-cluster mode?
   
   For spark on k8s-client mode, the driver/client would have to create the config map as well.
   
   If that's not your intention, please point it out, I will revert the related changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org