You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/08/18 07:31:41 UTC

[GitHub] [incubator-yunikorn-scheduler-interface] kingamarton opened a new pull request #24: [YUNIKORN-366] Add rest API to update queue configuration

kingamarton opened a new pull request #24:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/24


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei merged pull request #24: [YUNIKORN-366] Add rest API to update queue configuration

Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #24:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/24


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei commented on a change in pull request #24: [YUNIKORN-366] Add rest API to update queue configuration

Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #24:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/24#discussion_r477047208



##########
File path: scheduler-interface-spec.md
##########
@@ -869,6 +869,11 @@ message UpdateContainerSchedulingStateRequest {
    // an optional plain message to explain why it is in such state
    string reason = 4;
 }
+
+message ConfigMapArgs {
+    // New config what needs to be saved
+    string configs = 1;
+}

Review comment:
       Pls see my comment in the core side changes about the API naming




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org