You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org> on 2025/06/28 19:04:51 UTC
[PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]
Aggarwal-Raghav opened a new pull request, #5909:
URL: https://github.com/apache/hive/pull/5909
### What changes were proposed in this pull request?
[HIVE-29053](https://issues.apache.org/jira/browse/HIVE-29053), Skip the LOCATION field for proto tables when running qtests.
### Why are the changes needed?
Running the qtest containing `--! qt:sysdb`, causes creation of following dir in itests/qtest directory.
```
_REPLACE_WITH_APP_DATA_LOCATION_
_REPLACE_WITH_DAG_DATA_LOCATION_
_REPLACE_WITH_DAG_META_LOCATION_
_REPLACE_WITH_QUERY_DATA_LOCATION_
```
It better to have the proto tables share same location as other sys tables for testing/debugging purposes.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Ran the following command with and without the PR and observed the directory creation in `itests/qtest` directory
```
mvn clean test -Dtest=TestMiniLlapLocalCliDriver -Dqfile=query_history.q -Drat.skip -pl itests/qtest -Pitests
mvn clean test -Dtest=TestMiniLlapLocalCliDriver -Dqfile=sysdb.q -Drat.skip -pl itests/qtest -Pitests
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on code in PR #5909:
URL: https://github.com/apache/hive/pull/5909#discussion_r2175023151
##########
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:
##########
@@ -500,6 +500,9 @@ public CommandProcessorResponse processReader(BufferedReader r) throws IOExcepti
StringBuilder qsb = new StringBuilder();
while ((line = r.readLine()) != null) {
+ // Skipping the proto tables location.
+ if (line.startsWith("LOCATION '_REPLACE_WITH_")) continue;
Review Comment:
So, how about using `processLine` directly or a suitable method? `cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java` is not test code, but production code, although it's deprecated. It's better to avoid adding contextual branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #5909:
URL: https://github.com/apache/hive/pull/5909#issuecomment-3024019984
Just an update, i just found that the issue exists outside of qtest as well. Basically any test sourcing/using 4.1.0 schema file will face this.
https://github.com/apache/hive/blob/master/itests/hive-unit/src/test/java/org/apache/hive/service/server/InformationSchemaWithPrivilegeTestBase.java#L298-L304
running the following test also create _REPLACE dir.
```
cd itests/hive-unit; mvn clean test -Dtest=TestInformationSchemaWithPrivilegeZookeeperPlain -Drat.skip
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #5909:
URL: https://github.com/apache/hive/pull/5909#discussion_r2245165104
##########
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:
##########
@@ -500,6 +500,9 @@ public CommandProcessorResponse processReader(BufferedReader r) throws IOExcepti
StringBuilder qsb = new StringBuilder();
while ((line = r.readLine()) != null) {
+ // Skipping the proto tables location.
+ if (line.startsWith("LOCATION '_REPLACE_WITH_")) continue;
Review Comment:
@Aggarwal-Raghav could we move the string literal to constants (i.e. `PROTO_TABLE_LOCATION_PREFIX`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on PR #5909:
URL: https://github.com/apache/hive/pull/5909#issuecomment-3149305793
@deniskuzZ @Aggarwal-Raghav Sorry for the late response. I currently prefer to rewrite an SQL outside the compiler rather than to rewrite a part of an SQL inside the processor. That's because the latter approach is very ad-hoc and can potentially bring security problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5909:
URL: https://github.com/apache/hive/pull/5909#issuecomment-3016010554
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5909) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5909&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5909&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=5909&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5909&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=5909&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=5909)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on code in PR #5909:
URL: https://github.com/apache/hive/pull/5909#discussion_r2173822143
##########
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:
##########
@@ -500,6 +500,9 @@ public CommandProcessorResponse processReader(BufferedReader r) throws IOExcepti
StringBuilder qsb = new StringBuilder();
while ((line = r.readLine()) != null) {
+ // Skipping the proto tables location.
+ if (line.startsWith("LOCATION '_REPLACE_WITH_")) continue;
Review Comment:
Hi @okumin, thanks for the review. Here are few things that I checked before arriving at this PR:
1. `HiveSchemaTool#replaceLocationForProtoLogTables()` is the one which is doing the replacement for LOCATION during the schematool initialization at runtime (cluster setup etc.). But calling that method in qtest (CliDriver) is "little" troublesome and even after achieving that might not yield expected results.
2. "Why calling `replaceLocationForProtoLogTables` is troublesome" => because there are factors like conf object and adding dependency on tez-api and hive-beeline modules.
3. "Even after achieving that might not yield expected results" => in qtests, sysdb tables like `CDS`, `COLUMNS_V2` will have table location `.../itests/qtest/target/localfs/warehouse/sys.db/<tbl_name>/` but for proto tables the location will either be picked from config or default location i.e. `/tmp/` or `/tmp/query_data`.
4. IMO, having a uniform location for all tables for testing purpose is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]
Posted by "KiranVelumuri (via GitHub)" <gi...@apache.org>.
KiranVelumuri commented on PR #5909:
URL: https://github.com/apache/hive/pull/5909#issuecomment-3017851975
LGTM
nit: you could combine this into the existing logic to have like - skipping through comments and proto tables location
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on code in PR #5909:
URL: https://github.com/apache/hive/pull/5909#discussion_r2175200658
##########
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:
##########
@@ -500,6 +500,9 @@ public CommandProcessorResponse processReader(BufferedReader r) throws IOExcepti
StringBuilder qsb = new StringBuilder();
while ((line = r.readLine()) != null) {
+ // Skipping the proto tables location.
+ if (line.startsWith("LOCATION '_REPLACE_WITH_")) continue;
Review Comment:
@okumin, just thinking out loud and feel free to correct me if I'm wrong, writing the modified schema can lead to concurrency problems when UT (splits) are running parallely.
I understand why you want changes in QTestSysDbHandler instead of CliDriver. I'll see if its possible and update accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #5909:
URL: https://github.com/apache/hive/pull/5909#issuecomment-3139691763
@deniskuzZ , thanks for taking a look.
The presence of `LOCATION` field for the proto tables in the hive-schema-4.*.0.hive.sql is the problem, the way I see it.
No other tables (TBLS etc.) has the location field. If schema is instantiated via schemtool functionality then its fine as `HiveSchemaTool#replaceLocationForProtoLogTables()` will help.
But in UT, the schematool is not used. Hence the following will create the problem.
1. In QTestSysDbHandler.java
2. InformationSchemaWithPrivilegeTestBase.java
The current PR will help with [1] but for [2] it will not work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on code in PR #5909:
URL: https://github.com/apache/hive/pull/5909#discussion_r2174306467
##########
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:
##########
@@ -500,6 +500,9 @@ public CommandProcessorResponse processReader(BufferedReader r) throws IOExcepti
StringBuilder qsb = new StringBuilder();
while ((line = r.readLine()) != null) {
+ // Skipping the proto tables location.
+ if (line.startsWith("LOCATION '_REPLACE_WITH_")) continue;
Review Comment:
To state my intention clearly, I'm saying we can replace this line
```
String stsdbPath =
HiveTestEnvSetup.HIVE_ROOT + "/standalone-metastore/metastore-server/src/main/sql/hive/hive-schema-" + schemaVersion + ".hive.sql";
qt.getCliDriver().processLine("source " + stsdbPath)
```
with like this. Pseudo code.
```
String templatePath =
HiveTestEnvSetup.HIVE_ROOT + "/standalone-metastore/metastore-server/src/main/sql/hive/hive-schema-" + schemaVersion + ".hive.sql";
String newQueries = read(templatePath).replace("_REPLACE_WITH_APP_DATA_LOCATION_", ".../itests/qtest/target/localfs/warehouse/sys.db/app_data").replace("_REPLACE_WITH_(omitted)", "(omitted)").replace("(omitted)", "(omitted)").replace("(omitted)", "(omitted)");
String sourcePath = write(templatePath, "somewhere");
qt.getCliDriver().processLine("source " + sourcePath)
```
Then, we don't need to hack a parser or drivers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on code in PR #5909:
URL: https://github.com/apache/hive/pull/5909#discussion_r2173782177
##########
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:
##########
@@ -500,6 +500,9 @@ public CommandProcessorResponse processReader(BufferedReader r) throws IOExcepti
StringBuilder qsb = new StringBuilder();
while ((line = r.readLine()) != null) {
+ // Skipping the proto tables location.
+ if (line.startsWith("LOCATION '_REPLACE_WITH_")) continue;
Review Comment:
The issue might not occur with this change, but this workaround sounds a bit tricky. Although I haven't checked the feasibility, is it impossible to update this handler?
https://github.com/apache/hive/blob/master/itests/util/src/main/java/org/apache/hadoop/hive/ql/qoption/QTestSysDbHandler.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on PR #5909:
URL: https://github.com/apache/hive/pull/5909#issuecomment-3077081027
hi @okumin, is this good to be merged or it still requires some changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] [WIP] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav closed pull request #5909: [WIP] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb
URL: https://github.com/apache/hive/pull/5909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on PR #5909:
URL: https://github.com/apache/hive/pull/5909#issuecomment-3016755517
I verified the issue exists on the master branch, and this patch will resolve it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on code in PR #5909:
URL: https://github.com/apache/hive/pull/5909#discussion_r2174259073
##########
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:
##########
@@ -500,6 +500,9 @@ public CommandProcessorResponse processReader(BufferedReader r) throws IOExcepti
StringBuilder qsb = new StringBuilder();
while ((line = r.readLine()) != null) {
+ // Skipping the proto tables location.
+ if (line.startsWith("LOCATION '_REPLACE_WITH_")) continue;
Review Comment:
How about simply replacing the variables with the full path on the test filesystem?
I would say the current one has no side effect since CliDriver is used in only tests. When we drop it, we have to implement the same logic on Beeline. It is likely hacky or troublesome in the worst case to interrupt with the parser's behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #5909:
URL: https://github.com/apache/hive/pull/5909#issuecomment-3015989253
@okumin @deniskuzZ @KiranVelumuri , can you please help with the review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on code in PR #5909:
URL: https://github.com/apache/hive/pull/5909#discussion_r2177464705
##########
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:
##########
@@ -500,6 +500,9 @@ public CommandProcessorResponse processReader(BufferedReader r) throws IOExcepti
StringBuilder qsb = new StringBuilder();
while ((line = r.readLine()) != null) {
+ // Skipping the proto tables location.
+ if (line.startsWith("LOCATION '_REPLACE_WITH_")) continue;
Review Comment:
If we find a contention, we can add a UUID to the path name. We should minimize the code that modifies an SQL statement outside the ANTLR parser. It could result in the most severe vulnerability, such as an SQL injection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-29053: _REPLACE_WITH directory are created when running qtest using sysdb [hive]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on code in PR #5909:
URL: https://github.com/apache/hive/pull/5909#discussion_r2174927238
##########
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:
##########
@@ -500,6 +500,9 @@ public CommandProcessorResponse processReader(BufferedReader r) throws IOExcepti
StringBuilder qsb = new StringBuilder();
while ((line = r.readLine()) != null) {
+ // Skipping the proto tables location.
+ if (line.startsWith("LOCATION '_REPLACE_WITH_")) continue;
Review Comment:
@okumin, with the above pseudocode, it will end up reading the schema file + writing modified schema file (QTestSysDbHandler.java) and then again reading a modified schema file (CliDriver.java) **for each q file using sysdb**. I'm not inline with this approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org