You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/31 08:37:55 UTC
[GitHub] [camel-k] bouskaJ opened a new pull request, #3593: [TEST] OLM fresh install test
bouskaJ opened a new pull request, #3593:
URL: https://github.com/apache/camel-k/pull/3593
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] bouskaJ commented on pull request #3593: [TEST] OLM fresh install test
Posted by GitBox <gi...@apache.org>.
bouskaJ commented on PR #3593:
URL: https://github.com/apache/camel-k/pull/3593#issuecomment-1235198688
> @phantomjinx Doesn't olm test work under e2e/namespace/install? If it only works under e2e/namespace/upgrade maybe we should change the name from 'upgrade' to 'olm'.
We have two kinds of the tests in the `upgrade` folder
- [cli_upgrade_test.go](https://github.com/apache/camel-k/blob/main/e2e/namespace/upgrade/cli_upgrade_test.go) - test the upgrade without the OLM
- [olm_upgrade_test.go](https://github.com/apache/camel-k/blob/main/e2e/namespace/upgrade/olm_upgrade_test.go) - OLM focused upgrade test
As you can see that is not the OLM only workflow. I don't know how to approach this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] bouskaJ commented on pull request #3593: [TEST] OLM fresh install test
Posted by GitBox <gi...@apache.org>.
bouskaJ commented on PR #3593:
URL: https://github.com/apache/camel-k/pull/3593#issuecomment-1232642555
This test is implemented to check the OLM installation (mainly the correctness of the installed operator image). I am not sure whether it fits to the upgrade test but it's the only workflow with the OLM installation and I don't want to create a new one for this purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3593: [TEST] OLM fresh install test
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3593:
URL: https://github.com/apache/camel-k/pull/3593#issuecomment-1235094528
> This test is implemented to check the OLM installation (mainly the correctness of the installed operator image). I am not sure whether it fits to the upgrade test but it's the only workflow with the OLM installation and I don't want to create a new one for this purpose.
@bouskaJ I wonder why it cannot fit into e2e/namespace/install? Other than the install test suite is already bloated, it seems to be a more proper location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3593: [TEST] OLM fresh install test
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3593:
URL: https://github.com/apache/camel-k/pull/3593#issuecomment-1235157217
@phantomjinx Doesn't olm test work under e2e/namespace/install? If it only works under e2e/namespace/upgrade maybe we should change the name from 'upgrade' to 'olm'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] bouskaJ commented on pull request #3593: [TEST] OLM fresh install test
Posted by GitBox <gi...@apache.org>.
bouskaJ commented on PR #3593:
URL: https://github.com/apache/camel-k/pull/3593#issuecomment-1235134955
>
This test is focused on the OLM installation. I can't see the OLM installation step in the install test suite so I assume that it will not work under the `install` workflow environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3593: [TEST] OLM fresh install test
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3593:
URL: https://github.com/apache/camel-k/pull/3593#issuecomment-1236634104
OK, and right now OLM is available only under `e2e/namespace/upgrade`. Let's accept this PR as-is now. We should rename the e2e structure later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi merged pull request #3593: [TEST] OLM fresh install test
Posted by GitBox <gi...@apache.org>.
tadayosi merged PR #3593:
URL: https://github.com/apache/camel-k/pull/3593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org