You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/12 14:20:56 UTC
[GitHub] [flink] kylemeow commented on a change in pull request #11707:
[FLINK-15648][k8s] Introduce CPU limit support for JM/TM Container
kylemeow commented on a change in pull request #11707: [FLINK-15648][k8s] Introduce CPU limit support for JM/TM Container
URL: https://github.com/apache/flink/pull/11707#discussion_r407203121
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/utils/KubernetesUtils.java
##########
@@ -122,19 +123,35 @@ public static String getDeploymentName(String clusterId) {
* Get resource requirements from memory and cpu.
*
* @param mem Memory in mb.
- * @param cpu cpu.
+ * @param cpuRequest cpu request.
Review comment:
Hi Canbin, thanks for your contribution. Not meant to be a grammar police, however, I have seen multiple 'cpu' occurrences in the description and error messages. For standardization, could you please capitalize it as "CPU"?
Also please pay attention to its plural form, like "number of cpu", as it should be "number of CPUs" in the description text.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services