You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/12/09 17:48:23 UTC

[GitHub] erenavsarogullari opened a new pull request #3150: [Message Routing] Support default MessageRouter initialization as RoundRobin

erenavsarogullari opened a new pull request #3150: [Message Routing] Support default MessageRouter initialization as RoundRobin
URL: https://github.com/apache/pulsar/pull/3150
 
 
   ### Motivation
   This PR aims to initialize **default** `MessageRouter` as `RoundRobin` instead of `SinglePartition` by aligning `MessageRoutingMode` default settings under `ProducerBuilderImpl.setMessageRoutingMode`. In general, current implementation will not cause any problem due to `RoundRobin` coming as default and `MessageRoutingMode` is type-safe. However, it is useful for alignment both set/get logics.
   
   Following PR with #3126
   
   ### Modifications
   1- Patch is applied at `RoundRobinPartitionMessageRouterImpl`
   2- New UTs are added by creating `PartitionedProducerImplTest`
   3- Javadoc fix

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services