You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2024/02/12 19:48:57 UTC
Re: [PR] always sets needs recovery flag in tablet mgmt iterator [accumulo]
dlmarion commented on code in PR #4255:
URL: https://github.com/apache/accumulo/pull/4255#discussion_r1486690945
##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletManagementIterator.java:
##########
@@ -201,14 +201,13 @@ protected void consume() throws IOException {
actions.clear();
Exception error = null;
try {
+ LOG.trace("Evaluating extent: {}", tm);
+ computeTabletManagementActions(tm, actions);
Review Comment:
Prior to this change `computeTabletManagementActions` would only be called if the Manager state was normal, tservers were online, and there were online tables. We don't need these conditions to be true for the Root table, but I think we do for the Metadata and other tables as they are hosted by TabletServers. I'm wondering the consequence of calling this in all cases.
I'm wondering if we should only do this for the Root table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org