[kudu-CR] KUDU-2353: tool to parse metrics out of diagnostic logs

["Alexey Serbin (Code Review)" <ge...@cloudera.org>]

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12570 )

Change subject: KUDU-2353: tool to parse metrics out of diagnostic logs
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12570/12/src/kudu/tools/diagnostics_log_parser.cc
File src/kudu/tools/diagnostics_log_parser.cc:

http://gerrit.cloudera.org:8080/#/c/12570/12/src/kudu/tools/diagnostics_log_parser.cc@327
PS12, Line 327: timestamp
> Maybe have the timestamp (optionally via a flag) in human readable format f
That's a good point!

Is it OK with you if I do so in a separate follow-up patch?



-- 
To view, visit http://gerrit.cloudera.org:8080/12570
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8077fb4f6b41fe4b2bd6c877af379ea7a9f415b1
Gerrit-Change-Number: 12570
Gerrit-PatchSet: 12
Gerrit-Owner: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <an...@g.ucla.edu>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 11 Oct 2022 17:34:25 +0000
Gerrit-HasComments: Yes