You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/06/10 16:19:00 UTC
[jira] [Commented] (IMPALA-1653) Impala should not close a session
when a HiveServer2 connection is closed
[ https://issues.apache.org/jira/browse/IMPALA-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860123#comment-16860123 ]
ASF subversion and git services commented on IMPALA-1653:
---------------------------------------------------------
Commit f6d40b37c8b13131cbc75db6a7327c34bf0c5a34 in impala's branch refs/heads/master from Thomas Tauber-Marshall
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=f6d40b3 ]
IMPALA-8603: remove confusing logging from custom cluster tests
IMPALA-1653 added explicit closing of the HS2 session that is created
by ImpalaTestSuite during teardown. For the custom cluster tests, this
sometimes fails, either because the impalad was shutdown and is no
longer reachable or because it was restarted and the new impalad
doesn't know about the session that was created before restart.
Currently, when these errors occur we log them. However, this is
confusing because several custom cluster tests now log errors even
though they succeed. This patch changes this to simply ignore the
errors.
One concern is that a test may hit a genuine error here and if so we
won't have the logging for it. If this happens, though, it should
generally be possible for a dev to repro the error with the logging
enabled.
Change-Id: I96144fdbe6cc9bf0f01a9951420ee6f281fa6649
Reviewed-on: http://gerrit.cloudera.org:8080/13502
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Impala should not close a session when a HiveServer2 connection is closed
> -------------------------------------------------------------------------
>
> Key: IMPALA-1653
> URL: https://issues.apache.org/jira/browse/IMPALA-1653
> Project: IMPALA
> Issue Type: New Feature
> Components: Clients
> Affects Versions: Impala 2.1
> Reporter: Erick Tryzelaar
> Assignee: Thomas Tauber-Marshall
> Priority: Minor
> Labels: ramp-up
> Fix For: Impala 3.3.0
>
>
> Hue is currently [stateful|https://issues.cloudera.org/browse/HUE-2530] because in [IMPALA-564|https://issues.cloudera.org/browse/IMPALA-564], Impala will close the session if the connection is closed. Among other things, this prevents us from stateless load balancing because we need to route users to the same Hue backend that holds open the Impala socket.
> According to the [HiveServer2 design document|https://cwiki.apache.org/confluence/display/Hive/HiveServer2+Thrift+API], the HS2 protocol allows for the session to independent from the connection. Adding supporting this might not be too difficult. The connection is explicitly closed [here|https://github.com/cloudera/Impala/blob/master/be/src/service/impala-server.cc#L1696-L1702], and it's possible removing this block for HS2 connections might be sufficient to enable this feature.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org