You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/02/07 15:13:58 UTC
[04/42] hbase-site git commit: Published site at .
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6bdadd97/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALLockup.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALLockup.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALLockup.html
index 1ba4150..f7298cf 100644
--- a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALLockup.html
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestWALLockup.html
@@ -41,45 +41,45 @@
<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.HBaseClassTestRule;<a name="line.33"></a>
<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.34"></a>
<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.HConstants;<a name="line.35"></a>
-<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.HTableDescriptor;<a name="line.36"></a>
-<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.Server;<a name="line.37"></a>
-<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.ServerName;<a name="line.38"></a>
-<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.TableName;<a name="line.39"></a>
-<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.client.ClusterConnection;<a name="line.40"></a>
-<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.client.Connection;<a name="line.41"></a>
-<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.client.Durability;<a name="line.42"></a>
-<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.client.Put;<a name="line.43"></a>
-<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.regionserver.wal.DamagedWALException;<a name="line.44"></a>
-<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.regionserver.wal.FSHLog;<a name="line.45"></a>
-<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.regionserver.wal.FailedLogCloseException;<a name="line.46"></a>
-<span class="sourceLineNo">047</span>import org.apache.hadoop.hbase.regionserver.wal.WALActionsListener;<a name="line.47"></a>
-<span class="sourceLineNo">048</span>import org.apache.hadoop.hbase.testclassification.MediumTests;<a name="line.48"></a>
-<span class="sourceLineNo">049</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.49"></a>
-<span class="sourceLineNo">050</span>import org.apache.hadoop.hbase.util.EnvironmentEdgeManagerTestHelper;<a name="line.50"></a>
-<span class="sourceLineNo">051</span>import org.apache.hadoop.hbase.util.Threads;<a name="line.51"></a>
-<span class="sourceLineNo">052</span>import org.apache.hadoop.hbase.wal.WAL;<a name="line.52"></a>
-<span class="sourceLineNo">053</span>import org.apache.hadoop.hbase.wal.WALEdit;<a name="line.53"></a>
-<span class="sourceLineNo">054</span>import org.apache.hadoop.hbase.wal.WALKey;<a name="line.54"></a>
-<span class="sourceLineNo">055</span>import org.apache.hadoop.hbase.wal.WALKeyImpl;<a name="line.55"></a>
-<span class="sourceLineNo">056</span>import org.apache.hadoop.hbase.wal.WALProvider.Writer;<a name="line.56"></a>
-<span class="sourceLineNo">057</span>import org.apache.hadoop.hbase.zookeeper.MetaTableLocator;<a name="line.57"></a>
-<span class="sourceLineNo">058</span>import org.apache.hadoop.hbase.zookeeper.ZKWatcher;<a name="line.58"></a>
-<span class="sourceLineNo">059</span>import org.junit.After;<a name="line.59"></a>
-<span class="sourceLineNo">060</span>import org.junit.Before;<a name="line.60"></a>
-<span class="sourceLineNo">061</span>import org.junit.ClassRule;<a name="line.61"></a>
-<span class="sourceLineNo">062</span>import org.junit.Rule;<a name="line.62"></a>
-<span class="sourceLineNo">063</span>import org.junit.Test;<a name="line.63"></a>
-<span class="sourceLineNo">064</span>import org.junit.experimental.categories.Category;<a name="line.64"></a>
-<span class="sourceLineNo">065</span>import org.junit.rules.TestName;<a name="line.65"></a>
-<span class="sourceLineNo">066</span>import org.mockito.Mockito;<a name="line.66"></a>
-<span class="sourceLineNo">067</span>import org.slf4j.Logger;<a name="line.67"></a>
-<span class="sourceLineNo">068</span>import org.slf4j.LoggerFactory;<a name="line.68"></a>
-<span class="sourceLineNo">069</span><a name="line.69"></a>
-<span class="sourceLineNo">070</span>/**<a name="line.70"></a>
-<span class="sourceLineNo">071</span> * Testing for lock up of WAL subsystem.<a name="line.71"></a>
-<span class="sourceLineNo">072</span> * Copied from TestHRegion.<a name="line.72"></a>
+<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.Server;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.ServerName;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.TableName;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.client.ClusterConnection;<a name="line.39"></a>
+<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.client.Connection;<a name="line.40"></a>
+<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.client.Durability;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.client.Put;<a name="line.42"></a>
+<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.regionserver.wal.DamagedWALException;<a name="line.43"></a>
+<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.regionserver.wal.FSHLog;<a name="line.44"></a>
+<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.regionserver.wal.WALActionsListener;<a name="line.45"></a>
+<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.testclassification.MediumTests;<a name="line.46"></a>
+<span class="sourceLineNo">047</span>import org.apache.hadoop.hbase.testclassification.RegionServerTests;<a name="line.47"></a>
+<span class="sourceLineNo">048</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.48"></a>
+<span class="sourceLineNo">049</span>import org.apache.hadoop.hbase.util.EnvironmentEdgeManagerTestHelper;<a name="line.49"></a>
+<span class="sourceLineNo">050</span>import org.apache.hadoop.hbase.util.Threads;<a name="line.50"></a>
+<span class="sourceLineNo">051</span>import org.apache.hadoop.hbase.wal.WAL;<a name="line.51"></a>
+<span class="sourceLineNo">052</span>import org.apache.hadoop.hbase.wal.WALEdit;<a name="line.52"></a>
+<span class="sourceLineNo">053</span>import org.apache.hadoop.hbase.wal.WALKey;<a name="line.53"></a>
+<span class="sourceLineNo">054</span>import org.apache.hadoop.hbase.wal.WALKeyImpl;<a name="line.54"></a>
+<span class="sourceLineNo">055</span>import org.apache.hadoop.hbase.wal.WALProvider.Writer;<a name="line.55"></a>
+<span class="sourceLineNo">056</span>import org.apache.hadoop.hbase.zookeeper.MetaTableLocator;<a name="line.56"></a>
+<span class="sourceLineNo">057</span>import org.apache.hadoop.hbase.zookeeper.ZKWatcher;<a name="line.57"></a>
+<span class="sourceLineNo">058</span>import org.junit.After;<a name="line.58"></a>
+<span class="sourceLineNo">059</span>import org.junit.Before;<a name="line.59"></a>
+<span class="sourceLineNo">060</span>import org.junit.ClassRule;<a name="line.60"></a>
+<span class="sourceLineNo">061</span>import org.junit.Rule;<a name="line.61"></a>
+<span class="sourceLineNo">062</span>import org.junit.Test;<a name="line.62"></a>
+<span class="sourceLineNo">063</span>import org.junit.experimental.categories.Category;<a name="line.63"></a>
+<span class="sourceLineNo">064</span>import org.junit.rules.TestName;<a name="line.64"></a>
+<span class="sourceLineNo">065</span>import org.mockito.Mockito;<a name="line.65"></a>
+<span class="sourceLineNo">066</span>import org.slf4j.Logger;<a name="line.66"></a>
+<span class="sourceLineNo">067</span>import org.slf4j.LoggerFactory;<a name="line.67"></a>
+<span class="sourceLineNo">068</span><a name="line.68"></a>
+<span class="sourceLineNo">069</span>import org.apache.hbase.thirdparty.com.google.common.io.Closeables;<a name="line.69"></a>
+<span class="sourceLineNo">070</span><a name="line.70"></a>
+<span class="sourceLineNo">071</span>/**<a name="line.71"></a>
+<span class="sourceLineNo">072</span> * Testing for lock up of FSHLog.<a name="line.72"></a>
<span class="sourceLineNo">073</span> */<a name="line.73"></a>
-<span class="sourceLineNo">074</span>@Category({MediumTests.class})<a name="line.74"></a>
+<span class="sourceLineNo">074</span>@Category({ RegionServerTests.class, MediumTests.class })<a name="line.74"></a>
<span class="sourceLineNo">075</span>public class TestWALLockup {<a name="line.75"></a>
<span class="sourceLineNo">076</span><a name="line.76"></a>
<span class="sourceLineNo">077</span> @ClassRule<a name="line.77"></a>
@@ -87,23 +87,23 @@
<span class="sourceLineNo">079</span> HBaseClassTestRule.forClass(TestWALLockup.class);<a name="line.79"></a>
<span class="sourceLineNo">080</span><a name="line.80"></a>
<span class="sourceLineNo">081</span> private static final Logger LOG = LoggerFactory.getLogger(TestWALLockup.class);<a name="line.81"></a>
-<span class="sourceLineNo">082</span> @Rule public TestName name = new TestName();<a name="line.82"></a>
-<span class="sourceLineNo">083</span><a name="line.83"></a>
-<span class="sourceLineNo">084</span> private static final String COLUMN_FAMILY = "MyCF";<a name="line.84"></a>
-<span class="sourceLineNo">085</span> private static final byte [] COLUMN_FAMILY_BYTES = Bytes.toBytes(COLUMN_FAMILY);<a name="line.85"></a>
-<span class="sourceLineNo">086</span><a name="line.86"></a>
-<span class="sourceLineNo">087</span> HRegion region = null;<a name="line.87"></a>
-<span class="sourceLineNo">088</span> // Do not run unit tests in parallel (? Why not? It don't work? Why not? St.Ack)<a name="line.88"></a>
-<span class="sourceLineNo">089</span> private static HBaseTestingUtility TEST_UTIL;<a name="line.89"></a>
-<span class="sourceLineNo">090</span> private static Configuration CONF ;<a name="line.90"></a>
-<span class="sourceLineNo">091</span> private String dir;<a name="line.91"></a>
-<span class="sourceLineNo">092</span><a name="line.92"></a>
-<span class="sourceLineNo">093</span> // Test names<a name="line.93"></a>
-<span class="sourceLineNo">094</span> protected TableName tableName;<a name="line.94"></a>
-<span class="sourceLineNo">095</span><a name="line.95"></a>
-<span class="sourceLineNo">096</span> @Before<a name="line.96"></a>
-<span class="sourceLineNo">097</span> public void setup() throws IOException {<a name="line.97"></a>
-<span class="sourceLineNo">098</span> TEST_UTIL = HBaseTestingUtility.createLocalHTU();<a name="line.98"></a>
+<span class="sourceLineNo">082</span><a name="line.82"></a>
+<span class="sourceLineNo">083</span> @Rule<a name="line.83"></a>
+<span class="sourceLineNo">084</span> public TestName name = new TestName();<a name="line.84"></a>
+<span class="sourceLineNo">085</span><a name="line.85"></a>
+<span class="sourceLineNo">086</span> private static final String COLUMN_FAMILY = "MyCF";<a name="line.86"></a>
+<span class="sourceLineNo">087</span> private static final byte [] COLUMN_FAMILY_BYTES = Bytes.toBytes(COLUMN_FAMILY);<a name="line.87"></a>
+<span class="sourceLineNo">088</span><a name="line.88"></a>
+<span class="sourceLineNo">089</span> HRegion region = null;<a name="line.89"></a>
+<span class="sourceLineNo">090</span> private static HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();<a name="line.90"></a>
+<span class="sourceLineNo">091</span> private static Configuration CONF ;<a name="line.91"></a>
+<span class="sourceLineNo">092</span> private String dir;<a name="line.92"></a>
+<span class="sourceLineNo">093</span><a name="line.93"></a>
+<span class="sourceLineNo">094</span> // Test names<a name="line.94"></a>
+<span class="sourceLineNo">095</span> protected TableName tableName;<a name="line.95"></a>
+<span class="sourceLineNo">096</span><a name="line.96"></a>
+<span class="sourceLineNo">097</span> @Before<a name="line.97"></a>
+<span class="sourceLineNo">098</span> public void setup() throws IOException {<a name="line.98"></a>
<span class="sourceLineNo">099</span> CONF = TEST_UTIL.getConfiguration();<a name="line.99"></a>
<span class="sourceLineNo">100</span> // Disable block cache.<a name="line.100"></a>
<span class="sourceLineNo">101</span> CONF.setFloat(HConstants.HFILE_BLOCK_CACHE_SIZE_KEY, 0f);<a name="line.101"></a>
@@ -118,178 +118,178 @@
<span class="sourceLineNo">110</span> TEST_UTIL.cleanupTestDir();<a name="line.110"></a>
<span class="sourceLineNo">111</span> }<a name="line.111"></a>
<span class="sourceLineNo">112</span><a name="line.112"></a>
-<span class="sourceLineNo">113</span> String getName() {<a name="line.113"></a>
+<span class="sourceLineNo">113</span> private String getName() {<a name="line.113"></a>
<span class="sourceLineNo">114</span> return name.getMethodName();<a name="line.114"></a>
<span class="sourceLineNo">115</span> }<a name="line.115"></a>
<span class="sourceLineNo">116</span><a name="line.116"></a>
-<span class="sourceLineNo">117</span> /**<a name="line.117"></a>
-<span class="sourceLineNo">118</span> * Reproduce locking up that happens when we get an inopportune sync during setup for<a name="line.118"></a>
-<span class="sourceLineNo">119</span> * zigzaglatch wait. See HBASE-14317. If below is broken, we will see this test timeout because<a name="line.119"></a>
-<span class="sourceLineNo">120</span> * it is locked up.<a name="line.120"></a>
-<span class="sourceLineNo">121</span> * <p>First I need to set up some mocks for Server and RegionServerServices. I also need to<a name="line.121"></a>
-<span class="sourceLineNo">122</span> * set up a dodgy WAL that will throw an exception when we go to append to it.<a name="line.122"></a>
-<span class="sourceLineNo">123</span> */<a name="line.123"></a>
-<span class="sourceLineNo">124</span> @Test (timeout=20000)<a name="line.124"></a>
-<span class="sourceLineNo">125</span> public void testLockupWhenSyncInMiddleOfZigZagSetup() throws IOException {<a name="line.125"></a>
-<span class="sourceLineNo">126</span> // A WAL that we can have throw exceptions when a flag is set.<a name="line.126"></a>
-<span class="sourceLineNo">127</span> class DodgyFSLog extends FSHLog {<a name="line.127"></a>
-<span class="sourceLineNo">128</span> // Set this when want the WAL to start throwing exceptions.<a name="line.128"></a>
-<span class="sourceLineNo">129</span> volatile boolean throwException = false;<a name="line.129"></a>
-<span class="sourceLineNo">130</span><a name="line.130"></a>
-<span class="sourceLineNo">131</span> // Latch to hold up processing until after another operation has had time to run.<a name="line.131"></a>
-<span class="sourceLineNo">132</span> CountDownLatch latch = new CountDownLatch(1);<a name="line.132"></a>
-<span class="sourceLineNo">133</span><a name="line.133"></a>
-<span class="sourceLineNo">134</span> public DodgyFSLog(FileSystem fs, Path root, String logDir, Configuration conf)<a name="line.134"></a>
-<span class="sourceLineNo">135</span> throws IOException {<a name="line.135"></a>
-<span class="sourceLineNo">136</span> super(fs, root, logDir, conf);<a name="line.136"></a>
-<span class="sourceLineNo">137</span> }<a name="line.137"></a>
-<span class="sourceLineNo">138</span><a name="line.138"></a>
-<span class="sourceLineNo">139</span> @Override<a name="line.139"></a>
-<span class="sourceLineNo">140</span> protected void afterCreatingZigZagLatch() {<a name="line.140"></a>
-<span class="sourceLineNo">141</span> // If throwException set, then append will throw an exception causing the WAL to be<a name="line.141"></a>
-<span class="sourceLineNo">142</span> // rolled. We'll come in here. Hold up processing until a sync can get in before<a name="line.142"></a>
-<span class="sourceLineNo">143</span> // the zigzag has time to complete its setup and get its own sync in. This is what causes<a name="line.143"></a>
-<span class="sourceLineNo">144</span> // the lock up we've seen in production.<a name="line.144"></a>
-<span class="sourceLineNo">145</span> if (throwException) {<a name="line.145"></a>
-<span class="sourceLineNo">146</span> try {<a name="line.146"></a>
-<span class="sourceLineNo">147</span> LOG.info("LATCHED");<a name="line.147"></a>
-<span class="sourceLineNo">148</span> // So, timing can have it that the test can run and the bad flush below happens<a name="line.148"></a>
-<span class="sourceLineNo">149</span> // before we get here. In this case, we'll be stuck waiting on this latch but there<a name="line.149"></a>
-<span class="sourceLineNo">150</span> // is nothing in the WAL pipeline to get us to the below beforeWaitOnSafePoint...<a name="line.150"></a>
-<span class="sourceLineNo">151</span> // because all WALs have rolled. In this case, just give up on test.<a name="line.151"></a>
-<span class="sourceLineNo">152</span> if (!this.latch.await(5, TimeUnit.SECONDS)) {<a name="line.152"></a>
-<span class="sourceLineNo">153</span> LOG.warn("GIVE UP! Failed waiting on latch...Test is ABORTED!");<a name="line.153"></a>
-<span class="sourceLineNo">154</span> }<a name="line.154"></a>
-<span class="sourceLineNo">155</span> } catch (InterruptedException e) {<a name="line.155"></a>
-<span class="sourceLineNo">156</span> // TODO Auto-generated catch block<a name="line.156"></a>
-<span class="sourceLineNo">157</span> e.printStackTrace();<a name="line.157"></a>
-<span class="sourceLineNo">158</span> }<a name="line.158"></a>
-<span class="sourceLineNo">159</span> }<a name="line.159"></a>
-<span class="sourceLineNo">160</span> }<a name="line.160"></a>
-<span class="sourceLineNo">161</span><a name="line.161"></a>
-<span class="sourceLineNo">162</span> @Override<a name="line.162"></a>
-<span class="sourceLineNo">163</span> protected void beforeWaitOnSafePoint() {<a name="line.163"></a>
-<span class="sourceLineNo">164</span> if (throwException) {<a name="line.164"></a>
-<span class="sourceLineNo">165</span> LOG.info("COUNTDOWN");<a name="line.165"></a>
-<span class="sourceLineNo">166</span> // Don't countdown latch until someone waiting on it otherwise, the above<a name="line.166"></a>
-<span class="sourceLineNo">167</span> // afterCreatingZigZagLatch will get to the latch and no one will ever free it and we'll<a name="line.167"></a>
-<span class="sourceLineNo">168</span> // be stuck; test won't go down<a name="line.168"></a>
-<span class="sourceLineNo">169</span> while (this.latch.getCount() <= 0) Threads.sleep(1);<a name="line.169"></a>
-<span class="sourceLineNo">170</span> this.latch.countDown();<a name="line.170"></a>
+<span class="sourceLineNo">117</span> // A WAL that we can have throw exceptions when a flag is set.<a name="line.117"></a>
+<span class="sourceLineNo">118</span> private static final class DodgyFSLog extends FSHLog {<a name="line.118"></a>
+<span class="sourceLineNo">119</span> // Set this when want the WAL to start throwing exceptions.<a name="line.119"></a>
+<span class="sourceLineNo">120</span> volatile boolean throwException = false;<a name="line.120"></a>
+<span class="sourceLineNo">121</span><a name="line.121"></a>
+<span class="sourceLineNo">122</span> // Latch to hold up processing until after another operation has had time to run.<a name="line.122"></a>
+<span class="sourceLineNo">123</span> CountDownLatch latch = new CountDownLatch(1);<a name="line.123"></a>
+<span class="sourceLineNo">124</span><a name="line.124"></a>
+<span class="sourceLineNo">125</span> public DodgyFSLog(FileSystem fs, Path root, String logDir, Configuration conf)<a name="line.125"></a>
+<span class="sourceLineNo">126</span> throws IOException {<a name="line.126"></a>
+<span class="sourceLineNo">127</span> super(fs, root, logDir, conf);<a name="line.127"></a>
+<span class="sourceLineNo">128</span> }<a name="line.128"></a>
+<span class="sourceLineNo">129</span><a name="line.129"></a>
+<span class="sourceLineNo">130</span> @Override<a name="line.130"></a>
+<span class="sourceLineNo">131</span> protected void afterCreatingZigZagLatch() {<a name="line.131"></a>
+<span class="sourceLineNo">132</span> // If throwException set, then append will throw an exception causing the WAL to be<a name="line.132"></a>
+<span class="sourceLineNo">133</span> // rolled. We'll come in here. Hold up processing until a sync can get in before<a name="line.133"></a>
+<span class="sourceLineNo">134</span> // the zigzag has time to complete its setup and get its own sync in. This is what causes<a name="line.134"></a>
+<span class="sourceLineNo">135</span> // the lock up we've seen in production.<a name="line.135"></a>
+<span class="sourceLineNo">136</span> if (throwException) {<a name="line.136"></a>
+<span class="sourceLineNo">137</span> try {<a name="line.137"></a>
+<span class="sourceLineNo">138</span> LOG.info("LATCHED");<a name="line.138"></a>
+<span class="sourceLineNo">139</span> // So, timing can have it that the test can run and the bad flush below happens<a name="line.139"></a>
+<span class="sourceLineNo">140</span> // before we get here. In this case, we'll be stuck waiting on this latch but there<a name="line.140"></a>
+<span class="sourceLineNo">141</span> // is nothing in the WAL pipeline to get us to the below beforeWaitOnSafePoint...<a name="line.141"></a>
+<span class="sourceLineNo">142</span> // because all WALs have rolled. In this case, just give up on test.<a name="line.142"></a>
+<span class="sourceLineNo">143</span> if (!this.latch.await(5, TimeUnit.SECONDS)) {<a name="line.143"></a>
+<span class="sourceLineNo">144</span> LOG.warn("GIVE UP! Failed waiting on latch...Test is ABORTED!");<a name="line.144"></a>
+<span class="sourceLineNo">145</span> }<a name="line.145"></a>
+<span class="sourceLineNo">146</span> } catch (InterruptedException e) {<a name="line.146"></a>
+<span class="sourceLineNo">147</span> }<a name="line.147"></a>
+<span class="sourceLineNo">148</span> }<a name="line.148"></a>
+<span class="sourceLineNo">149</span> }<a name="line.149"></a>
+<span class="sourceLineNo">150</span><a name="line.150"></a>
+<span class="sourceLineNo">151</span> @Override<a name="line.151"></a>
+<span class="sourceLineNo">152</span> protected void beforeWaitOnSafePoint() {<a name="line.152"></a>
+<span class="sourceLineNo">153</span> if (throwException) {<a name="line.153"></a>
+<span class="sourceLineNo">154</span> LOG.info("COUNTDOWN");<a name="line.154"></a>
+<span class="sourceLineNo">155</span> // Don't countdown latch until someone waiting on it otherwise, the above<a name="line.155"></a>
+<span class="sourceLineNo">156</span> // afterCreatingZigZagLatch will get to the latch and no one will ever free it and we'll<a name="line.156"></a>
+<span class="sourceLineNo">157</span> // be stuck; test won't go down<a name="line.157"></a>
+<span class="sourceLineNo">158</span> while (this.latch.getCount() <= 0)<a name="line.158"></a>
+<span class="sourceLineNo">159</span> Threads.sleep(1);<a name="line.159"></a>
+<span class="sourceLineNo">160</span> this.latch.countDown();<a name="line.160"></a>
+<span class="sourceLineNo">161</span> }<a name="line.161"></a>
+<span class="sourceLineNo">162</span> }<a name="line.162"></a>
+<span class="sourceLineNo">163</span><a name="line.163"></a>
+<span class="sourceLineNo">164</span> @Override<a name="line.164"></a>
+<span class="sourceLineNo">165</span> protected Writer createWriterInstance(Path path) throws IOException {<a name="line.165"></a>
+<span class="sourceLineNo">166</span> final Writer w = super.createWriterInstance(path);<a name="line.166"></a>
+<span class="sourceLineNo">167</span> return new Writer() {<a name="line.167"></a>
+<span class="sourceLineNo">168</span> @Override<a name="line.168"></a>
+<span class="sourceLineNo">169</span> public void close() throws IOException {<a name="line.169"></a>
+<span class="sourceLineNo">170</span> w.close();<a name="line.170"></a>
<span class="sourceLineNo">171</span> }<a name="line.171"></a>
-<span class="sourceLineNo">172</span> }<a name="line.172"></a>
-<span class="sourceLineNo">173</span><a name="line.173"></a>
-<span class="sourceLineNo">174</span> @Override<a name="line.174"></a>
-<span class="sourceLineNo">175</span> protected Writer createWriterInstance(Path path) throws IOException {<a name="line.175"></a>
-<span class="sourceLineNo">176</span> final Writer w = super.createWriterInstance(path);<a name="line.176"></a>
-<span class="sourceLineNo">177</span> return new Writer() {<a name="line.177"></a>
-<span class="sourceLineNo">178</span> @Override<a name="line.178"></a>
-<span class="sourceLineNo">179</span> public void close() throws IOException {<a name="line.179"></a>
-<span class="sourceLineNo">180</span> w.close();<a name="line.180"></a>
-<span class="sourceLineNo">181</span> }<a name="line.181"></a>
-<span class="sourceLineNo">182</span><a name="line.182"></a>
-<span class="sourceLineNo">183</span> @Override<a name="line.183"></a>
-<span class="sourceLineNo">184</span> public void sync() throws IOException {<a name="line.184"></a>
-<span class="sourceLineNo">185</span> if (throwException) {<a name="line.185"></a>
-<span class="sourceLineNo">186</span> throw new IOException("FAKE! Failed to replace a bad datanode...SYNC");<a name="line.186"></a>
-<span class="sourceLineNo">187</span> }<a name="line.187"></a>
-<span class="sourceLineNo">188</span> w.sync();<a name="line.188"></a>
-<span class="sourceLineNo">189</span> }<a name="line.189"></a>
-<span class="sourceLineNo">190</span><a name="line.190"></a>
-<span class="sourceLineNo">191</span> @Override<a name="line.191"></a>
-<span class="sourceLineNo">192</span> public void append(Entry entry) throws IOException {<a name="line.192"></a>
-<span class="sourceLineNo">193</span> if (throwException) {<a name="line.193"></a>
-<span class="sourceLineNo">194</span> throw new IOException("FAKE! Failed to replace a bad datanode...APPEND");<a name="line.194"></a>
-<span class="sourceLineNo">195</span> }<a name="line.195"></a>
-<span class="sourceLineNo">196</span> w.append(entry);<a name="line.196"></a>
-<span class="sourceLineNo">197</span> }<a name="line.197"></a>
-<span class="sourceLineNo">198</span><a name="line.198"></a>
-<span class="sourceLineNo">199</span> @Override<a name="line.199"></a>
-<span class="sourceLineNo">200</span> public long getLength() {<a name="line.200"></a>
-<span class="sourceLineNo">201</span> return w.getLength();<a name="line.201"></a>
-<span class="sourceLineNo">202</span> }<a name="line.202"></a>
-<span class="sourceLineNo">203</span> };<a name="line.203"></a>
-<span class="sourceLineNo">204</span> }<a name="line.204"></a>
-<span class="sourceLineNo">205</span> }<a name="line.205"></a>
-<span class="sourceLineNo">206</span><a name="line.206"></a>
-<span class="sourceLineNo">207</span> // Mocked up server and regionserver services. Needed below.<a name="line.207"></a>
-<span class="sourceLineNo">208</span> Server server = Mockito.mock(Server.class);<a name="line.208"></a>
-<span class="sourceLineNo">209</span> Mockito.when(server.getConfiguration()).thenReturn(CONF);<a name="line.209"></a>
-<span class="sourceLineNo">210</span> Mockito.when(server.isStopped()).thenReturn(false);<a name="line.210"></a>
-<span class="sourceLineNo">211</span> Mockito.when(server.isAborted()).thenReturn(false);<a name="line.211"></a>
-<span class="sourceLineNo">212</span> RegionServerServices services = Mockito.mock(RegionServerServices.class);<a name="line.212"></a>
-<span class="sourceLineNo">213</span><a name="line.213"></a>
-<span class="sourceLineNo">214</span> // OK. Now I have my mocked up Server & RegionServerServices and dodgy WAL, go ahead with test.<a name="line.214"></a>
-<span class="sourceLineNo">215</span> FileSystem fs = FileSystem.get(CONF);<a name="line.215"></a>
-<span class="sourceLineNo">216</span> Path rootDir = new Path(dir + getName());<a name="line.216"></a>
-<span class="sourceLineNo">217</span> DodgyFSLog dodgyWAL = new DodgyFSLog(fs, rootDir, getName(), CONF);<a name="line.217"></a>
-<span class="sourceLineNo">218</span> Path originalWAL = dodgyWAL.getCurrentFileName();<a name="line.218"></a>
-<span class="sourceLineNo">219</span> // I need a log roller running.<a name="line.219"></a>
-<span class="sourceLineNo">220</span> LogRoller logRoller = new LogRoller(server, services);<a name="line.220"></a>
-<span class="sourceLineNo">221</span> logRoller.addWAL(dodgyWAL);<a name="line.221"></a>
-<span class="sourceLineNo">222</span> // There is no 'stop' once a logRoller is running.. it just dies.<a name="line.222"></a>
-<span class="sourceLineNo">223</span> logRoller.start();<a name="line.223"></a>
-<span class="sourceLineNo">224</span> // Now get a region and start adding in edits.<a name="line.224"></a>
-<span class="sourceLineNo">225</span> HTableDescriptor htd = new HTableDescriptor(TableName.META_TABLE_NAME);<a name="line.225"></a>
-<span class="sourceLineNo">226</span> final HRegion region = initHRegion(tableName, null, null, dodgyWAL);<a name="line.226"></a>
-<span class="sourceLineNo">227</span> byte [] bytes = Bytes.toBytes(getName());<a name="line.227"></a>
-<span class="sourceLineNo">228</span> NavigableMap<byte[], Integer> scopes = new TreeMap<>(<a name="line.228"></a>
-<span class="sourceLineNo">229</span> Bytes.BYTES_COMPARATOR);<a name="line.229"></a>
-<span class="sourceLineNo">230</span> scopes.put(COLUMN_FAMILY_BYTES, 0);<a name="line.230"></a>
-<span class="sourceLineNo">231</span> MultiVersionConcurrencyControl mvcc = new MultiVersionConcurrencyControl();<a name="line.231"></a>
-<span class="sourceLineNo">232</span> try {<a name="line.232"></a>
-<span class="sourceLineNo">233</span> // First get something into memstore. Make a Put and then pull the Cell out of it. Will<a name="line.233"></a>
-<span class="sourceLineNo">234</span> // manage append and sync carefully in below to manufacture hang. We keep adding same<a name="line.234"></a>
-<span class="sourceLineNo">235</span> // edit. WAL subsystem doesn't care.<a name="line.235"></a>
-<span class="sourceLineNo">236</span> Put put = new Put(bytes);<a name="line.236"></a>
-<span class="sourceLineNo">237</span> put.addColumn(COLUMN_FAMILY_BYTES, Bytes.toBytes("1"), bytes);<a name="line.237"></a>
-<span class="sourceLineNo">238</span> WALKeyImpl key = new WALKeyImpl(region.getRegionInfo().getEncodedNameAsBytes(),<a name="line.238"></a>
-<span class="sourceLineNo">239</span> htd.getTableName(), System.currentTimeMillis(), mvcc, scopes);<a name="line.239"></a>
-<span class="sourceLineNo">240</span> WALEdit edit = new WALEdit();<a name="line.240"></a>
-<span class="sourceLineNo">241</span> CellScanner CellScanner = put.cellScanner();<a name="line.241"></a>
-<span class="sourceLineNo">242</span> assertTrue(CellScanner.advance());<a name="line.242"></a>
-<span class="sourceLineNo">243</span> edit.add(CellScanner.current());<a name="line.243"></a>
-<span class="sourceLineNo">244</span> // Put something in memstore and out in the WAL. Do a big number of appends so we push<a name="line.244"></a>
-<span class="sourceLineNo">245</span> // out other side of the ringbuffer. If small numbers, stuff doesn't make it to WAL<a name="line.245"></a>
-<span class="sourceLineNo">246</span> for (int i = 0; i < 1000; i++) {<a name="line.246"></a>
-<span class="sourceLineNo">247</span> region.put(put);<a name="line.247"></a>
-<span class="sourceLineNo">248</span> }<a name="line.248"></a>
-<span class="sourceLineNo">249</span> // Set it so we start throwing exceptions.<a name="line.249"></a>
-<span class="sourceLineNo">250</span> LOG.info("SET throwing of exception on append");<a name="line.250"></a>
-<span class="sourceLineNo">251</span> dodgyWAL.throwException = true;<a name="line.251"></a>
-<span class="sourceLineNo">252</span> // This append provokes a WAL roll request<a name="line.252"></a>
-<span class="sourceLineNo">253</span> dodgyWAL.append(region.getRegionInfo(), key, edit, true);<a name="line.253"></a>
-<span class="sourceLineNo">254</span> boolean exception = false;<a name="line.254"></a>
-<span class="sourceLineNo">255</span> try {<a name="line.255"></a>
-<span class="sourceLineNo">256</span> dodgyWAL.sync();<a name="line.256"></a>
-<span class="sourceLineNo">257</span> } catch (Exception e) {<a name="line.257"></a>
-<span class="sourceLineNo">258</span> exception = true;<a name="line.258"></a>
-<span class="sourceLineNo">259</span> }<a name="line.259"></a>
-<span class="sourceLineNo">260</span> assertTrue("Did not get sync exception", exception);<a name="line.260"></a>
-<span class="sourceLineNo">261</span><a name="line.261"></a>
-<span class="sourceLineNo">262</span> // Get a memstore flush going too so we have same hung profile as up in the issue over<a name="line.262"></a>
-<span class="sourceLineNo">263</span> // in HBASE-14317. Flush hangs trying to get sequenceid because the ringbuffer is held up<a name="line.263"></a>
-<span class="sourceLineNo">264</span> // by the zigzaglatch waiting on syncs to come home.<a name="line.264"></a>
-<span class="sourceLineNo">265</span> Thread t = new Thread ("Flusher") {<a name="line.265"></a>
-<span class="sourceLineNo">266</span> @Override<a name="line.266"></a>
-<span class="sourceLineNo">267</span> public void run() {<a name="line.267"></a>
-<span class="sourceLineNo">268</span> try {<a name="line.268"></a>
-<span class="sourceLineNo">269</span> if (region.getMemStoreSize() <= 0) {<a name="line.269"></a>
-<span class="sourceLineNo">270</span> throw new IOException("memstore size=" + region.getMemStoreSize());<a name="line.270"></a>
-<span class="sourceLineNo">271</span> }<a name="line.271"></a>
-<span class="sourceLineNo">272</span> region.flush(false);<a name="line.272"></a>
-<span class="sourceLineNo">273</span> } catch (IOException e) {<a name="line.273"></a>
-<span class="sourceLineNo">274</span> // Can fail trying to flush in middle of a roll. Not a failure. Will succeed later<a name="line.274"></a>
-<span class="sourceLineNo">275</span> // when roll completes.<a name="line.275"></a>
-<span class="sourceLineNo">276</span> LOG.info("In flush", e);<a name="line.276"></a>
-<span class="sourceLineNo">277</span> }<a name="line.277"></a>
-<span class="sourceLineNo">278</span> LOG.info("Exiting");<a name="line.278"></a>
-<span class="sourceLineNo">279</span> }<a name="line.279"></a>
-<span class="sourceLineNo">280</span> };<a name="line.280"></a>
-<span class="sourceLineNo">281</span> t.setDaemon(true);<a name="line.281"></a>
-<span class="sourceLineNo">282</span> t.start();<a name="line.282"></a>
-<span class="sourceLineNo">283</span> // Wait until<a name="line.283"></a>
-<span class="sourceLineNo">284</span> while (dodgyWAL.latch.getCount() > 0) Threads.sleep(1);<a name="line.284"></a>
+<span class="sourceLineNo">172</span><a name="line.172"></a>
+<span class="sourceLineNo">173</span> @Override<a name="line.173"></a>
+<span class="sourceLineNo">174</span> public void sync() throws IOException {<a name="line.174"></a>
+<span class="sourceLineNo">175</span> if (throwException) {<a name="line.175"></a>
+<span class="sourceLineNo">176</span> throw new IOException("FAKE! Failed to replace a bad datanode...SYNC");<a name="line.176"></a>
+<span class="sourceLineNo">177</span> }<a name="line.177"></a>
+<span class="sourceLineNo">178</span> w.sync();<a name="line.178"></a>
+<span class="sourceLineNo">179</span> }<a name="line.179"></a>
+<span class="sourceLineNo">180</span><a name="line.180"></a>
+<span class="sourceLineNo">181</span> @Override<a name="line.181"></a>
+<span class="sourceLineNo">182</span> public void append(Entry entry) throws IOException {<a name="line.182"></a>
+<span class="sourceLineNo">183</span> if (throwException) {<a name="line.183"></a>
+<span class="sourceLineNo">184</span> throw new IOException("FAKE! Failed to replace a bad datanode...APPEND");<a name="line.184"></a>
+<span class="sourceLineNo">185</span> }<a name="line.185"></a>
+<span class="sourceLineNo">186</span> w.append(entry);<a name="line.186"></a>
+<span class="sourceLineNo">187</span> }<a name="line.187"></a>
+<span class="sourceLineNo">188</span><a name="line.188"></a>
+<span class="sourceLineNo">189</span> @Override<a name="line.189"></a>
+<span class="sourceLineNo">190</span> public long getLength() {<a name="line.190"></a>
+<span class="sourceLineNo">191</span> return w.getLength();<a name="line.191"></a>
+<span class="sourceLineNo">192</span> }<a name="line.192"></a>
+<span class="sourceLineNo">193</span> };<a name="line.193"></a>
+<span class="sourceLineNo">194</span> }<a name="line.194"></a>
+<span class="sourceLineNo">195</span> }<a name="line.195"></a>
+<span class="sourceLineNo">196</span><a name="line.196"></a>
+<span class="sourceLineNo">197</span> /**<a name="line.197"></a>
+<span class="sourceLineNo">198</span> * Reproduce locking up that happens when we get an inopportune sync during setup for<a name="line.198"></a>
+<span class="sourceLineNo">199</span> * zigzaglatch wait. See HBASE-14317. If below is broken, we will see this test timeout because<a name="line.199"></a>
+<span class="sourceLineNo">200</span> * it is locked up.<a name="line.200"></a>
+<span class="sourceLineNo">201</span> * <p>First I need to set up some mocks for Server and RegionServerServices. I also need to<a name="line.201"></a>
+<span class="sourceLineNo">202</span> * set up a dodgy WAL that will throw an exception when we go to append to it.<a name="line.202"></a>
+<span class="sourceLineNo">203</span> */<a name="line.203"></a>
+<span class="sourceLineNo">204</span> @Test<a name="line.204"></a>
+<span class="sourceLineNo">205</span> public void testLockupWhenSyncInMiddleOfZigZagSetup() throws IOException {<a name="line.205"></a>
+<span class="sourceLineNo">206</span> // Mocked up server and regionserver services. Needed below.<a name="line.206"></a>
+<span class="sourceLineNo">207</span> Server server = Mockito.mock(Server.class);<a name="line.207"></a>
+<span class="sourceLineNo">208</span> Mockito.when(server.getConfiguration()).thenReturn(CONF);<a name="line.208"></a>
+<span class="sourceLineNo">209</span> Mockito.when(server.isStopped()).thenReturn(false);<a name="line.209"></a>
+<span class="sourceLineNo">210</span> Mockito.when(server.isAborted()).thenReturn(false);<a name="line.210"></a>
+<span class="sourceLineNo">211</span> RegionServerServices services = Mockito.mock(RegionServerServices.class);<a name="line.211"></a>
+<span class="sourceLineNo">212</span><a name="line.212"></a>
+<span class="sourceLineNo">213</span> // OK. Now I have my mocked up Server & RegionServerServices and dodgy WAL, go ahead with test.<a name="line.213"></a>
+<span class="sourceLineNo">214</span> FileSystem fs = FileSystem.get(CONF);<a name="line.214"></a>
+<span class="sourceLineNo">215</span> Path rootDir = new Path(dir + getName());<a name="line.215"></a>
+<span class="sourceLineNo">216</span> DodgyFSLog dodgyWAL = new DodgyFSLog(fs, rootDir, getName(), CONF);<a name="line.216"></a>
+<span class="sourceLineNo">217</span> Path originalWAL = dodgyWAL.getCurrentFileName();<a name="line.217"></a>
+<span class="sourceLineNo">218</span> // I need a log roller running.<a name="line.218"></a>
+<span class="sourceLineNo">219</span> LogRoller logRoller = new LogRoller(server, services);<a name="line.219"></a>
+<span class="sourceLineNo">220</span> logRoller.addWAL(dodgyWAL);<a name="line.220"></a>
+<span class="sourceLineNo">221</span> // There is no 'stop' once a logRoller is running.. it just dies.<a name="line.221"></a>
+<span class="sourceLineNo">222</span> logRoller.start();<a name="line.222"></a>
+<span class="sourceLineNo">223</span> // Now get a region and start adding in edits.<a name="line.223"></a>
+<span class="sourceLineNo">224</span> final HRegion region = initHRegion(tableName, null, null, dodgyWAL);<a name="line.224"></a>
+<span class="sourceLineNo">225</span> byte [] bytes = Bytes.toBytes(getName());<a name="line.225"></a>
+<span class="sourceLineNo">226</span> NavigableMap<byte[], Integer> scopes = new TreeMap<>(<a name="line.226"></a>
+<span class="sourceLineNo">227</span> Bytes.BYTES_COMPARATOR);<a name="line.227"></a>
+<span class="sourceLineNo">228</span> scopes.put(COLUMN_FAMILY_BYTES, 0);<a name="line.228"></a>
+<span class="sourceLineNo">229</span> MultiVersionConcurrencyControl mvcc = new MultiVersionConcurrencyControl();<a name="line.229"></a>
+<span class="sourceLineNo">230</span> try {<a name="line.230"></a>
+<span class="sourceLineNo">231</span> // First get something into memstore. Make a Put and then pull the Cell out of it. Will<a name="line.231"></a>
+<span class="sourceLineNo">232</span> // manage append and sync carefully in below to manufacture hang. We keep adding same<a name="line.232"></a>
+<span class="sourceLineNo">233</span> // edit. WAL subsystem doesn't care.<a name="line.233"></a>
+<span class="sourceLineNo">234</span> Put put = new Put(bytes);<a name="line.234"></a>
+<span class="sourceLineNo">235</span> put.addColumn(COLUMN_FAMILY_BYTES, Bytes.toBytes("1"), bytes);<a name="line.235"></a>
+<span class="sourceLineNo">236</span> WALKeyImpl key = new WALKeyImpl(region.getRegionInfo().getEncodedNameAsBytes(),<a name="line.236"></a>
+<span class="sourceLineNo">237</span> TableName.META_TABLE_NAME, System.currentTimeMillis(), mvcc, scopes);<a name="line.237"></a>
+<span class="sourceLineNo">238</span> WALEdit edit = new WALEdit();<a name="line.238"></a>
+<span class="sourceLineNo">239</span> CellScanner CellScanner = put.cellScanner();<a name="line.239"></a>
+<span class="sourceLineNo">240</span> assertTrue(CellScanner.advance());<a name="line.240"></a>
+<span class="sourceLineNo">241</span> edit.add(CellScanner.current());<a name="line.241"></a>
+<span class="sourceLineNo">242</span> // Put something in memstore and out in the WAL. Do a big number of appends so we push<a name="line.242"></a>
+<span class="sourceLineNo">243</span> // out other side of the ringbuffer. If small numbers, stuff doesn't make it to WAL<a name="line.243"></a>
+<span class="sourceLineNo">244</span> for (int i = 0; i < 1000; i++) {<a name="line.244"></a>
+<span class="sourceLineNo">245</span> region.put(put);<a name="line.245"></a>
+<span class="sourceLineNo">246</span> }<a name="line.246"></a>
+<span class="sourceLineNo">247</span> // Set it so we start throwing exceptions.<a name="line.247"></a>
+<span class="sourceLineNo">248</span> LOG.info("SET throwing of exception on append");<a name="line.248"></a>
+<span class="sourceLineNo">249</span> dodgyWAL.throwException = true;<a name="line.249"></a>
+<span class="sourceLineNo">250</span> // This append provokes a WAL roll request<a name="line.250"></a>
+<span class="sourceLineNo">251</span> dodgyWAL.append(region.getRegionInfo(), key, edit, true);<a name="line.251"></a>
+<span class="sourceLineNo">252</span> boolean exception = false;<a name="line.252"></a>
+<span class="sourceLineNo">253</span> try {<a name="line.253"></a>
+<span class="sourceLineNo">254</span> dodgyWAL.sync();<a name="line.254"></a>
+<span class="sourceLineNo">255</span> } catch (Exception e) {<a name="line.255"></a>
+<span class="sourceLineNo">256</span> exception = true;<a name="line.256"></a>
+<span class="sourceLineNo">257</span> }<a name="line.257"></a>
+<span class="sourceLineNo">258</span> assertTrue("Did not get sync exception", exception);<a name="line.258"></a>
+<span class="sourceLineNo">259</span><a name="line.259"></a>
+<span class="sourceLineNo">260</span> // Get a memstore flush going too so we have same hung profile as up in the issue over<a name="line.260"></a>
+<span class="sourceLineNo">261</span> // in HBASE-14317. Flush hangs trying to get sequenceid because the ringbuffer is held up<a name="line.261"></a>
+<span class="sourceLineNo">262</span> // by the zigzaglatch waiting on syncs to come home.<a name="line.262"></a>
+<span class="sourceLineNo">263</span> Thread t = new Thread ("Flusher") {<a name="line.263"></a>
+<span class="sourceLineNo">264</span> @Override<a name="line.264"></a>
+<span class="sourceLineNo">265</span> public void run() {<a name="line.265"></a>
+<span class="sourceLineNo">266</span> try {<a name="line.266"></a>
+<span class="sourceLineNo">267</span> if (region.getMemStoreSize() <= 0) {<a name="line.267"></a>
+<span class="sourceLineNo">268</span> throw new IOException("memstore size=" + region.getMemStoreSize());<a name="line.268"></a>
+<span class="sourceLineNo">269</span> }<a name="line.269"></a>
+<span class="sourceLineNo">270</span> region.flush(false);<a name="line.270"></a>
+<span class="sourceLineNo">271</span> } catch (IOException e) {<a name="line.271"></a>
+<span class="sourceLineNo">272</span> // Can fail trying to flush in middle of a roll. Not a failure. Will succeed later<a name="line.272"></a>
+<span class="sourceLineNo">273</span> // when roll completes.<a name="line.273"></a>
+<span class="sourceLineNo">274</span> LOG.info("In flush", e);<a name="line.274"></a>
+<span class="sourceLineNo">275</span> }<a name="line.275"></a>
+<span class="sourceLineNo">276</span> LOG.info("Exiting");<a name="line.276"></a>
+<span class="sourceLineNo">277</span> }<a name="line.277"></a>
+<span class="sourceLineNo">278</span> };<a name="line.278"></a>
+<span class="sourceLineNo">279</span> t.setDaemon(true);<a name="line.279"></a>
+<span class="sourceLineNo">280</span> t.start();<a name="line.280"></a>
+<span class="sourceLineNo">281</span> // Wait until<a name="line.281"></a>
+<span class="sourceLineNo">282</span> while (dodgyWAL.latch.getCount() > 0) {<a name="line.282"></a>
+<span class="sourceLineNo">283</span> Threads.sleep(1);<a name="line.283"></a>
+<span class="sourceLineNo">284</span> }<a name="line.284"></a>
<span class="sourceLineNo">285</span> // Now assert I got a new WAL file put in place even though loads of errors above.<a name="line.285"></a>
<span class="sourceLineNo">286</span> assertTrue(originalWAL != dodgyWAL.getCurrentFileName());<a name="line.286"></a>
<span class="sourceLineNo">287</span> // Can I append to it?<a name="line.287"></a>
@@ -302,328 +302,138 @@
<span class="sourceLineNo">294</span> } finally {<a name="line.294"></a>
<span class="sourceLineNo">295</span> // To stop logRoller, its server has to say it is stopped.<a name="line.295"></a>
<span class="sourceLineNo">296</span> Mockito.when(server.isStopped()).thenReturn(true);<a name="line.296"></a>
-<span class="sourceLineNo">297</span> if (logRoller != null) logRoller.close();<a name="line.297"></a>
+<span class="sourceLineNo">297</span> Closeables.close(logRoller, true);<a name="line.297"></a>
<span class="sourceLineNo">298</span> try {<a name="line.298"></a>
-<span class="sourceLineNo">299</span> if (region != null) region.close();<a name="line.299"></a>
-<span class="sourceLineNo">300</span> if (dodgyWAL != null) dodgyWAL.close();<a name="line.300"></a>
-<span class="sourceLineNo">301</span> } catch (Exception e) {<a name="line.301"></a>
-<span class="sourceLineNo">302</span> LOG.info("On way out", e);<a name="line.302"></a>
-<span class="sourceLineNo">303</span> }<a name="line.303"></a>
-<span class="sourceLineNo">304</span> }<a name="line.304"></a>
-<span class="sourceLineNo">305</span> }<a name="line.305"></a>
-<span class="sourceLineNo">306</span><a name="line.306"></a>
-<span class="sourceLineNo">307</span> /**<a name="line.307"></a>
-<span class="sourceLineNo">308</span> * Reproduce locking up that happens when there's no further syncs after<a name="line.308"></a>
-<span class="sourceLineNo">309</span> * append fails, and causing an isolated sync then infinite wait. See<a name="line.309"></a>
-<span class="sourceLineNo">310</span> * HBASE-16960. If below is broken, we will see this test timeout because it<a name="line.310"></a>
-<span class="sourceLineNo">311</span> * is locked up.<a name="line.311"></a>
-<span class="sourceLineNo">312</span> * <p/><a name="line.312"></a>
-<span class="sourceLineNo">313</span> * Steps for reproduce:<br/><a name="line.313"></a>
-<span class="sourceLineNo">314</span> * 1. Trigger server abort through dodgyWAL1<br/><a name="line.314"></a>
-<span class="sourceLineNo">315</span> * 2. Add a {@link DummyWALActionsListener} to dodgyWAL2 to cause ringbuffer<a name="line.315"></a>
-<span class="sourceLineNo">316</span> * event handler thread sleep for a while thus keeping {@code endOfBatch}<a name="line.316"></a>
-<span class="sourceLineNo">317</span> * false<br/><a name="line.317"></a>
-<span class="sourceLineNo">318</span> * 3. Publish a sync then an append which will throw exception, check whether<a name="line.318"></a>
-<span class="sourceLineNo">319</span> * the sync could return<a name="line.319"></a>
-<span class="sourceLineNo">320</span> */<a name="line.320"></a>
-<span class="sourceLineNo">321</span> @Test(timeout = 20000)<a name="line.321"></a>
-<span class="sourceLineNo">322</span> public void testLockup16960() throws IOException {<a name="line.322"></a>
-<span class="sourceLineNo">323</span> // A WAL that we can have throw exceptions when a flag is set.<a name="line.323"></a>
-<span class="sourceLineNo">324</span> class DodgyFSLog extends FSHLog {<a name="line.324"></a>
-<span class="sourceLineNo">325</span> // Set this when want the WAL to start throwing exceptions.<a name="line.325"></a>
-<span class="sourceLineNo">326</span> volatile boolean throwException = false;<a name="line.326"></a>
-<span class="sourceLineNo">327</span><a name="line.327"></a>
-<span class="sourceLineNo">328</span> public DodgyFSLog(FileSystem fs, Path root, String logDir,<a name="line.328"></a>
-<span class="sourceLineNo">329</span> Configuration conf) throws IOException {<a name="line.329"></a>
-<span class="sourceLineNo">330</span> super(fs, root, logDir, conf);<a name="line.330"></a>
-<span class="sourceLineNo">331</span> }<a name="line.331"></a>
-<span class="sourceLineNo">332</span><a name="line.332"></a>
-<span class="sourceLineNo">333</span> @Override<a name="line.333"></a>
-<span class="sourceLineNo">334</span> protected Writer createWriterInstance(Path path) throws IOException {<a name="line.334"></a>
-<span class="sourceLineNo">335</span> final Writer w = super.createWriterInstance(path);<a name="line.335"></a>
-<span class="sourceLineNo">336</span> return new Writer() {<a name="line.336"></a>
-<span class="sourceLineNo">337</span> @Override<a name="line.337"></a>
-<span class="sourceLineNo">338</span> public void close() throws IOException {<a name="line.338"></a>
-<span class="sourceLineNo">339</span> w.close();<a name="line.339"></a>
-<span class="sourceLineNo">340</span> }<a name="line.340"></a>
-<span class="sourceLineNo">341</span><a name="line.341"></a>
-<span class="sourceLineNo">342</span> @Override<a name="line.342"></a>
-<span class="sourceLineNo">343</span> public void sync() throws IOException {<a name="line.343"></a>
-<span class="sourceLineNo">344</span> if (throwException) {<a name="line.344"></a>
-<span class="sourceLineNo">345</span> throw new IOException(<a name="line.345"></a>
-<span class="sourceLineNo">346</span> "FAKE! Failed to replace a bad datanode...SYNC");<a name="line.346"></a>
-<span class="sourceLineNo">347</span> }<a name="line.347"></a>
-<span class="sourceLineNo">348</span> w.sync();<a name="line.348"></a>
-<span class="sourceLineNo">349</span> }<a name="line.349"></a>
+<span class="sourceLineNo">299</span> if (region != null) {<a name="line.299"></a>
+<span class="sourceLineNo">300</span> region.close();<a name="line.300"></a>
+<span class="sourceLineNo">301</span> }<a name="line.301"></a>
+<span class="sourceLineNo">302</span> if (dodgyWAL != null) {<a name="line.302"></a>
+<span class="sourceLineNo">303</span> dodgyWAL.close();<a name="line.303"></a>
+<span class="sourceLineNo">304</span> }<a name="line.304"></a>
+<span class="sourceLineNo">305</span> } catch (Exception e) {<a name="line.305"></a>
+<span class="sourceLineNo">306</span> LOG.info("On way out", e);<a name="line.306"></a>
+<span class="sourceLineNo">307</span> }<a name="line.307"></a>
+<span class="sourceLineNo">308</span> }<a name="line.308"></a>
+<span class="sourceLineNo">309</span> }<a name="line.309"></a>
+<span class="sourceLineNo">310</span><a name="line.310"></a>
+<span class="sourceLineNo">311</span> static class DummyServer implements Server {<a name="line.311"></a>
+<span class="sourceLineNo">312</span> private Configuration conf;<a name="line.312"></a>
+<span class="sourceLineNo">313</span> private String serverName;<a name="line.313"></a>
+<span class="sourceLineNo">314</span> private boolean isAborted = false;<a name="line.314"></a>
+<span class="sourceLineNo">315</span><a name="line.315"></a>
+<span class="sourceLineNo">316</span> public DummyServer(Configuration conf, String serverName) {<a name="line.316"></a>
+<span class="sourceLineNo">317</span> this.conf = conf;<a name="line.317"></a>
+<span class="sourceLineNo">318</span> this.serverName = serverName;<a name="line.318"></a>
+<span class="sourceLineNo">319</span> }<a name="line.319"></a>
+<span class="sourceLineNo">320</span><a name="line.320"></a>
+<span class="sourceLineNo">321</span> @Override<a name="line.321"></a>
+<span class="sourceLineNo">322</span> public Configuration getConfiguration() {<a name="line.322"></a>
+<span class="sourceLineNo">323</span> return conf;<a name="line.323"></a>
+<span class="sourceLineNo">324</span> }<a name="line.324"></a>
+<span class="sourceLineNo">325</span><a name="line.325"></a>
+<span class="sourceLineNo">326</span> @Override<a name="line.326"></a>
+<span class="sourceLineNo">327</span> public ZKWatcher getZooKeeper() {<a name="line.327"></a>
+<span class="sourceLineNo">328</span> return null;<a name="line.328"></a>
+<span class="sourceLineNo">329</span> }<a name="line.329"></a>
+<span class="sourceLineNo">330</span><a name="line.330"></a>
+<span class="sourceLineNo">331</span> @Override<a name="line.331"></a>
+<span class="sourceLineNo">332</span> public CoordinatedStateManager getCoordinatedStateManager() {<a name="line.332"></a>
+<span class="sourceLineNo">333</span> return null;<a name="line.333"></a>
+<span class="sourceLineNo">334</span> }<a name="line.334"></a>
+<span class="sourceLineNo">335</span><a name="line.335"></a>
+<span class="sourceLineNo">336</span> @Override<a name="line.336"></a>
+<span class="sourceLineNo">337</span> public ClusterConnection getConnection() {<a name="line.337"></a>
+<span class="sourceLineNo">338</span> return null;<a name="line.338"></a>
+<span class="sourceLineNo">339</span> }<a name="line.339"></a>
+<span class="sourceLineNo">340</span><a name="line.340"></a>
+<span class="sourceLineNo">341</span> @Override<a name="line.341"></a>
+<span class="sourceLineNo">342</span> public MetaTableLocator getMetaTableLocator() {<a name="line.342"></a>
+<span class="sourceLineNo">343</span> return null;<a name="line.343"></a>
+<span class="sourceLineNo">344</span> }<a name="line.344"></a>
+<span class="sourceLineNo">345</span><a name="line.345"></a>
+<span class="sourceLineNo">346</span> @Override<a name="line.346"></a>
+<span class="sourceLineNo">347</span> public ServerName getServerName() {<a name="line.347"></a>
+<span class="sourceLineNo">348</span> return ServerName.valueOf(this.serverName);<a name="line.348"></a>
+<span class="sourceLineNo">349</span> }<a name="line.349"></a>
<span class="sourceLineNo">350</span><a name="line.350"></a>
-<span class="sourceLineNo">351</span> @Override<a name="line.351"></a>
-<span class="sourceLineNo">352</span> public void append(Entry entry) throws IOException {<a name="line.352"></a>
-<span class="sourceLineNo">353</span> if (throwException) {<a name="line.353"></a>
-<span class="sourceLineNo">354</span> throw new IOException(<a name="line.354"></a>
-<span class="sourceLineNo">355</span> "FAKE! Failed to replace a bad datanode...APPEND");<a name="line.355"></a>
-<span class="sourceLineNo">356</span> }<a name="line.356"></a>
-<span class="sourceLineNo">357</span> w.append(entry);<a name="line.357"></a>
-<span class="sourceLineNo">358</span> }<a name="line.358"></a>
-<span class="sourceLineNo">359</span><a name="line.359"></a>
-<span class="sourceLineNo">360</span> @Override<a name="line.360"></a>
-<span class="sourceLineNo">361</span> public long getLength() {<a name="line.361"></a>
-<span class="sourceLineNo">362</span> return w.getLength();<a name="line.362"></a>
-<span class="sourceLineNo">363</span> }<a name="line.363"></a>
-<span class="sourceLineNo">364</span> };<a name="line.364"></a>
-<span class="sourceLineNo">365</span> }<a name="line.365"></a>
+<span class="sourceLineNo">351</span> @Override<a name="line.351"></a>
+<span class="sourceLineNo">352</span> public void abort(String why, Throwable e) {<a name="line.352"></a>
+<span class="sourceLineNo">353</span> LOG.info("Aborting " + serverName);<a name="line.353"></a>
+<span class="sourceLineNo">354</span> this.isAborted = true;<a name="line.354"></a>
+<span class="sourceLineNo">355</span> }<a name="line.355"></a>
+<span class="sourceLineNo">356</span><a name="line.356"></a>
+<span class="sourceLineNo">357</span> @Override<a name="line.357"></a>
+<span class="sourceLineNo">358</span> public boolean isAborted() {<a name="line.358"></a>
+<span class="sourceLineNo">359</span> return this.isAborted;<a name="line.359"></a>
+<span class="sourceLineNo">360</span> }<a name="line.360"></a>
+<span class="sourceLineNo">361</span><a name="line.361"></a>
+<span class="sourceLineNo">362</span> @Override<a name="line.362"></a>
+<span class="sourceLineNo">363</span> public void stop(String why) {<a name="line.363"></a>
+<span class="sourceLineNo">364</span> this.isAborted = true;<a name="line.364"></a>
+<span class="sourceLineNo">365</span> }<a name="line.365"></a>
<span class="sourceLineNo">366</span><a name="line.366"></a>
-<span class="sourceLineNo">367</span> @Override<a name="line.367"></a>
-<span class="sourceLineNo">368</span> protected long doReplaceWriter(Path oldPath, Path newPath,<a name="line.368"></a>
-<span class="sourceLineNo">369</span> Writer nextWriter) throws IOException {<a name="line.369"></a>
-<span class="sourceLineNo">370</span> if (throwException) {<a name="line.370"></a>
-<span class="sourceLineNo">371</span> throw new FailedLogCloseException("oldPath=" + oldPath + ", newPath="<a name="line.371"></a>
-<span class="sourceLineNo">372</span> + newPath);<a name="line.372"></a>
-<span class="sourceLineNo">373</span> }<a name="line.373"></a>
-<span class="sourceLineNo">374</span> long oldFileLen = 0L;<a name="line.374"></a>
-<span class="sourceLineNo">375</span> oldFileLen = super.doReplaceWriter(oldPath, newPath, nextWriter);<a name="line.375"></a>
-<span class="sourceLineNo">376</span> return oldFileLen;<a name="line.376"></a>
-<span class="sourceLineNo">377</span> }<a name="line.377"></a>
-<span class="sourceLineNo">378</span> }<a name="line.378"></a>
-<span class="sourceLineNo">379</span><a name="line.379"></a>
-<span class="sourceLineNo">380</span> // Mocked up server and regionserver services. Needed below.<a name="line.380"></a>
-<span class="sourceLineNo">381</span> Server server = new DummyServer(CONF, ServerName.valueOf(<a name="line.381"></a>
-<span class="sourceLineNo">382</span> "hostname1.example.org", 1234, 1L).toString());<a name="line.382"></a>
-<span class="sourceLineNo">383</span> RegionServerServices services = Mockito.mock(RegionServerServices.class);<a name="line.383"></a>
-<span class="sourceLineNo">384</span><a name="line.384"></a>
-<span class="sourceLineNo">385</span> CONF.setLong("hbase.regionserver.hlog.sync.timeout", 10000);<a name="line.385"></a>
+<span class="sourceLineNo">367</span> @Override<a name="line.367"></a>
+<span class="sourceLineNo">368</span> public boolean isStopped() {<a name="line.368"></a>
+<span class="sourceLineNo">369</span> return this.isAborted;<a name="line.369"></a>
+<span class="sourceLineNo">370</span> }<a name="line.370"></a>
+<span class="sourceLineNo">371</span><a name="line.371"></a>
+<span class="sourceLineNo">372</span> @Override<a name="line.372"></a>
+<span class="sourceLineNo">373</span> public ChoreService getChoreService() {<a name="line.373"></a>
+<span class="sourceLineNo">374</span> return null;<a name="line.374"></a>
+<span class="sourceLineNo">375</span> }<a name="line.375"></a>
+<span class="sourceLineNo">376</span><a name="line.376"></a>
+<span class="sourceLineNo">377</span> @Override<a name="line.377"></a>
+<span class="sourceLineNo">378</span> public ClusterConnection getClusterConnection() {<a name="line.378"></a>
+<span class="sourceLineNo">379</span> return null;<a name="line.379"></a>
+<span class="sourceLineNo">380</span> }<a name="line.380"></a>
+<span class="sourceLineNo">381</span><a name="line.381"></a>
+<span class="sourceLineNo">382</span> @Override<a name="line.382"></a>
+<span class="sourceLineNo">383</span> public FileSystem getFileSystem() {<a name="line.383"></a>
+<span class="sourceLineNo">384</span> return null;<a name="line.384"></a>
+<span class="sourceLineNo">385</span> }<a name="line.385"></a>
<span class="sourceLineNo">386</span><a name="line.386"></a>
-<span class="sourceLineNo">387</span> // OK. Now I have my mocked up Server & RegionServerServices and dodgy WAL,<a name="line.387"></a>
-<span class="sourceLineNo">388</span> // go ahead with test.<a name="line.388"></a>
-<span class="sourceLineNo">389</span> FileSystem fs = FileSystem.get(CONF);<a name="line.389"></a>
-<span class="sourceLineNo">390</span> Path rootDir = new Path(dir + getName());<a name="line.390"></a>
-<span class="sourceLineNo">391</span> DodgyFSLog dodgyWAL1 = new DodgyFSLog(fs, rootDir, getName(), CONF);<a name="line.391"></a>
-<span class="sourceLineNo">392</span><a name="line.392"></a>
-<span class="sourceLineNo">393</span> Path rootDir2 = new Path(dir + getName() + "2");<a name="line.393"></a>
-<span class="sourceLineNo">394</span> final DodgyFSLog dodgyWAL2 = new DodgyFSLog(fs, rootDir2, getName() + "2",<a name="line.394"></a>
-<span class="sourceLineNo">395</span> CONF);<a name="line.395"></a>
-<span class="sourceLineNo">396</span> // Add a listener to force ringbuffer event handler sleep for a while<a name="line.396"></a>
-<span class="sourceLineNo">397</span> dodgyWAL2.registerWALActionsListener(new DummyWALActionsListener());<a name="line.397"></a>
-<span class="sourceLineNo">398</span><a name="line.398"></a>
-<span class="sourceLineNo">399</span> // I need a log roller running.<a name="line.399"></a>
-<span class="sourceLineNo">400</span> LogRoller logRoller = new LogRoller(server, services);<a name="line.400"></a>
-<span class="sourceLineNo">401</span> logRoller.addWAL(dodgyWAL1);<a name="line.401"></a>
-<span class="sourceLineNo">402</span> logRoller.addWAL(dodgyWAL2);<a name="line.402"></a>
-<span class="sourceLineNo">403</span> // There is no 'stop' once a logRoller is running.. it just dies.<a name="line.403"></a>
-<span class="sourceLineNo">404</span> logRoller.start();<a name="line.404"></a>
-<span class="sourceLineNo">405</span> // Now get a region and start adding in edits.<a name="line.405"></a>
-<span class="sourceLineNo">406</span> HTableDescriptor htd = new HTableDescriptor(TableName.META_TABLE_NAME);<a name="line.406"></a>
-<span class="sourceLineNo">407</span> final HRegion region = initHRegion(tableName, null, null, dodgyWAL1);<a name="line.407"></a>
-<span class="sourceLineNo">408</span> byte[] bytes = Bytes.toBytes(getName());<a name="line.408"></a>
-<span class="sourceLineNo">409</span> NavigableMap<byte[], Integer> scopes = new TreeMap<>(<a name="line.409"></a>
-<span class="sourceLineNo">410</span> Bytes.BYTES_COMPARATOR);<a name="line.410"></a>
-<span class="sourceLineNo">411</span> scopes.put(COLUMN_FAMILY_BYTES, 0);<a name="line.411"></a>
-<span class="sourceLineNo">412</span> MultiVersionConcurrencyControl mvcc = new MultiVersionConcurrencyControl();<a name="line.412"></a>
-<span class="sourceLineNo">413</span> try {<a name="line.413"></a>
-<span class="sourceLineNo">414</span> Put put = new Put(bytes);<a name="line.414"></a>
-<span class="sourceLineNo">415</span> put.addColumn(COLUMN_FAMILY_BYTES, Bytes.toBytes("1"), bytes);<a name="line.415"></a>
-<span class="sourceLineNo">416</span> WALKeyImpl key = new WALKeyImpl(region.getRegionInfo().getEncodedNameAsBytes(),<a name="line.416"></a>
-<span class="sourceLineNo">417</span> htd.getTableName(), System.currentTimeMillis(), mvcc, scopes);<a name="line.417"></a>
-<span class="sourceLineNo">418</span> WALEdit edit = new WALEdit();<a name="line.418"></a>
-<span class="sourceLineNo">419</span> CellScanner CellScanner = put.cellScanner();<a name="line.419"></a>
-<span class="sourceLineNo">420</span> assertTrue(CellScanner.advance());<a name="line.420"></a>
-<span class="sourceLineNo">421</span> edit.add(CellScanner.current());<a name="line.421"></a>
-<span class="sourceLineNo">422</span><a name="line.422"></a>
-<span class="sourceLineNo">423</span> LOG.info("SET throwing of exception on append");<a name="line.423"></a>
-<span class="sourceLineNo">424</span> dodgyWAL1.throwException = true;<a name="line.424"></a>
-<span class="sourceLineNo">425</span> // This append provokes a WAL roll request<a name="line.425"></a>
-<span class="sourceLineNo">426</span> dodgyWAL1.append(region.getRegionInfo(), key, edit, true);<a name="line.426"></a>
-<span class="sourceLineNo">427</span> boolean exception = false;<a name="line.427"></a>
-<span class="sourceLineNo">428</span> try {<a name="line.428"></a>
-<span class="sourceLineNo">429</span> dodgyWAL1.sync();<a name="line.429"></a>
-<span class="sourceLineNo">430</span> } catch (Exception e) {<a name="line.430"></a>
-<span class="sourceLineNo">431</span> exception = true;<a name="line.431"></a>
-<span class="sourceLineNo">432</span> }<a name="line.432"></a>
-<span class="sourceLineNo">433</span> assertTrue("Did not get sync exception", exception);<a name="line.433"></a>
-<span class="sourceLineNo">434</span><a name="line.434"></a>
-<span class="sourceLineNo">435</span> // LogRoller call dodgyWAL1.rollWriter get FailedLogCloseException and<a name="line.435"></a>
-<span class="sourceLineNo">436</span> // cause server abort.<a name="line.436"></a>
-<span class="sourceLineNo">437</span> try {<a name="line.437"></a>
-<span class="sourceLineNo">438</span> // wait LogRoller exit.<a name="line.438"></a>
-<span class="sourceLineNo">439</span> Thread.sleep(50);<a name="line.439"></a>
-<span class="sourceLineNo">440</span> } catch (InterruptedException e) {<a name="line.440"></a>
-<span class="sourceLineNo">441</span> e.printStackTrace();<a name="line.441"></a>
-<span class="sourceLineNo">442</span> }<a name="line.442"></a>
-<span class="sourceLineNo">443</span><a name="line.443"></a>
-<span class="sourceLineNo">444</span> final CountDownLatch latch = new CountDownLatch(1);<a name="line.444"></a>
-<span class="sourceLineNo">445</span><a name="line.445"></a>
-<span class="sourceLineNo">446</span> // make RingBufferEventHandler sleep 1s, so the following sync<a name="line.446"></a>
-<span class="sourceLineNo">447</span> // endOfBatch=false<a name="line.447"></a>
-<span class="sourceLineNo">448</span> key = new WALKeyImpl(region.getRegionInfo().getEncodedNameAsBytes(),<a name="line.448"></a>
-<span class="sourceLineNo">449</span> TableName.valueOf("sleep"), System.currentTimeMillis(), mvcc, scopes);<a name="line.449"></a>
-<span class="sourceLineNo">450</span> dodgyWAL2.append(region.getRegionInfo(), key, edit, true);<a name="line.450"></a>
-<span class="sourceLineNo">451</span><a name="line.451"></a>
-<span class="sourceLineNo">452</span> Thread t = new Thread("Sync") {<a name="line.452"></a>
-<span class="sourceLineNo">453</span> @Override<a name="line.453"></a>
-<span class="sourceLineNo">454</span> public void run() {<a name="line.454"></a>
-<span class="sourceLineNo">455</span> try {<a name="line.455"></a>
-<span class="sourceLineNo">456</span> dodgyWAL2.sync();<a name="line.456"></a>
-<span class="sourceLineNo">457</span> } catch (IOException e) {<a name="line.457"></a>
-<span class="sourceLineNo">458</span> LOG.info("In sync", e);<a name="line.458"></a>
-<span class="sourceLineNo">459</span> }<a name="line.459"></a>
-<span class="sourceLineNo">460</span> latch.countDown();<a name="line.460"></a>
-<span class="sourceLineNo">461</span> LOG.info("Sync exiting");<a name="line.461"></a>
-<span class="sourceLineNo">462</span> }<a name="line.462"></a>
-<span class="sourceLineNo">463</span> };<a name="line.463"></a>
-<span class="sourceLineNo">464</span> t.setDaemon(true);<a name="line.464"></a>
-<span class="sourceLineNo">465</span> t.start();<a name="line.465"></a>
-<span class="sourceLineNo">466</span> try {<a name="line.466"></a>
-<span class="sourceLineNo">467</span> // make sure sync have published.<a name="line.467"></a>
-<span class="sourceLineNo">468</span> Thread.sleep(100);<a name="line.468"></a>
-<span class="sourceLineNo">469</span> } catch (InterruptedException e1) {<a name="line.469"></a>
-<span class="sourceLineNo">470</span> e1.printStackTrace();<a name="line.470"></a>
-<span class="sourceLineNo">471</span> }<a name="line.471"></a>
-<span class="sourceLineNo">472</span> // make append throw DamagedWALException<a name="line.472"></a>
-<span class="sourceLineNo">473</span> key = new WALKeyImpl(region.getRegionInfo().getEncodedNameAsBytes(),<a name="line.473"></a>
-<span class="sourceLineNo">474</span> TableName.valueOf("DamagedWALException"), System.currentTimeMillis(), mvcc, scopes);<a name="line.474"></a>
-<span class="sourceLineNo">475</span> dodgyWAL2.append(region.getRegionInfo(), key, edit, true);<a name="line.475"></a>
-<span class="sourceLineNo">476</span><a name="line.476"></a>
-<span class="sourceLineNo">477</span> while (latch.getCount() > 0) {<a name="line.477"></a>
-<span class="sourceLineNo">478</span> Threads.sleep(100);<a name="line.478"></a>
-<span class="sourceLineNo">479</span> }<a name="line.479"></a>
-<span class="sourceLineNo">480</span> assertTrue(server.isAborted());<a name="line.480"></a>
-<span class="sourceLineNo">481</span> } finally {<a name="line.481"></a>
-<span class="sourceLineNo">482</span> if (logRoller != null) {<a name="line.482"></a>
-<span class="sourceLineNo">483</span> logRoller.close();<a name="line.483"></a>
-<span class="sourceLineNo">484</span> }<a name="line.484"></a>
-<span class="sourceLineNo">485</span> try {<a name="line.485"></a>
-<span class="sourceLineNo">486</span> if (region != null) {<a name="line.486"></a>
-<span class="sourceLineNo">487</span> region.close();<a name="line.487"></a>
-<span class="sourceLineNo">488</span> }<a name="line.488"></a>
-<span class="sourceLineNo">489</span> if (dodgyWAL1 != null) {<a name="line.489"></a>
-<span class="sourceLineNo">490</span> dodgyWAL1.close();<a name="line.490"></a>
-<span class="sourceLineNo">491</span> }<a name="line.491"></a>
-<span class="sourceLineNo">492</span> if (dodgyWAL2 != null) {<a name="line.492"></a>
-<span class="sourceLineNo">493</span> dodgyWAL2.close();<a name="line.493"></a>
-<span class="sourceLineNo">494</span> }<a name="line.494"></a>
-<span class="sourceLineNo">495</span> } catch (Exception e) {<a name="line.495"></a>
-<span class="sourceLineNo">496</span> LOG.info("On way out", e);<a name="line.496"></a>
-<span class="sourceLineNo">497</span> }<a name="line.497"></a>
-<span class="sourceLineNo">498</span> }<a name="line.498"></a>
-<span class="sourceLineNo">499</span> }<a name="line.499"></a>
-<span class="sourceLineNo">500</span><a name="line.500"></a>
-<span class="sourceLineNo">501</span> static class DummyServer implements Server {<a name="line.501"></a>
-<span class="sourceLineNo">502</span> private Configuration conf;<a name="line.502"></a>
-<span class="sourceLineNo">503</span> private String serverName;<a name="line.503"></a>
-<span class="sourceLineNo">504</span> private boolean isAborted = false;<a name="line.504"></a>
-<span class="sourceLineNo">505</span><a name="line.505"></a>
-<span class="sourceLineNo">506</span> public DummyServer(Configuration conf, String serverName) {<a name="line.506"></a>
-<span class="sourceLineNo">507</span> this.conf = conf;<a name="line.507"></a>
-<span class="sourceLineNo">508</span> this.serverName = serverName;<a name="line.508"></a>
-<span class="sourceLineNo">509</span> }<a name="line.509"></a>
-<span class="sourceLineNo">510</span><a name="line.510"></a>
-<span class="sourceLineNo">511</span> @Override<a name="line.511"></a>
-<span class="sourceLineNo">512</span> public Configuration getConfiguration() {<a name="line.512"></a>
-<span class="sourceLineNo">513</span> return conf;<a name="line.513"></a>
-<span class="sourceLineNo">514</span> }<a name="line.514"></a>
-<span class="sourceLineNo">515</span><a name="line.515"></a>
-<span class="sourceLineNo">516</span> @Override<a name="line.516"></a>
-<span class="sourceLineNo">517</span> public ZKWatcher getZooKeeper() {<a name="line.517"></a>
-<span class="sourceLineNo">518</span> return null;<a name="line.518"></a>
-<span class="sourceLineNo">519</span> }<a name="line.519"></a>
-<span class="sourceLineNo">520</span><a name="line.520"></a>
-<span class="sourceLineNo">521</span> @Override<a name="line.521"></a>
-<span class="sourceLineNo">522</span> public CoordinatedStateManager getCoordinatedStateManager() {<a name="line.522"></a>
-<span class="sourceLineNo">523</span> return null;<a name="line.523"></a>
-<span class="sourceLineNo">524</span> }<a name="line.524"></a>
-<span class="sourceLineNo">525</span><a name="line.525"></a>
-<span class="sourceLineNo">526</span> @Override<a name="line.526"></a>
-<span class="sourceLineNo">527</span> public ClusterConnection getConnection() {<a name="line.527"></a>
-<span class="sourceLineNo">528</span> return null;<a name="line.528"></a>
-<span class="sourceLineNo">529</span> }<a name="line.529"></a>
-<span class="sourceLineNo">530</span><a name="line.530"></a>
-<span class="sourceLineNo">531</span> @Override<a name="line.531"></a>
-<span class="sourceLineNo">532</span> public MetaTableLocator getMetaTableLocator() {<a name="line.532"></a>
-<span class="sourceLineNo">533</span> return null;<a name="line.533"></a>
-<span class="sourceLineNo">534</span> }<a name="line.534"></a>
-<span class="sourceLineNo">535</span><a name="line.535"></a>
-<span class="sourceLineNo">536</span> @Override<a name="line.536"></a>
-<span class="sourceLineNo">537</span> public ServerName getServerName() {<a name="line.537"></a>
-<span class="sourceLineNo">538</span> return ServerName.valueOf(this.serverName);<a name="line.538"></a>
-<span class="sourceLineNo">539</span> }<a name="line.539"></a>
-<span class="sourceLineNo">540</span><a name="line.540"></a>
-<span class="sourceLineNo">541</span> @Override<a name="line.541"></a>
-<span class="sourceLineNo">542</span> public void abort(String why, Throwable e) {<a name="line.542"></a>
-<span class="sourceLineNo">543</span> LOG.info("Aborting " + serverName);<a name="line.543"></a>
-<span class="sourceLineNo">544</span> this.isAborted = true;<a name="line.544"></a>
-<span class="sourceLineNo">545</span> }<a name="line.545"></a>
-<span class="sourceLineNo">546</span><a name="line.546"></a>
-<span class="sourceLineNo">547</span> @Override<a name="line.547"></a>
-<span class="sourceLineNo">548</span> public boolean isAborted() {<a name="line.548"></a>
-<span class="sourceLineNo">549</span> return this.isAborted;<a name="line.549"></a>
-<span class="sourceLineNo">550</span> }<a name="line.550"></a>
-<span class="sourceLineNo">551</span><a name="line.551"></a>
-<span class="sourceLineNo">552</span> @Override<a name="line.552"></a>
-<span class="sourceLineNo">553</span> public void stop(String why) {<a name="line.553"></a>
-<span class="sourceLineNo">554</span> this.isAborted = true;<a name="line.554"></a>
-<span class="sourceLineNo">555</span> }<a name="line.555"></a>
-<span class="sourceLineNo">556</span><a name="line.556"></a>
-<span class="sourceLineNo">557</span> @Override<a name="line.557"></a>
-<span class="sourceLineNo">558</span> public boolean isStopped() {<a name="line.558"></a>
-<span class="sourceLineNo">559</span> return this.isAborted;<a name="line.559"></a>
-<span class="sourceLineNo">560</span> }<a name="line.560"></a>
-<span class="sourceLineNo">561</span><a name="line.561"></a>
-<span class="sourceLineNo">562</span> @Override<a name="line.562"></a>
-<span class="sourceLineNo">563</span> public ChoreService getChoreService() {<a name="line.563"></a>
-<span class="sourceLineNo">564</span> return null;<a name="line.564"></a>
-<span class="sourceLineNo">565</span> }<a name="line.565"></a>
-<span class="sourceLineNo">566</span><a name="line.566"></a>
-<span class="sourceLineNo">567</span> @Override<a name="line.567"></a>
-<span class="sourceLineNo">568</span> public ClusterConnection getClusterConnection() {<a name="line.568"></a>
-<span class="sourceLineNo">569</span> return null;<a name="line.569"></a>
-<span class="sourceLineNo">570</span> }<a name="line.570"></a>
-<span class="sourceLineNo">571</span><a name="line.571"></a>
-<span class="sourceLineNo">572</span> @Override<a name="line.572"></a>
-<span class="sourceLineNo">573</span> public FileSystem getFileSystem() {<a name="line.573"></a>
-<span class="sourceLineNo">574</span> return null;<a name="line.574"></a>
-<span class="sourceLineNo">575</span> }<a name="line.575"></a>
-<span class="sourceLineNo">576</span><a name="line.576"></a>
-<span class="sourceLineNo">577</span> @Override<a name="line.577"></a>
-<span class="sourceLineNo">578</span> public boolean isStopping() {<a name="line.578"></a>
-<span class="sourceLineNo">579</span> return false;<a name="line.579"></a>
-<span class="sourceLineNo">580</span> }<a name="line.580"></a>
-<span class="sourceLineNo">581</span><a name="line.581"></a>
-<span class="sourceLineNo">582</span> @Override<a name="line.582"></a>
-<span class="sourceLineNo">583</span> public Connection createConnection(Configuration conf) throws IOException {<a name="line.583"></a>
-<span class="sourceLineNo">584</span> return null;<a name="line.584"></a>
-<span class="sourceLineNo">585</span> }<a name="line.585"></a>
-<span class="sourceLineNo">586</span> }<a name="line.586"></a>
-<span class="sourceLineNo">587</span><a name="line.587"></a>
-<span class="sourceLineNo">588</span> static class DummyWALActionsListener implements WALActionsListener {<a name="line.588"></a>
-<span class="sourceLineNo">589</span><a name="line.589"></a>
-<span class="sourceLineNo">590</span> @Override<a name="line.590"></a>
-<span class="sourceLineNo">591</span> public void visitLogEntryBeforeWrite(WALKey logKey, WALEdit logEdit)<a name="line.591"></a>
-<span class="sourceLineNo">592</span> throws IOException {<a name="line.592"></a>
-<span class="sourceLineNo">593</span> if (logKey.getTableName().getNameAsString().equalsIgnoreCase("sleep")) {<a name="line.593"></a>
-<span class="sourceLineNo">594</span> try {<a name="line.594"></a>
-<span class="sourceLineNo">595</span> Thread.sleep(1000);<a name="line.595"></a>
-<span class="sourceLineNo">596</span> } catch (InterruptedException e) {<a name="line.596"></a>
-<span class="sourceLineNo">597</span> e.printStackTrace();<a name="line.597"></a>
-<span class="sourceLineNo">598</span> }<a name="line.598"></a>
-<span class="sourceLineNo">599</span> }<a name="line.599"></a>
-<span class="sourceLineNo">600</span> if (logKey.getTableName().getNameAsString()<a name="line.600"></a>
-<span class="sourceLineNo">601</span> .equalsIgnoreCase("DamagedWALException")) {<a name="line.601"></a>
-<span class="sourceLineNo">602</span> throw new DamagedWALException("Failed appending");<a name="line.602"></a>
-<span class="sourceLineNo">603</span> }<a name="line.603"></a>
-<span class="sourceLineNo">604</span> }<a name="line.604"></a>
-<span class="sourceLineNo">605</span><a name="line.605"></a>
-<span class="sourceLineNo">606</span> }<a name="line.606"></a>
-<span class="sourceLineNo">607</span><a name="line.607"></a>
-<span class="sourceLineNo">608</span> /**<a name="line.608"></a>
-<span class="sourceLineNo">609</span> * @return A region on which you must call<a name="line.609"></a>
-<span class="sourceLineNo">610</span> * {@link HBaseTestingUtility#closeRegionAndWAL(HRegion)} when done.<a name="line.610"></a>
-<span class="sourceLineNo">611</span> */<a name="line.611"></a>
-<span class="sourceLineNo">612</span> public static HRegion initHRegion(TableName tableName, byte[] startKey, byte[] stopKey, WAL wal)<a name="line.612"></a>
-<span class="sourceLineNo">613</span> throws IOException {<a name="line.613"></a>
-<span class="sourceLineNo">614</span> ChunkCreator.initialize(MemStoreLABImpl.CHUNK_SIZE_DEFAULT, false, 0, 0, 0, null);<a name="line.614"></a>
-<span class="sourceLineNo">615</span> return TEST_UTIL.createLocalHRegion(tableName, startKey, stopKey, false, Durability.SYNC_WAL,<a name="line.615"></a>
-<span class="sourceLineNo">616</span> wal, COLUMN_FAMILY_BYTES);<a name="line.616"></a>
-<span class="sourceLineNo">617</span> }<a name="line.617"></a>
-<span class="sourceLineNo">618</span>}<a name="line.618"></a>
+<span class="sourceLineNo">387</span> @Override<a name="line.387"></a>
+<span class="sourceLineNo">388</span> public boolean isStopping() {<a name="line.388"></a>
+<span class="sourceLineNo">389</span> return false;<a name="line.389"></a>
+<span class="sourceLineNo">390</span> }<a name="line.390"></a>
+<span class="sourceLineNo">391</span><a name="line.391"></a>
+<span class="sourceLineNo">392</span> @Override<a name="line.392"></a>
+<span class="sourceLineNo">393</span> public Connection createConnection(Configuration conf) throws IOException {<a name="line.393"></a>
+<span class="sourceLineNo">394</span> return null;<a name="line.394"></a>
+<span class="sourceLineNo">395</span> }<a name="line.395"></a>
+<span class="sourceLineNo">396</span> }<a name="line.396"></a>
+<span class="sourceLineNo">397</span><a name="line.397"></a>
+<span class="sourceLineNo">398</span> static class DummyWALActionsListener implements WALActionsListener {<a name="line.398"></a>
+<span class="sourceLineNo">399</span><a name="line.399"></a>
+<span class="sourceLineNo">400</span> @Override<a name="line.400"></a>
+<span class="sourceLineNo">401</span> public void visitLogEntryBeforeWrite(WALKey logKey, WALEdit logEdit)<a name="line.401"></a>
+<span class="sourceLineNo">402</span> throws IOException {<a name="line.402"></a>
+<span class="sourceLineNo">403</span> if (logKey.getTableName().getNameAsString().equalsIgnoreCase("sleep")) {<a name="line.403"></a>
+<span class="sourceLineNo">404</span> try {<a name="line.404"></a>
+<span class="sourceLineNo">405</span> Thread.sleep(1000);<a name="line.405"></a>
+<span class="sourceLineNo">406</span> } catch (InterruptedException e) {<a name="line.406"></a>
+<span class="sourceLineNo">407</span> e.printStackTrace();<a name="line.407"></a>
+<span class="sourceLineNo">408</span> }<a name="line.408"></a>
+<span class="sourceLineNo">409</span> }<a name="line.409"></a>
+<span class="sourceLineNo">410</span> if (logKey.getTableName().getNameAsString()<a name="line.410"></a>
+<span class="sourceLineNo">411</span> .equalsIgnoreCase("DamagedWALException")) {<a name="line.411"></a>
+<span class="sourceLineNo">412</span> throw new DamagedWALException("Failed appending");<a name="line.412"></a>
+<span class="sourceLineNo">413</span> }<a name="line.413"></a>
+<span class="sourceLineNo">414</span> }<a name="line.414"></a>
+<span class="sourceLineNo">415</span><a name="line.415"></a>
+<span class="sourceLineNo">416</span> }<a name="line.416"></a>
+<span class="sourceLineNo">417</span><a name="line.417"></a>
+<span class="sourceLineNo">418</span> /**<a name="line.418"></a>
+<span class="sourceLineNo">419</span> * @return A region on which you must call {@link HBaseTestingUtility#closeRegionAndWAL(HRegion)}<a name="line.419"></a>
+<span class="sourceLineNo">420</span> * when done.<a name="line.420"></a>
+<span class="sourceLineNo">421</span> */<a name="line.421"></a>
+<span class="sourceLineNo">422</span> private static HRegion initHRegion(TableName tableName, byte[] startKey, byte[] stopKey, WAL wal)<a name="line.422"></a>
+<span class="sourceLineNo">423</span> throws IOException {<a name="line.423"></a>
+<span class="sourceLineNo">424</span> ChunkCreator.initialize(MemStoreLABImpl.CHUNK_SIZE_DEFAULT, false, 0, 0, 0, null);<a name="line.424"></a>
+<span class="sourceLineNo">425</span> return TEST_UTIL.createLocalHRegion(tableName, startKey, stopKey, false, Durability.SYNC_WAL,<a name="line.425"></a>
+<span class="sourceLineNo">426</span> wal, COLUMN_FAMILY_BYTES);<a name="line.426"></a>
+<span class="sourceLineNo">427</span> }<a name="line.427"></a>
+<span class="sourceLineNo">428</span>}<a name="line.428"></a>