You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Nitay Joffe (JIRA)" <ji...@apache.org> on 2009/03/15 00:50:50 UTC
[jira] Created: (HBASE-1262) Warning: Access to enclosing
constructor X is emulated by a synthetic accessor method. Increasing its
visibility will increase your performance.
Warning: Access to enclosing constructor X is emulated by a synthetic accessor method. Increasing its visibility will increase your performance.
------------------------------------------------------------------------------------------------------------------------------------------------
Key: HBASE-1262
URL: https://issues.apache.org/jira/browse/HBASE-1262
Project: Hadoop HBase
Issue Type: Improvement
Affects Versions: 0.19.0
Reporter: Nitay Joffe
Assignee: Nitay Joffe
Priority: Trivial
Fix For: 0.19.1
We get this warning all over in many pieces of the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1262) Eclipse warnings, including
performance related things like synthetic accessors.
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated HBASE-1262:
-------------------------------
Summary: Eclipse warnings, including performance related things like synthetic accessors. (was: Warning: Access to enclosing constructor X is emulated by a synthetic accessor method. Increasing its visibility will increase your performance.)
> Eclipse warnings, including performance related things like synthetic accessors.
> --------------------------------------------------------------------------------
>
> Key: HBASE-1262
> URL: https://issues.apache.org/jira/browse/HBASE-1262
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.19.0
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Fix For: 0.19.2
>
> Attachments: hbase-1261-v1.patch, hbase-1262.patch, hbase-1262.patch
>
>
> We get this warning all over in many pieces of the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1262) Warning: Access to enclosing
constructor X is emulated by a synthetic accessor method. Increasing its
visibility will increase your performance.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1262:
-------------------------
Fix Version/s: (was: 0.19.1)
0.19.2
Moving to 0.19.2
> Warning: Access to enclosing constructor X is emulated by a synthetic accessor method. Increasing its visibility will increase your performance.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-1262
> URL: https://issues.apache.org/jira/browse/HBASE-1262
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.19.0
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Fix For: 0.19.2
>
> Attachments: hbase-1262.patch
>
>
> We get this warning all over in many pieces of the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1262) Warning: Access to enclosing
constructor X is emulated by a synthetic accessor method. Increasing its
visibility will increase your performance.
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated HBASE-1262:
-------------------------------
Attachment: hbase-1262.patch
Patch that gets rid of these warnings. Changes private methods that are accessed to protected.
> Warning: Access to enclosing constructor X is emulated by a synthetic accessor method. Increasing its visibility will increase your performance.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-1262
> URL: https://issues.apache.org/jira/browse/HBASE-1262
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.19.0
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Fix For: 0.19.1
>
> Attachments: hbase-1262.patch
>
>
> We get this warning all over in many pieces of the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1262) Warning: Access to enclosing
constructor X is emulated by a synthetic accessor method. Increasing its
visibility will increase your performance.
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682514#action_12682514 ]
Nitay Joffe commented on HBASE-1262:
------------------------------------
Comparators or things that extend them, as some Writables do.
> Warning: Access to enclosing constructor X is emulated by a synthetic accessor method. Increasing its visibility will increase your performance.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-1262
> URL: https://issues.apache.org/jira/browse/HBASE-1262
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.19.0
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Fix For: 0.19.2
>
> Attachments: hbase-1262.patch, hbase-1262.patch
>
>
> We get this warning all over in many pieces of the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1262) Warning: Access to enclosing
constructor X is emulated by a synthetic accessor method. Increasing its
visibility will increase your performance.
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated HBASE-1262:
-------------------------------
Attachment: hbase-1261-v1.patch
Fixes to everything mentioned. Leaving in @Override as per IRC discussion:
[15:40] <nitay> St^Ack, wrt 1262, there's a section here about @Override: http://java.sun.com/docs/books/tutorial/java/javaOO/annotations.html
[15:41] <nitay> essentially its for compiler checks that u're actually overriding a method in superclass
[15:41] <nitay> keep it in patch, or remove them?
...
[15:48] <St^Ack> nitay: it says there that the compiler will complain if the overridden method is missing; I think that good reason to leave them in
> Warning: Access to enclosing constructor X is emulated by a synthetic accessor method. Increasing its visibility will increase your performance.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-1262
> URL: https://issues.apache.org/jira/browse/HBASE-1262
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.19.0
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Fix For: 0.19.2
>
> Attachments: hbase-1261-v1.patch, hbase-1262.patch, hbase-1262.patch
>
>
> We get this warning all over in many pieces of the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1262) Warning: Access to enclosing
constructor X is emulated by a synthetic accessor method. Increasing its
visibility will increase your performance.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683147#action_12683147 ]
stack commented on HBASE-1262:
------------------------------
(Review with Nitay and I sitting together):
Good one:
public static StoreKeyComparator getRawComparator(final HRegionInfo hri) {
- return hri.isRootRegion()? ROOT_COMPARATOR:
- hri.isMetaRegion()? META_COMPARATOR: META_COMPARATOR;
+ return hri.isRootRegion() ? ROOT_COMPARATOR : META_COMPARATOR;
Should be PLAIN_COMPARATOR instead as the final result of the above mess
Yeah, the Serializable stuff doesn't add anything except maybe a little confusion as to whats going on
(Nitay found this himself) in HTD equals, returning wrong side of a boolean
Don't add the @overrides?
Otherwise, looks great.
> Warning: Access to enclosing constructor X is emulated by a synthetic accessor method. Increasing its visibility will increase your performance.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-1262
> URL: https://issues.apache.org/jira/browse/HBASE-1262
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.19.0
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Fix For: 0.19.2
>
> Attachments: hbase-1262.patch, hbase-1262.patch
>
>
> We get this warning all over in many pieces of the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1262) Warning: Access to enclosing
constructor X is emulated by a synthetic accessor method. Increasing its
visibility will increase your performance.
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated HBASE-1262:
-------------------------------
Attachment: hbase-1262.patch
In this patch:
- Fix trivial cases where we call toString() on an array of bytes by calling
Bytes.toString().
- Add missing @Override annotations.
- Annotate deprecated methods with @Deprecated.
- Add javadoc comment with @see to parent method for overriding methods with
no comment.
- Fix existing javadoc comment tags.
- Add check for null and class type for equals() methods that assume the right
type.
- Remove unnecessary else clauses (e.g. when if returns/throws).
- Remove unnecessary casts.
- Fix methods assigning parameter names.
- FindBugs: Replace Integers being used as locks with Objects.
- FindBugs: Unsynchronized get method, synchronized set method.
- Replace myArray.hashCode() with Arrays.hashCode(myArray).
- Remove @SuppressWarnings("unused") where it's not needed.
- Implement Serializable for simple Comparators.
> Warning: Access to enclosing constructor X is emulated by a synthetic accessor method. Increasing its visibility will increase your performance.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-1262
> URL: https://issues.apache.org/jira/browse/HBASE-1262
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.19.0
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Fix For: 0.19.2
>
> Attachments: hbase-1262.patch, hbase-1262.patch
>
>
> We get this warning all over in many pieces of the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1262) Warning: Access to enclosing
constructor X is emulated by a synthetic accessor method. Increasing its
visibility will increase your performance.
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682505#action_12682505 ]
Jim Kellerman commented on HBASE-1262:
--------------------------------------
@Nitay
+1 except for "Implement Serializable for simple Comparators." Shouldn't that be Writable?
> Warning: Access to enclosing constructor X is emulated by a synthetic accessor method. Increasing its visibility will increase your performance.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-1262
> URL: https://issues.apache.org/jira/browse/HBASE-1262
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.19.0
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Fix For: 0.19.2
>
> Attachments: hbase-1262.patch, hbase-1262.patch
>
>
> We get this warning all over in many pieces of the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1262) Eclipse warnings, including
performance related things like synthetic accessors.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683372#action_12683372 ]
stack commented on HBASE-1262:
------------------------------
Ryan just tripped over the bug where we were returning a catalog table comparator when context was a user table.
> Eclipse warnings, including performance related things like synthetic accessors.
> --------------------------------------------------------------------------------
>
> Key: HBASE-1262
> URL: https://issues.apache.org/jira/browse/HBASE-1262
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.19.0
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Fix For: 0.20.0
>
> Attachments: hbase-1261-v1.patch, hbase-1262.patch, hbase-1262.patch
>
>
> We get this warning all over in many pieces of the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1262) Eclipse warnings, including
performance related things like synthetic accessors.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1262:
-------------------------
Resolution: Fixed
Fix Version/s: (was: 0.19.2)
0.20.0
Status: Resolved (was: Patch Available)
Committed to TRUNK. Thanks for the patch Nitay.
> Eclipse warnings, including performance related things like synthetic accessors.
> --------------------------------------------------------------------------------
>
> Key: HBASE-1262
> URL: https://issues.apache.org/jira/browse/HBASE-1262
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.19.0
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Fix For: 0.20.0
>
> Attachments: hbase-1261-v1.patch, hbase-1262.patch, hbase-1262.patch
>
>
> We get this warning all over in many pieces of the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1262) Warning: Access to enclosing
constructor X is emulated by a synthetic accessor method. Increasing its
visibility will increase your performance.
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated HBASE-1262:
-------------------------------
Status: Patch Available (was: Open)
> Warning: Access to enclosing constructor X is emulated by a synthetic accessor method. Increasing its visibility will increase your performance.
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-1262
> URL: https://issues.apache.org/jira/browse/HBASE-1262
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.19.0
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Fix For: 0.19.2
>
> Attachments: hbase-1262.patch, hbase-1262.patch
>
>
> We get this warning all over in many pieces of the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.