You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "ascrutae (GitHub)" <gi...@apache.org> on 2018/08/21 23:02:16 UTC
[GitHub] [incubator-skywalking] ascrutae opened pull request #1571:
Support ojdbc8
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve performance
- Related issues
#1391
[ Full content available at: https://github.com/apache/incubator-skywalking/pull/1571 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-skywalking] wu-sheng closed pull request #1571:
Support ojdbc8
Posted by "wu-sheng (GitHub)" <gi...@apache.org>.
[ pull request closed by wu-sheng ]
[ Full content available at: https://github.com/apache/incubator-skywalking/pull/1571 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-skywalking] coveralls commented on issue #1571:
Support ojdbc8
Posted by "coveralls (GitHub)" <gi...@apache.org>.
[](https://coveralls.io/builds/18604528)
Coverage decreased (-0.004%) to 24.68% when pulling **727ec02c19ab86546e23acfba0486b25e2376100 on ascrutae:feature/support-ojdbc8** into **18d2d352fd432ffa645e024fbc9e34d6aaaca2f6 on apache:master**.
[ Full content available at: https://github.com/apache/incubator-skywalking/pull/1571 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-skywalking] wu-sheng commented on pull request
#1571: Support ojdbc8
Posted by "wu-sheng (GitHub)" <gi...@apache.org>.
You are using a different coding style. Do you prefer to use a static field or literal string? I am OK with either, but don't use them at the same time.
[ Full content available at: https://github.com/apache/incubator-skywalking/pull/1571 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-skywalking] coveralls commented on issue #1571:
Support ojdbc8
Posted by "coveralls (GitHub)" <gi...@apache.org>.
[](https://coveralls.io/builds/18600764)
Coverage remained the same at 24.68% when pulling **604a481411e87c82f6d0ef1c39133e98f9e50af1 on ascrutae:feature/support-ojdbc8** into **46c0e76ef943ab4a4b89ec315a006107e069d54d on apache:master**.
[ Full content available at: https://github.com/apache/incubator-skywalking/pull/1571 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org