You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by hgschmie <gi...@git.apache.org> on 2017/03/03 01:07:31 UTC
[GitHub] maven-release pull request #14: MRELEASE-979 fixes
GitHub user hgschmie opened a pull request:
https://github.com/apache/maven-release/pull/14
MRELEASE-979 fixes
The proposed (and merged) change has the following problems (IAW it does not work at all):
- The selected naming policy is not copied in all places; especially it is not copied when merging with the properties loaded from the release.properties file. As a result, it always reverts to 'default'
- The current logic only executes the naming policy if the scmTagName is unset. This is counter-intuitive (to say the least). My original proposed patch did not have that problem. Change this to execute unconditionally if the operation requested is a branch operation, otherwise only if the scmTagName is unset
- The current logic failed unconditionally if the build is non-interactive and a branch operation is requested.
This pull request fixes all of the mentioned problems.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hgschmie/maven-release MRELEASE-979-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-release/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit 5b17a0e21d59170a905d2d8eea4d0cb7f3d3bb65
Author: Henning Schmiedehausen <he...@zuora.com>
Date: 2017-03-03T00:19:07Z
Adds missing places where the naming policy id is not copied.
commit d505400d3cdc69d930e98c8287973e79e8be9756
Author: Henning Schmiedehausen <he...@zuora.com>
Date: 2017-03-03T00:20:04Z
Fixes the naming policy logic.
- Ensure that the naming policy is executed when a branch is requested even if an scm tag name is set.
- Ensure that in non-interactive mode, the plugin does not fail unconditionally if a branch is requested.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-release pull request #14: MRELEASE-979 fixes
Posted by hgschmie <gi...@git.apache.org>.
Github user hgschmie closed the pull request at:
https://github.com/apache/maven-release/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org