You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/12/30 23:22:19 UTC
[GitHub] [cordova-plugin-inappbrowser] NiklasMerz opened a new issue #599:
Remove window.open overwrite
NiklasMerz opened a new issue #599: Remove window.open overwrite
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/599
# Feature Request
## Motivation Behind Feature
<!-- Why should this feature be implemented? What problem does it solve? -->
Like described in the README file a long time ago there was a plan to remove the backwards compatibility of overwriting `window.open` in a future release. [See](WKWebViewOnly https://github.com/apache/cordova-plugin-inappbrowser#windowopen)
> For backwards compatibility, this plugin also hooks window.open. However, the plugin-installed hook of window.open can have unintended side effects (especially if this plugin is included only as a dependency of another plugin). The hook of window.open will be removed in a future major release. Until the hook is removed from the plugin, apps can manually restore the default behaviour:
## Feature Description
<!--
Describe your feature request in detail
Please provide any code examples or screenshots of what this feature would look like
Are there any drawbacks? Will this break anything for existing users?
-->
We should remove this overwrite of the native browser window function to avoid errors like this:
#315
#403
## Alternatives or Workarounds
<!--
Describe alternatives or workarounds you are currently using
Are there ways to do this with existing functionality?
-->
A proposal to change the docs exists #528
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] NiklasMerz closed issue #599: Remove
window.open overwrite
Posted by GitBox <gi...@apache.org>.
NiklasMerz closed issue #599: Remove window.open overwrite
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/599
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org