You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/01 20:56:26 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #25939: Fix placeholders in `TrinoHook`, `PrestoHook`, `SqliteHook`

potiuk commented on code in PR #25939:
URL: https://github.com/apache/airflow/pull/25939#discussion_r961093775


##########
airflow/providers/common/sql/provider.yaml:
##########
@@ -22,6 +22,7 @@ description: |
     `Common SQL Provider <https://en.wikipedia.org/wiki/SQL>`__
 
 versions:
+  - 1.2.0

Review Comment:
   No. It's fine. There is new feature (placeholder) added  to common.sql . The bugfix bumps should be in trino, presto, sqlite, but common-sql has  a new feature added (and those bugfix versions of trino/presto/sqlite should depend on this new feature). All looks fine here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org