You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Dhaval Rajpara <dh...@gmail.com> on 2024/07/23 12:20:41 UTC
Review Request 75100: RANGER-4851 : Upon editing an User we are seeing some discrepancy in its Audit Admin logs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75100/
-----------------------------------------------------------
Review request for ranger, Brijesh Bhalala, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Rakesh Gupta, Vishal Bhavsar, and Velmurugan Periasamy.
Bugs: RANGER-4851
https://issues.apache.org/jira/browse/RANGER-4851
Repository: ranger
Description
-------
Upon editing an User we are seeing some discrepancy in its Audit Admin logs in "ranger-2.5" branch.
Steps to repro:
Create user (eg vbuser1) by entering all the details in user create form except Group.
Now edit the user and add any group (eg group1) to it and save.
In Audit Admin tab we would see 3 corresponding logs entry for the above edit operation. Refer snapshot1
One log is of "User profile updated vbuser1" of Audit Type: User Profile, upon clicking on it the modal opens which has "User Details: " table empty. Refer snapshot2
Second log is of "User updated vbuser1" of Audit Type: Ranger User, upon clicking on it the modal opens with below observation. Refer snapshot3
here "User Details: " table shows Password getting updated even when we did not edit the password
in "Group: " table we are seeing groups numerical value instead of its string name i.e group1.
Third log is of Audit Type: XA Group of Users , upon clicking on it modal opens which is blank i.e no detail seen. Refer snapshot4
Have attached snapshots for reference.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java d5714e858
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 4a2cd4535
security-admin/src/main/java/org/apache/ranger/service/AbstractAuditedResourceService.java fd51724af
security-admin/src/main/java/org/apache/ranger/service/XGroupUserServiceBase.java 6776ab374
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx 4f974097f
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx 62d71d4db
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx b2056209d
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserAssociationWithGroupLogs.jsx PRE-CREATION
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx 25f6f5d3f
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx 72753b9d0
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx d8378403a
security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 8eea802f9
security-admin/src/test/java/org/apache/ranger/service/TestXPermMapService.java b07223663
Diff: https://reviews.apache.org/r/75100/diff/1/
Testing
-------
Tested all user, group, and role-related operations and monitored their logs. Everything is functioning correctly, and the logs are being generated properly.
Thanks,
Dhaval Rajpara
Re: Review Request 75100: RANGER-4851 : Upon editing an User we are seeing some discrepancy in its Audit Admin logs.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75100/#review226710
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On July 23, 2024, 12:20 p.m., Dhaval Rajpara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75100/
> -----------------------------------------------------------
>
> (Updated July 23, 2024, 12:20 p.m.)
>
>
> Review request for ranger, Brijesh Bhalala, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Rakesh Gupta, Vishal Bhavsar, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4851
> https://issues.apache.org/jira/browse/RANGER-4851
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Upon editing an User we are seeing some discrepancy in its Audit Admin logs in "ranger-2.5" branch.
>
> Steps to repro:
>
> Create user (eg vbuser1) by entering all the details in user create form except Group.
> Now edit the user and add any group (eg group1) to it and save.
> In Audit Admin tab we would see 3 corresponding logs entry for the above edit operation. Refer snapshot1
> One log is of "User profile updated vbuser1" of Audit Type: User Profile, upon clicking on it the modal opens which has "User Details: " table empty. Refer snapshot2
> Second log is of "User updated vbuser1" of Audit Type: Ranger User, upon clicking on it the modal opens with below observation. Refer snapshot3
> here "User Details: " table shows Password getting updated even when we did not edit the password
> in "Group: " table we are seeing groups numerical value instead of its string name i.e group1.
> Third log is of Audit Type: XA Group of Users , upon clicking on it modal opens which is blank i.e no detail seen. Refer snapshot4
> Have attached snapshots for reference.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java d5714e858
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 4a2cd4535
> security-admin/src/main/java/org/apache/ranger/service/AbstractAuditedResourceService.java fd51724af
> security-admin/src/main/java/org/apache/ranger/service/XGroupUserServiceBase.java 6776ab374
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx 4f974097f
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx 62d71d4db
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx b2056209d
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserAssociationWithGroupLogs.jsx PRE-CREATION
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx 25f6f5d3f
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx 72753b9d0
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx d8378403a
> security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 8eea802f9
> security-admin/src/test/java/org/apache/ranger/service/TestXPermMapService.java b07223663
>
>
> Diff: https://reviews.apache.org/r/75100/diff/1/
>
>
> Testing
> -------
>
> Tested all user, group, and role-related operations and monitored their logs. Everything is functioning correctly, and the logs are being generated properly.
>
>
> Thanks,
>
> Dhaval Rajpara
>
>