[GitHub] [spark] skonto commented on a change in pull request #24814: set Int MaxValue

[GitBox <gi...@apache.org>]

skonto commented on a change in pull request #24814: set Int MaxValue
URL: https://github.com/apache/spark/pull/24814#discussion_r291570707
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala
 ##########
 @@ -233,7 +233,7 @@ class Word2Vec extends Serializable with Logging {
       a += 1
     }
     while (a < 2 * vocabSize) {
-      count(a) = 1e9.toInt
+      count(a) = Int.MaxValue
 
 Review comment:
   If not mistaken the array holds longs should not be a Long Max? my 2 cents.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org