[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3590: ARTEMIS-3309 Add a parameter to limit messages to move or transfer

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #3590:
URL: https://github.com/apache/activemq-artemis/pull/3590#discussion_r637285931



##########
File path: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/Transfer.java
##########
@@ -105,10 +105,207 @@
    @Option(name = "--target-topic", description = "Destination to be used. It can be prefixed with queue:// or topic:// and can be an FQQN in the form of <address>::<queue>. (Default: queue://TEST)")
    String targetTopic;
 
-   boolean isCopy() {
+   @Option(name = "--max-count", description = "The maximum number of messages to transfer.")

Review comment:
       Can we make this consistent to ./artemis consumer... so this would come as --message-count ?
   
   Can you check others...
   
   if you want to expand towards those options.. isn't this something you could share a common base class with consumer?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org