You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "rawwar (via GitHub)" <gi...@apache.org> on 2024/02/05 17:44:00 UTC
Re: [PR] Type Check for retries [airflow]
rawwar commented on code in PR #34914:
URL: https://github.com/apache/airflow/pull/34914#discussion_r1478638440
##########
airflow/models/baseoperator.py:
##########
@@ -124,7 +124,7 @@
def parse_retries(retries: Any) -> int | None:
- if retries is None or isinstance(retries, int):
+ if retries is None or type(retries) == int:
Review Comment:
@ephraimbuddy , I added tests and raised another PR - https://github.com/apache/airflow/pull/37183 . I couldn't pull the changes from this PR because it is failing a lint check and hence, i could not take commit , even with a cherry-pick, from this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org