You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/04/12 18:29:21 UTC

[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7409: GEODE-9512: close receiver connection if membership check timed out

pivotal-jbarrett commented on code in PR #7409:
URL: https://github.com/apache/geode/pull/7409#discussion_r848750664


##########
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java:
##########
@@ -3047,7 +3042,8 @@ private boolean readMessageHeader(ByteBuffer peerDataBuffer) throws IOException
     return false;
   }
 
-  private void readMessage(ByteBuffer peerDataBuffer, AbstractExecutor threadMonitorExecutor) {
+  @VisibleForTesting

Review Comment:
   Package private methods don't really need this annotation. Making methods package private is normal for unit testing. This annotation should be reserved for public methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org