[jira] [Comment Edited] (OFBIZ-10489) Unnecessary ship groups in orders

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16870233#comment-16870233 ] 

Jacques Le Roux edited comment on OFBIZ-10489 at 6/28/19 6:55 AM:
------------------------------------------------------------------

The issue is generated because of the code committed in the patch from the ticket OFBIZ-5416. Here the code was properly handled in _ShoppingCartEvents.java_ but not in _ShoppingCartHelper.java._

Did the same handling in _ShoppingCartHelper.java_  in the patch *OFBIZ-10489.patch*.


was (Author: mohammad k):
The issue is generated because of the code committed in the patch from the ticket https://issues.apache.org/jira/browse/OFBIZ-5416. Here the code was properly handled in _ShoppingCartEvents.java_ but not in _ShoppingCartHelper.java._

Did the same handling in _ShoppingCartHelper.java_  in the patch *OFBIZ-10489.patch*.

> Unnecessary ship groups in orders
> ---------------------------------
>
>                 Key: OFBIZ-10489
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10489
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Trunk
>            Reporter: Oleg Andreyev
>            Assignee: Mohammad Kathawala
>            Priority: Minor
>             Fix For: Trunk
>
>         Attachments: OFBIZ-10489.patch, empty_ship_group.diff
>
>
> Under some conditions, checkout creates extra ship groups in the order.
> Steps to reproduce:
>  # create a couple of products P1 and P2 (just to get clear results).
>  # create a new order and add 1 P1 and 1 P2
>  # change quantity P1 to 2 (or both) and Recalculate Order (key step really)
>  # finish checkout
> You will see 2 order items linked with ship group 00001 and another ship group 00002 that should not have been created. You may see in the patch that the code address a ship group using index of the order item and the shopping cart creates new ship group if the index is greater than the number of existing groups. 
> In one of my projects based on 16.11, I noticed even more serious trouble that takes place if both products are drop-shipping order but don't explain it here because it seems do not appear in the trunk.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)