You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "honeyhexin (Code Review)" <ge...@cloudera.org> on 2019/09/16 08:54:27 UTC
[kudu-CR] [catalog manager] correct the wrong comment
honeyhexin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14233
Change subject: [catalog_manager] correct the wrong comment
......................................................................
[catalog_manager] correct the wrong comment
Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6
---
M src/kudu/master/catalog_manager.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/14233/1
--
To view, visit http://gerrit.cloudera.org:8080/14233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6
Gerrit-Change-Number: 14233
Gerrit-PatchSet: 1
Gerrit-Owner: honeyhexin <ho...@sohu.com>
[kudu-CR] [catalog manager] correct the wrong comment
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14233 )
Change subject: [catalog_manager] correct the wrong comment
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14233/1/src/kudu/master/catalog_manager.h
File src/kudu/master/catalog_manager.h:
http://gerrit.cloudera.org:8080/#/c/14233/1/src/kudu/master/catalog_manager.h@141
PS1, Line 141: ,
nit: while you are at it, maybe change this comma (,) into period (.) as well?
--
To view, visit http://gerrit.cloudera.org:8080/14233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6
Gerrit-Change-Number: 14233
Gerrit-PatchSet: 1
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Sep 2019 16:49:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] [catalog manager] correct the wrong comment
Posted by "honeyhexin (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14233
to look at the new patch set (#2).
Change subject: [catalog_manager] correct the wrong comment
......................................................................
[catalog_manager] correct the wrong comment
Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6
---
M src/kudu/master/catalog_manager.h
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/14233/2
--
To view, visit http://gerrit.cloudera.org:8080/14233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6
Gerrit-Change-Number: 14233
Gerrit-PatchSet: 2
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [catalog manager] correct the wrong comment
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14233 )
Change subject: [catalog_manager] correct the wrong comment
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6
Gerrit-Change-Number: 14233
Gerrit-PatchSet: 2
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: honeyhexin <ho...@sohu.com>
Gerrit-Comment-Date: Mon, 16 Sep 2019 23:39:04 +0000
Gerrit-HasComments: No
[kudu-CR] [catalog manager] correct the wrong comment
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14233 )
Change subject: [catalog_manager] correct the wrong comment
......................................................................
[catalog_manager] correct the wrong comment
Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6
Reviewed-on: http://gerrit.cloudera.org:8080/14233
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/master/catalog_manager.h
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6
Gerrit-Change-Number: 14233
Gerrit-PatchSet: 3
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: honeyhexin <ho...@sohu.com>
[kudu-CR] [catalog manager] correct the wrong comment
Posted by "honeyhexin (Code Review)" <ge...@cloudera.org>.
honeyhexin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14233 )
Change subject: [catalog_manager] correct the wrong comment
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14233/1/src/kudu/master/catalog_manager.h
File src/kudu/master/catalog_manager.h:
http://gerrit.cloudera.org:8080/#/c/14233/1/src/kudu/master/catalog_manager.h@141
PS1, Line 141: .
> nit: while you are at it, maybe change this comma (,) into period (.) as we
Done
--
To view, visit http://gerrit.cloudera.org:8080/14233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4071923dc052b6b829ddc25a8a0392ad8d1767e6
Gerrit-Change-Number: 14233
Gerrit-PatchSet: 2
Gerrit-Owner: honeyhexin <ho...@sohu.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: honeyhexin <ho...@sohu.com>
Gerrit-Comment-Date: Mon, 16 Sep 2019 23:38:55 +0000
Gerrit-HasComments: Yes