You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "HeimingZ (via GitHub)" <gi...@apache.org> on 2023/11/16 10:23:07 UTC

[PR] Asynchronously make memtable checkpoints for wal [iotdb]

HeimingZ opened a new pull request, #11556:
URL: https://github.com/apache/iotdb/pull/11556

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Asynchronously make memtable checkpoints for wal [iotdb]

Posted by "caozj1011 (via GitHub)" <gi...@apache.org>.
caozj1011 commented on code in PR #11556:
URL: https://github.com/apache/iotdb/pull/11556#discussion_r1400108765


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java:
##########
@@ -472,6 +487,9 @@ public SyncBufferTask(
     @Override
     public void run() {

Review Comment:
   The logic of the run() method suggests that it might be encapsulated in two parts, one for checkPoint, like the makeMemTableCheckpoints() method, and another for Wal. If the rest of the code is also encapsulated as a function, the code will look very clean and organized



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Asynchronously make memtable checkpoints for wal [iotdb]

Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on PR #11556:
URL: https://github.com/apache/iotdb/pull/11556#issuecomment-1824172919

   It's awesome to see that our create_memtable_block metric is helping. 
   After this optimization pr is combined, we can consider removing the monitoring item in the next version due to your excellent results!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Asynchronously make memtable checkpoints for wal [iotdb]

Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou merged PR #11556:
URL: https://github.com/apache/iotdb/pull/11556


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org