[GitHub] [airflow] sjmiller609 commented on issue #6067: [AIRFLOW-5448] Handle istio-proxy for Kubernetes Executor

[GitBox <gi...@apache.org>]

sjmiller609 commented on issue #6067: [AIRFLOW-5448] Handle istio-proxy for Kubernetes Executor
URL: https://github.com/apache/airflow/pull/6067#issuecomment-530080861
 
 
   @mik-laj Thank you so much for your continued help on this contribution. Can you help me disambiguate something? The intention of this PR is to handle istio for any operator when running using KubernetesExecutor, and the executor is running in a cluster with Istio. Astronomer has discovered that the current behavior is that the task's pods will not be cleaned up.
   
   That being said, I think Istio ought to be handled for all similar situations, for example any Kubernetes pod operator, including the ones you have shown in your example. I am willing to contribute those modifications in addition to this modification, and any advice you give is greatly appreciated.
   
   My plan going forward is the following:
   - back port this change to Airflow 0.10.4 to meet an immediate business need on Astronomer's end
   - contribute to all pod operators to handle Istio on airflow 2

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services