You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/12/13 13:48:51 UTC

[GitHub] [mynewt-nimble] haukepetersen commented on pull request #1129: host/gap: fix legacy advertising for BLE_EXT_ADV=1

haukepetersen commented on pull request #1129:
URL: https://github.com/apache/mynewt-nimble/pull/1129#issuecomment-992493140


   True, you are right, I missed those combinations... 
   
   Big +1 for adapting the code for auto-filling and throwing errors already in the host code. I have been running into this issue multiple times now, and as it seems I am really bad in remembering how to apply it correctly :-)
   
   I will rework this PR with a proposal on error checking/auto-filling of params, lets see if I can come up with something feasible...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org