You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@allura.apache.org by ke...@apache.org on 2017/11/07 15:08:54 UTC

[2/2] allura git commit: Avoid errors on ticket search if filter=123 or =foo instead of json dict

Avoid errors on ticket search if filter=123 or =foo instead of json dict


Project: http://git-wip-us.apache.org/repos/asf/allura/repo
Commit: http://git-wip-us.apache.org/repos/asf/allura/commit/433e9756
Tree: http://git-wip-us.apache.org/repos/asf/allura/tree/433e9756
Diff: http://git-wip-us.apache.org/repos/asf/allura/diff/433e9756

Branch: refs/heads/master
Commit: 433e9756b107ff58b8b6aebf48573a0a24c98faa
Parents: 936319c
Author: Dave Brondsema <da...@brondsema.net>
Authored: Mon Nov 6 12:08:25 2017 -0500
Committer: Kenton Taylor <kt...@slashdotmedia.com>
Committed: Tue Nov 7 15:08:43 2017 +0000

----------------------------------------------------------------------
 ForgeTracker/forgetracker/tracker_main.py | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/allura/blob/433e9756/ForgeTracker/forgetracker/tracker_main.py
----------------------------------------------------------------------
diff --git a/ForgeTracker/forgetracker/tracker_main.py b/ForgeTracker/forgetracker/tracker_main.py
index 5fa57ca..16888de 100644
--- a/ForgeTracker/forgetracker/tracker_main.py
+++ b/ForgeTracker/forgetracker/tracker_main.py
@@ -722,6 +722,10 @@ class RootController(BaseController, FeedController):
             show_deleted = [False, True]
         elif deleted and not has_access(c.app, 'delete'):
             deleted = False
+
+        if not isinstance(filter, dict):
+            # JsonConverter above can return an int, string, etc, if users give bad inputs, but it needs to be a dict
+            filter = {}
             
         # it's just our original query mangled and sent back to us
         kw.pop('q', None)