[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #12177: introduce a "tree" type to the flattenSpec

[GitBox <gi...@apache.org>]

abhishekagarwal87 commented on code in PR #12177:
URL: https://github.com/apache/druid/pull/12177#discussion_r986027579


##########
core/src/main/java/org/apache/druid/java/util/common/parsers/ObjectFlatteners.java:
##########
@@ -231,6 +235,11 @@ public Map<String, Object> toMap(T obj)
      */
     Function<T, Object> makeJsonQueryExtractor(String expr);
 
+    /**
+     * Create a "field" extractor for nested json expressions
+     */
+    Function<T, Object> makeJsonTreeExtractor(List<String> nodes);

Review Comment:
   It's already implemented in Avro, orc, and parquet extension. So +1 to both of your suggestions. We should add a default impl and and mark it extension point. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org