You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "egalpin (via GitHub)" <gi...@apache.org> on 2023/06/09 19:27:50 UTC
[GitHub] [pinot] egalpin opened a new pull request, #10880: Fixes #10875 - build forward index if isSorted only results from autogenerated nodict column
egalpin opened a new pull request, #10880:
URL: https://github.com/apache/pinot/pull/10880
`bugfix`
I'm not sure what this could potentially break so this would definitely need review, but I've validated that this fixes the issue described in #10875 by intentionally getting a local instance into the error state, introducing the code, and restarting the server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] egalpin closed pull request #10880: Fixes #10875 - build forward index if isSorted only results from autogenerated nodict column
Posted by "egalpin (via GitHub)" <gi...@apache.org>.
egalpin closed pull request #10880: Fixes #10875 - build forward index if isSorted only results from autogenerated nodict column
URL: https://github.com/apache/pinot/pull/10880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] egalpin commented on a diff in pull request #10880: Fixes #10875 - build forward index if isSorted only results from autogenerated nodict column
Posted by "egalpin (via GitHub)" <gi...@apache.org>.
egalpin commented on code in PR #10880:
URL: https://github.com/apache/pinot/pull/10880#discussion_r1224708964
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java:
##########
@@ -359,7 +359,8 @@ private boolean shouldDisableDictionary(String column, ColumnMetadata existingCo
}
// Sorted columns should always have a dictionary.
- if (existingColumnMetadata.isSorted()) {
+ if (existingColumnMetadata.isSorted()
+ && !(existingColumnMetadata.getCardinality() == 1 && existingColumnMetadata.isAutoGenerated())) {
Review Comment:
columns which are auto-generated as part of segment reload after adding a new column always have `cardinality: 1` because the default null value for the column is the sole value in the segment.
When columns have cardinality of 1, they are inferred to be sorted. It's possible a better fix exists where the noDictColumns can be referenced at the time that "isSorted" is determined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10880: Fixes #10875 - build forward index if isSorted only results from autogenerated nodict column
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10880:
URL: https://github.com/apache/pinot/pull/10880#issuecomment-1585125779
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10880?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10880](https://app.codecov.io/gh/apache/pinot/pull/10880?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bc9efbf) into [master](https://app.codecov.io/gh/apache/pinot/commit/a75544f2c644874a88b61cea48b640d9cf05283c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a75544f) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #10880 +/- ##
=======================================
Coverage 0.11% 0.11%
=======================================
Files 2186 2186
Lines 117353 117354 +1
Branches 17730 17731 +1
=======================================
Hits 137 137
- Misses 117196 117197 +1
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `0.00% <0.00%> (ø)` | |
| integration1temurin17 | `?` | |
| integration1temurin20 | `?` | |
| integration2temurin11 | `0.00% <0.00%> (ø)` | |
| integration2temurin17 | `0.00% <0.00%> (ø)` | |
| integration2temurin20 | `0.00% <0.00%> (ø)` | |
| unittests1temurin11 | `0.00% <0.00%> (ø)` | |
| unittests1temurin17 | `?` | |
| unittests1temurin20 | `0.00% <0.00%> (ø)` | |
| unittests2temurin11 | `0.11% <0.00%> (ø)` | |
| unittests2temurin17 | `?` | |
| unittests2temurin20 | `0.11% <0.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/10880?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ocal/segment/index/loader/ForwardIndexHandler.java](https://app.codecov.io/gh/apache/pinot/pull/10880?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zZWdtZW50L2luZGV4L2xvYWRlci9Gb3J3YXJkSW5kZXhIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] egalpin commented on pull request #10880: Fixes #10875 - build forward index if isSorted only results from autogenerated nodict column
Posted by "egalpin (via GitHub)" <gi...@apache.org>.
egalpin commented on PR #10880:
URL: https://github.com/apache/pinot/pull/10880#issuecomment-1585160924
Superseded by https://github.com/apache/pinot/pull/10851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org