You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/11/20 20:26:49 UTC

Review Request 40411: Libprocess Reinitialization: Modify test to use PID instead of a process pointer.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40411/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Bugs: MESOS-3934
    https://issues.apache.org/jira/browse/MESOS-3934


Repository: mesos


Description
-------

A related function return type was changed in the previous commit.


Diffs
-----

  src/tests/scheduler_driver_tests.cpp 4be2f72839365cea1893cbf21b6bd18cb2a8fcce 

Diff: https://reviews.apache.org/r/40411/diff/


Testing
-------

Tests done in a subsequent review.


Thanks,

Joseph Wu


Re: Review Request 40411: Libprocess Reinit: Modify test to use PID.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40411/
-----------------------------------------------------------

(Updated April 14, 2016, 1:28 p.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Changes
-------

Reviving this chain...


Summary (updated)
-----------------

Libprocess Reinit: Modify test to use PID<MetricsProcess>.


Bugs: MESOS-3934
    https://issues.apache.org/jira/browse/MESOS-3934


Repository: mesos


Description (updated)
-------

Updates the test's reference to the global metrics singleton.


Diffs (updated)
-----

  src/tests/scheduler_driver_tests.cpp 217185780e3576faf633dd9629ae93a275fac284 

Diff: https://reviews.apache.org/r/40411/diff/


Testing
-------

Tests done in a subsequent review.


Thanks,

Joseph Wu