[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1619: MINIFICPP-2172 Remove TensorFlow extension

["fgerlits (via GitHub)" <gi...@apache.org>]

fgerlits commented on code in PR #1619:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1619#discussion_r1277629149


##########
libminifi/test/TestBase.h:
##########
@@ -246,12 +246,10 @@ class TestPlan {
   void scheduleProcessor(const std::shared_ptr<minifi::core::Processor>& processor);
   void scheduleProcessors();
 
-  // Note: all this verify logic is only used in TensorFlow tests as a replacement for UpdateAttribute
-  // It should probably not be the part of the standard way of running processors
   bool runProcessor(const std::shared_ptr<minifi::core::Processor>& processor, const PreTriggerVerifier& verify = nullptr);
   bool runProcessor(size_t target_location, const PreTriggerVerifier& verify = nullptr);
   bool runNextProcessor(const PreTriggerVerifier& verify = nullptr);
-  bool runCurrentProcessor(const PreTriggerVerifier& verify = nullptr);
+  bool runCurrentProcessor();
   bool runCurrentProcessorUntilFlowfileIsProduced(std::chrono::milliseconds wait_duration);

Review Comment:
   Are the other `PreTriggerVerifier` arguments still needed?  The old comment said all of it was for tensorflow only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org