You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "ribaraka (via GitHub)" <gi...@apache.org> on 2025/04/18 18:19:49 UTC
[PR] CASSGO-23 Make Session immutable [cassandra-gocql-driver]
ribaraka opened a new pull request, #1882:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1882
Closes #1290
The previous design allowed modifying Session properties through setters. This added unnecessary overhead, as a mutex had to be acquired for every query execution. Additionally, as demonstrated in [#1473](https://github.com/apache/cassandra-gocql-driver/issues/1473) this mutability could lead to race conditions. By making Session immutable, we:
1. Eliminate race condition.
1. Eliminate the performance overhead of mutex acquisition
2. Simplify the concurrency model
3. Making cleaner configuration
This PR removing those setters and eliminating the need for the mutex. Configuration of refactored properties (i.e. consistency, trace etc.) is now handled at session creation through `ClusterConfig` and/or at execution time through **per-query** methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSGO-23 Make Session immutable [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1882:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1882#issuecomment-2854903333
Hi can you fix the conflict on `CHANGELOG.md` and fix the commit message? I'll merge this afterwards
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSGO-23 Make Session immutable [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis merged PR #1882:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSGO-23 Make Session immutable [cassandra-gocql-driver]
Posted by "ribaraka (via GitHub)" <gi...@apache.org>.
ribaraka commented on PR #1882:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1882#issuecomment-2855213930
@joao-r-reis, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org