[GitHub] [hadoop] Samrat002 commented on a diff in pull request #4546: YARN-11198. clean up numa resources from levelDB

[GitBox <gi...@apache.org>]

Samrat002 commented on code in PR #4546:
URL: https://github.com/apache/hadoop/pull/4546#discussion_r919181022


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/recovery/TestNMLeveldbStateStoreService.java:
##########
@@ -1756,6 +1756,12 @@ public void testStateStoreForResourceMapping() throws IOException {
     resources = rcs.getResourceMappings().getAssignedResources("numa");
     Assert.assertEquals(numaRes, resources);
     Assert.assertEquals(numaRes, resourceMappings.getAssignedResources("numa"));
+    // test removing numa resources from state store
+    stateStore.releaseNumaResource(containerId);
+    Assert.assertEquals(0, resourceMappings.getAssignedResources("numa").size());
+    // testing calling deletion of non-existing key doesn't break anything
+    stateStore.releaseNumaResource(containerId);

Review Comment:
   @PrabhuJoseph 
     thank you for reviewing the changes! 
   - changed the function name 
   - removed the not required tests 
   - Updated the test with 2 cases 
   
   Please review the changed patches 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org