You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Taylor Gautier (Created) (JIRA)" <ji...@apache.org> on 2011/11/18 05:59:51 UTC
[jira] [Created] (KAFKA-209) Remove empty directory when no log
segments remain
Remove empty directory when no log segments remain
--------------------------------------------------
Key: KAFKA-209
URL: https://issues.apache.org/jira/browse/KAFKA-209
Project: Kafka
Issue Type: Improvement
Components: core
Reporter: Taylor Gautier
When the log cleaner runs it deletes segments from the log directory. However, if all the segments are cleaned, the log directory itself is retained. There doesn't seem to be any need for this as the directory will be re-created on write if necessary.
This JIRA would improve the log cleaner to also remove unused topic directories from the log directory.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (KAFKA-209) Remove empty directory when no log
segments remain
Posted by "Neha Narkhede (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Neha Narkhede resolved KAFKA-209.
---------------------------------
Resolution: Fixed
> Remove empty directory when no log segments remain
> --------------------------------------------------
>
> Key: KAFKA-209
> URL: https://issues.apache.org/jira/browse/KAFKA-209
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Reporter: Taylor Gautier
>
> When the log cleaner runs it deletes segments from the log directory. However, if all the segments are cleaned, the log directory itself is retained. There doesn't seem to be any need for this as the directory will be re-created on write if necessary.
> This JIRA would improve the log cleaner to also remove unused topic directories from the log directory.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-209) Remove empty directory when no log
segments remain
Posted by "Neha Narkhede (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178951#comment-13178951 ]
Neha Narkhede commented on KAFKA-209:
-------------------------------------
Taylor,
Do you see this behavior with trunk or the 0.7 branch ?
> Remove empty directory when no log segments remain
> --------------------------------------------------
>
> Key: KAFKA-209
> URL: https://issues.apache.org/jira/browse/KAFKA-209
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Reporter: Taylor Gautier
>
> When the log cleaner runs it deletes segments from the log directory. However, if all the segments are cleaned, the log directory itself is retained. There doesn't seem to be any need for this as the directory will be re-created on write if necessary.
> This JIRA would improve the log cleaner to also remove unused topic directories from the log directory.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-209) Remove empty directory when no log
segments remain
Posted by "Jun Rao (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153987#comment-13153987 ]
Jun Rao commented on KAFKA-209:
-------------------------------
It should behave that way in both 0.6 and 0.7. If not, it's a bug.
> Remove empty directory when no log segments remain
> --------------------------------------------------
>
> Key: KAFKA-209
> URL: https://issues.apache.org/jira/browse/KAFKA-209
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Reporter: Taylor Gautier
>
> When the log cleaner runs it deletes segments from the log directory. However, if all the segments are cleaned, the log directory itself is retained. There doesn't seem to be any need for this as the directory will be re-created on write if necessary.
> This JIRA would improve the log cleaner to also remove unused topic directories from the log directory.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-209) Remove empty directory when no log
segments remain
Posted by "Taylor Gautier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153971#comment-13153971 ]
Taylor Gautier commented on KAFKA-209:
--------------------------------------
This is something that started happening after 0.6? It doesn't seem to be this way in 0.6. But it would entirely make sense.
> Remove empty directory when no log segments remain
> --------------------------------------------------
>
> Key: KAFKA-209
> URL: https://issues.apache.org/jira/browse/KAFKA-209
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Reporter: Taylor Gautier
>
> When the log cleaner runs it deletes segments from the log directory. However, if all the segments are cleaned, the log directory itself is retained. There doesn't seem to be any need for this as the directory will be re-created on write if necessary.
> This JIRA would improve the log cleaner to also remove unused topic directories from the log directory.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-209) Remove empty directory when no log
segments remain
Posted by "Taylor Gautier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178982#comment-13178982 ]
Taylor Gautier commented on KAFKA-209:
--------------------------------------
No, we have upgraded to 0.7 and this behavior does not exist in 0.7
> Remove empty directory when no log segments remain
> --------------------------------------------------
>
> Key: KAFKA-209
> URL: https://issues.apache.org/jira/browse/KAFKA-209
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Reporter: Taylor Gautier
>
> When the log cleaner runs it deletes segments from the log directory. However, if all the segments are cleaned, the log directory itself is retained. There doesn't seem to be any need for this as the directory will be re-created on write if necessary.
> This JIRA would improve the log cleaner to also remove unused topic directories from the log directory.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-209) Remove empty directory when no log
segments remain
Posted by "Jun Rao (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153918#comment-13153918 ]
Jun Rao commented on KAFKA-209:
-------------------------------
Actually, when all log segments are deleted, we automatically create an empty log file whose name is the latest offset. So the log directory will never be empty.
> Remove empty directory when no log segments remain
> --------------------------------------------------
>
> Key: KAFKA-209
> URL: https://issues.apache.org/jira/browse/KAFKA-209
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Reporter: Taylor Gautier
>
> When the log cleaner runs it deletes segments from the log directory. However, if all the segments are cleaned, the log directory itself is retained. There doesn't seem to be any need for this as the directory will be re-created on write if necessary.
> This JIRA would improve the log cleaner to also remove unused topic directories from the log directory.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-209) Remove empty directory when no log
segments remain
Posted by "Taylor Gautier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153989#comment-13153989 ]
Taylor Gautier commented on KAFKA-209:
--------------------------------------
It definitely does not in 0.6. Don't know about 0.7, haven't tried it. Now you see the source of my discussion on the mailing list ;-)
> Remove empty directory when no log segments remain
> --------------------------------------------------
>
> Key: KAFKA-209
> URL: https://issues.apache.org/jira/browse/KAFKA-209
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Reporter: Taylor Gautier
>
> When the log cleaner runs it deletes segments from the log directory. However, if all the segments are cleaned, the log directory itself is retained. There doesn't seem to be any need for this as the directory will be re-created on write if necessary.
> This JIRA would improve the log cleaner to also remove unused topic directories from the log directory.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira