[GitHub] [beam] jrmccluskey commented on a diff in pull request #17265: [BEAM-11104] Add ProcessContinuation type to Go SDK

[GitBox <gi...@apache.org>]

jrmccluskey commented on code in PR #17265:
URL: https://github.com/apache/beam/pull/17265#discussion_r842091890


##########
sdks/go/pkg/beam/core/funcx/fn.go:
##########
@@ -631,6 +647,8 @@ func nextRetState(cur retState, transition ReturnKind) (retState, error) {
 		return -1, errEventTimeRetPrecedence
 	case RetValue, RetRTracker:
 		return rsOutput, nil
+	case RetProcessContinuation:
+		return rsProcessContinuation, nil

Review Comment:
   Ordering-wise, what we could do here is comment out all of the information here that allows a RetProcessContinuation and wait until it's fully piped through. I'm not worried about the follow-up running over a branch cut at the moment given the timing, but I do understand where the worst-cast scenario is here since this pushes the error to DoFn invocation time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org