You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/08/13 03:38:01 UTC
[PR] chore(workflow-core): remove the unused VirtualCollection [texera]
aglinxinyuan opened a new pull request, #7620:
URL: https://github.com/apache/texera/pull/7620
### What changes were proposed in this PR?
Deletes `VirtualCollection` and its spec — an abstract class with no implementations and no call sites. Pure deletion, no behaviour change: **−198 lines**.
Nothing in the repository extends it. The storage layer's live abstractions are `VirtualDocument` and `ReadonlyVirtualDocument`, neither of which derives from it. With no subclass anywhere, no instance can exist, so none of its methods can run.
> Reviewer note: its spec exercises a private stub defined inside the spec file itself, which is why the class currently looks live. That spec covers this class and nothing else, so it goes with it. `VirtualDocument` and `ReadonlyVirtualDocument` are untouched.
### Any related issues, documentation, discussions?
Closes #7617
### How was this PR tested?
Existing tests only — this PR adds none, since it removes code and the spec that covered it.
Locally, from the repo root with Java 17:
- `sbt "WorkflowExecutionService/Test/compile"` — success (main and test sources).
Verification, re-runnable by a reviewer:
```
git grep -n VirtualCollection # only the two deleted files
git grep -n "extends VirtualCollection" # no implementations
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(workflow-core): remove the unused VirtualCollection [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7620:
URL: https://github.com/apache/texera/pull/7620#issuecomment-5275690298
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 0 better · 🔴 2 worse · ⚪ 13 noise (<±5%) · 0 without baseline
> Compared against main `a5563a9` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/31664514937)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| ⚪ | bs=10 sw=10 sl=64 | 519 | 0.317 | 17,995/27,009/27,009 us | ⚪ within ±5% / 🔴 +65.6% |
| 🔴 | bs=100 sw=10 sl=64 | 1,193 | 0.728 | 80,806/119,276/119,276 us | 🔴 +27.2% / 🟢 -20.3% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,424 | 0.869 | 697,657/785,254/785,254 us | ⚪ within ±5% / 🟢 +38.8% |
<details><summary>Baseline details</summary>
Latest main `a5563a9` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 519 tuples/sec | 541 tuples/sec | 775.33 tuples/sec | -4.1% | -33.1% |
| bs=10 sw=10 sl=64 | MB/s | 0.317 MB/s | 0.33 MB/s | 0.473 MB/s | -3.9% | -33.0% |
| bs=10 sw=10 sl=64 | p50 | 17,995 us | 18,287 us | 12,743 us | -1.6% | +41.2% |
| bs=10 sw=10 sl=64 | p95 | 27,009 us | 26,596 us | 16,310 us | +1.6% | +65.6% |
| bs=10 sw=10 sl=64 | p99 | 27,009 us | 26,596 us | 18,926 us | +1.6% | +42.7% |
| bs=100 sw=10 sl=64 | throughput | 1,193 tuples/sec | 1,241 tuples/sec | 1,001 tuples/sec | -3.9% | +19.2% |
| bs=100 sw=10 sl=64 | MB/s | 0.728 MB/s | 0.757 MB/s | 0.611 MB/s | -3.8% | +19.2% |
| bs=100 sw=10 sl=64 | p50 | 80,806 us | 80,984 us | 101,399 us | -0.2% | -20.3% |
| bs=100 sw=10 sl=64 | p95 | 119,276 us | 93,801 us | 108,206 us | +27.2% | +10.2% |
| bs=100 sw=10 sl=64 | p99 | 119,276 us | 93,801 us | 118,195 us | +27.2% | +0.9% |
| bs=1000 sw=10 sl=64 | throughput | 1,424 tuples/sec | 1,401 tuples/sec | 1,026 tuples/sec | +1.6% | +38.8% |
| bs=1000 sw=10 sl=64 | MB/s | 0.869 MB/s | 0.855 MB/s | 0.626 MB/s | +1.6% | +38.7% |
| bs=1000 sw=10 sl=64 | p50 | 697,657 us | 713,639 us | 996,304 us | -2.2% | -30.0% |
| bs=1000 sw=10 sl=64 | p95 | 785,254 us | 797,249 us | 1,042,531 us | -1.5% | -24.7% |
| bs=1000 sw=10 sl=64 | p99 | 785,254 us | 797,249 us | 1,074,934 us | -1.5% | -26.9% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,385.61,200,128000,519,0.317,17995.08,27008.71,27008.71
1,100,10,64,20,1676.70,2000,1280000,1193,0.728,80806.20,119276.35,119276.35
2,1000,10,64,20,14045.47,20000,12800000,1424,0.869,697656.58,785254.00,785254.00
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(workflow-core): remove the unused VirtualCollection [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7620:
URL: https://github.com/apache/texera/pull/7620#issuecomment-5275660831
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(workflow-core): remove the unused VirtualCollection [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7620:
URL: https://github.com/apache/texera/pull/7620#issuecomment-5275676551
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/7620?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 88.89%. Comparing base ([`c35bdb1`](https://app.codecov.io/gh/apache/texera/commit/c35bdb134cab4126b25c39974be3e29a0a17a672?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`83ace94`](https://app.codecov.io/gh/apache/texera/commit/83ace9401d983f2c31ec67e516b9863f95c34702?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #7620 +/- ##
=========================================
Coverage 88.89% 88.89%
Complexity 4348 4348
=========================================
Files 1179 1179
Lines 46919 46919
Branches 5230 5230
=========================================
Hits 41707 41707
Misses 3463 3463
Partials 1749 1749
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/7620/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/7620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [c35bdb1](https://app.codecov.io/gh/apache/texera/commit/c35bdb134cab4126b25c39974be3e29a0a17a672?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/7620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.62% <ø> (ø)` | | Carriedforward from [c35bdb1](https://app.codecov.io/gh/apache/texera/commit/c35bdb134cab4126b25c39974be3e29a0a17a672?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/7620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `84.70% <ø> (ø)` | | Carriedforward from [c35bdb1](https://app.codecov.io/gh/apache/texera/commit/c35bdb134cab4126b25c39974be3e29a0a17a672?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/7620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.38% <ø> (ø)` | | Carriedforward from [c35bdb1](https://app.codecov.io/gh/apache/texera/commit/c35bdb134cab4126b25c39974be3e29a0a17a672?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/7620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.31% <ø> (ø)` | | Carriedforward from [c35bdb1](https://app.codecov.io/gh/apache/texera/commit/c35bdb134cab4126b25c39974be3e29a0a17a672?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/7620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `68.90% <ø> (ø)` | | Carriedforward from [c35bdb1](https://app.codecov.io/gh/apache/texera/commit/c35bdb134cab4126b25c39974be3e29a0a17a672?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/7620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.57% <ø> (ø)` | | Carriedforward from [c35bdb1](https://app.codecov.io/gh/apache/texera/commit/c35bdb134cab4126b25c39974be3e29a0a17a672?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/7620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.89% <ø> (ø)` | | |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/7620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `97.52% <ø> (ø)` | | Carriedforward from [c35bdb1](https://app.codecov.io/gh/apache/texera/commit/c35bdb134cab4126b25c39974be3e29a0a17a672?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/7620/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.89% <ø> (ø)` | | Carriedforward from [c35bdb1](https://app.codecov.io/gh/apache/texera/commit/c35bdb134cab4126b25c39974be3e29a0a17a672?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/7620?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(workflow-core): remove the unused VirtualCollection [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #7620:
URL: https://github.com/apache/texera/pull/7620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org