You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Hugo Trippaers <ht...@schubergphilis.com> on 2012/06/29 08:52:00 UTC
Review Request: Make xen.check.hvm a proper parameter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5655/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
Make xen.check.hvm a proper parameter in config.java and set the default to false
Diffs
-----
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java 4fd202b
server/src/com/cloud/configuration/Config.java 8936544
Diff: https://reviews.apache.org/r/5655/diff/
Testing
-------
Simple build
clean-all build-all
Thanks,
Hugo Trippaers
Re: Review Request: Make xen.check.hvm a proper parameter
Posted by Alex Huang <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5655/#review11135
-----------------------------------------------------------
It shouldn't use the hardcoded string but the Config.XenCheckHvm. Please correct that. Leaving it in the DB is fine.
- Alex Huang
On June 29, 2012, 6:52 a.m., Hugo Trippaers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5655/
> -----------------------------------------------------------
>
> (Updated June 29, 2012, 6:52 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Make xen.check.hvm a proper parameter in config.java and set the default to false
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java 4fd202b
> server/src/com/cloud/configuration/Config.java 8936544
>
> Diff: https://reviews.apache.org/r/5655/diff/
>
>
> Testing
> -------
>
> Simple build
> clean-all build-all
>
>
> Thanks,
>
> Hugo Trippaers
>
>
Re: Review Request: Make xen.check.hvm a proper parameter
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
> On June 29, 2012, 10:28 p.m., disheng su wrote:
> > xen.check.hvm should be put into component.xml.in, like what we did for configurationdao
> > <dao name="Configuration configuration server" class="com.cloud.configuration.dao.ConfigurationDaoImpl">
> > <param name="premium">true</param>
> > </dao>
> >
Should we make it a hidden parameter?
If i understand the code correctly anything specified in the components.xml param section overrides the default in Config.java
- Hugo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5655/#review8767
-----------------------------------------------------------
On June 29, 2012, 6:52 a.m., Hugo Trippaers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5655/
> -----------------------------------------------------------
>
> (Updated June 29, 2012, 6:52 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Make xen.check.hvm a proper parameter in config.java and set the default to false
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java 4fd202b
> server/src/com/cloud/configuration/Config.java 8936544
>
> Diff: https://reviews.apache.org/r/5655/diff/
>
>
> Testing
> -------
>
> Simple build
> clean-all build-all
>
>
> Thanks,
>
> Hugo Trippaers
>
>
Re: Review Request: Make xen.check.hvm a proper parameter
Posted by disheng su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5655/#review8767
-----------------------------------------------------------
xen.check.hvm should be put into component.xml.in, like what we did for configurationdao
<dao name="Configuration configuration server" class="com.cloud.configuration.dao.ConfigurationDaoImpl">
<param name="premium">true</param>
</dao>
- disheng su
On June 29, 2012, 6:52 a.m., Hugo Trippaers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5655/
> -----------------------------------------------------------
>
> (Updated June 29, 2012, 6:52 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Make xen.check.hvm a proper parameter in config.java and set the default to false
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java 4fd202b
> server/src/com/cloud/configuration/Config.java 8936544
>
> Diff: https://reviews.apache.org/r/5655/diff/
>
>
> Testing
> -------
>
> Simple build
> clean-all build-all
>
>
> Thanks,
>
> Hugo Trippaers
>
>
Re: Review Request: Make xen.check.hvm a proper parameter
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5655/#review14756
-----------------------------------------------------------
Hugo, is this review still applicable? If not close it or apply a fix?
- Rohit Yadav
On June 29, 2012, 6:52 a.m., Hugo Trippaers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5655/
> -----------------------------------------------------------
>
> (Updated June 29, 2012, 6:52 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Make xen.check.hvm a proper parameter in config.java and set the default to false
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java 4fd202b
> server/src/com/cloud/configuration/Config.java 8936544
>
> Diff: https://reviews.apache.org/r/5655/diff/
>
>
> Testing
> -------
>
> Simple build
> clean-all build-all
>
>
> Thanks,
>
> Hugo Trippaers
>
>