You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/05/26 04:59:40 UTC
[GitHub] [james-project] chibenwa opened a new pull request, #1023: WIP get rid of Reactor Elastic scheduler
chibenwa opened a new pull request, #1023:
URL: https://github.com/apache/james-project/pull/1023
-> Convert blocking non-reactor calls to boundedElastic
-> Convert calls that wraps reactor.block call in a dedicated scheduler to avoid starvation
-> Remove unneeded subscribeOn calls
-> Reactify things slightly better where possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #1023: JAMES-3773 get rid of Reactor Elastic scheduler
Posted by GitBox <gi...@apache.org>.
Arsnael commented on PR #1023:
URL: https://github.com/apache/james-project/pull/1023#issuecomment-1144352218
Rebase needed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #1023: JAMES-3773 get rid of Reactor Elastic scheduler
Posted by GitBox <gi...@apache.org>.
chibenwa merged PR #1023:
URL: https://github.com/apache/james-project/pull/1023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1023: JAMES-3773 get rid of Reactor Elastic scheduler
Posted by GitBox <gi...@apache.org>.
quantranhong1999 commented on code in PR #1023:
URL: https://github.com/apache/james-project/pull/1023#discussion_r884665591
##########
mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraUidProvider.java:
##########
@@ -77,7 +77,7 @@ public CassandraUidProvider(Session session, CassandraConfiguration cassandraCon
this.insertStatement = prepareInsert(session);
Duration firstBackoff = Duration.ofMillis(10);
this.retrySpec = Retry.backoff(cassandraConfiguration.getUidMaxRetry(), firstBackoff)
- .scheduler(Schedulers.elastic());
+ .scheduler(Schedulers.parallel());
Review Comment:
Q: Why are there somewhere you switch `.elastic` to `.parallel` and somewhere else to `.boundedElastic`?
BTW I thought that we should not do a potential blocking job (here use elastic before) on a parallel thread?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a diff in pull request #1023: JAMES-3773 get rid of Reactor Elastic scheduler
Posted by GitBox <gi...@apache.org>.
chibenwa commented on code in PR #1023:
URL: https://github.com/apache/james-project/pull/1023#discussion_r884688723
##########
mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraUidProvider.java:
##########
@@ -77,7 +77,7 @@ public CassandraUidProvider(Session session, CassandraConfiguration cassandraCon
this.insertStatement = prepareInsert(session);
Duration firstBackoff = Duration.ofMillis(10);
this.retrySpec = Retry.backoff(cassandraConfiguration.getUidMaxRetry(), firstBackoff)
- .scheduler(Schedulers.elastic());
+ .scheduler(Schedulers.parallel());
Review Comment:
A: When it's just about delays elastic scheduler is overkill. We are not dealing with a blocking task hence parallel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1023: WIP get rid of Reactor Elastic scheduler
Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #1023:
URL: https://github.com/apache/james-project/pull/1023#issuecomment-1139538970
I confirm the staged approach solves the dead locks cf last fixup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #1023: JAMES-3773 get rid of Reactor Elastic scheduler
Posted by GitBox <gi...@apache.org>.
Arsnael commented on PR #1023:
URL: https://github.com/apache/james-project/pull/1023#issuecomment-1143051361
```
java.lang.NullPointerException
at org.apache.james.events.RabbitMQEventBusTest.tearDown(RabbitMQEventBusTest.java:139)
```
For all tests in RabbitMQEventBusTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org