You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/04/22 13:38:15 UTC

[GitHub] [incubator-inlong] gong commented on a diff in pull request #3886: [INLONG-3884][Sort]Add csv format for ExtractNode and LoadNode

gong commented on code in PR #3886:
URL: https://github.com/apache/incubator-inlong/pull/3886#discussion_r856237796


##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/format/JsonFormat.java:
##########
@@ -88,35 +88,54 @@ public String getFormat() {
 
     /**
      * Generate options for connector
-     *
+     * @param includePrefix true will need append key and value when format is json avro csv
      * @return options
      */
     @Override
-    public Map<String, String> generateOptions() {
+    public Map<String, String> generateOptions(boolean includePrefix) {

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org